From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2665C3ABB2 for ; Mon, 16 Sep 2024 16:15:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0F34F6B0096; Mon, 16 Sep 2024 12:15:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0A4236B0098; Mon, 16 Sep 2024 12:15:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E85596B0099; Mon, 16 Sep 2024 12:15:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id CD7786B0096 for ; Mon, 16 Sep 2024 12:15:35 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 4FE8A405AD for ; Mon, 16 Sep 2024 16:15:35 +0000 (UTC) X-FDA: 82571101830.27.873690E Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by imf16.hostedemail.com (Postfix) with ESMTP id 60F4A180009 for ; Mon, 16 Sep 2024 16:15:33 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=e6K3Hjpi; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf16.hostedemail.com: domain of miguel.ojeda.sandonis@gmail.com designates 209.85.216.41 as permitted sender) smtp.mailfrom=miguel.ojeda.sandonis@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726503324; a=rsa-sha256; cv=none; b=XotgOiugwVmoayWfj0RPmat0NtZHo9XOkMIJzATdPtGAW/YzmVOKLfrLjhpwypD87CwWjO lO8AYIrbD2gJ7ttra41ZGvTljsJIIng/MSwIrDYFV17ESp+BiyBjG7wzxG8YZWkZzzucsk wv69IHoVyWuwUnH0qSUGcMkoaQm45Ts= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=e6K3Hjpi; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf16.hostedemail.com: domain of miguel.ojeda.sandonis@gmail.com designates 209.85.216.41 as permitted sender) smtp.mailfrom=miguel.ojeda.sandonis@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726503324; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UdCaaZaGAuNxnOSLC5REDzZqrguiE6BbNpi1q+AVJDM=; b=X7y2gXO3IeXdmSJ3cTHUxJt15zz5uK8pp5apgoCYf9DDZWcCQRFEwbKLfeYUGwx1Cna9PY JBW2yyRfGp4o5Ig8rm86Qhg93km3iaCU6LGrAH3CuEykEvsacO2E6qtCU+jPLvVeMJ0YPk oQyXAdBjn1fn8pvbgQwFl6cj2JMkNm4= Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-2d871bd95ffso859351a91.2 for ; Mon, 16 Sep 2024 09:15:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726503332; x=1727108132; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=UdCaaZaGAuNxnOSLC5REDzZqrguiE6BbNpi1q+AVJDM=; b=e6K3HjpiRDaJcK2zRnCjyZiTwHAJlOlPn1pTIWaOyh7iuQhKzVbcU2L2m6UdBf5fVT 1d2Kg4vHkpFQOtdlQRKAeoi7Wt6bl+arJ1YssgkUjOPJN6Ot810ZPIwvgWlPsFgr8UWW RlYK/XGEiOZTpKnYgqT0Vqup31UQFYDd02JydxHiL+Yew1WwdJVuK7VGsHELwr/wt3Bw UZYgBKps8uw9oXEAVebhIshFnw4N7opXiN3UvX5Z/Wy+y/zqSfEfo+XspW40v+1y8ucO 1vFF0lgZAopBv4c8rYG254gYIs2ur/FMEtAJbIpfuCVvMs85oP9aUkexI3HMblmdNgxF MnJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726503332; x=1727108132; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UdCaaZaGAuNxnOSLC5REDzZqrguiE6BbNpi1q+AVJDM=; b=qA7NUy7v1VwuW5lEX7sX08sh/fDK2xojZnZ8IzbJM5KXaoQsvTJYmVI+hLWEGm6rxZ SswulNY1TQG8qZgNtPangscE2XAzuUThIWYw2aUfvcUxPGfY0ATA6L2Btfbk1++J1jMB w6qp6GyP6e7BzinQKFYRABEcDmybqUyv90fi3UZe3wO6yILaQOu7+gcN9C9KjidM10kk j14eQIU2QnqbrroIoSd2DfQO/QYcAmnLCPbcveNPP8BreDf7Yvc5br51cMbV8l0ThiL8 k9sdyHC0Bqmf1YREovzASkuP8tg2uXuaubw7XYC5KW82lAwo7yA8Plp51oVNGwz/kMCS IwrQ== X-Forwarded-Encrypted: i=1; AJvYcCUmvRjJNYQyrE4KL3CuxOuAj01fW/FO0yHF42PNLrWZKiT8a0LcVBLywg6U9SAdqamf7k1auf7iqA==@kvack.org X-Gm-Message-State: AOJu0YxDQymWDujpslB8p4n5s/NPj+3fkf+mB8bA72fKczC8fCBjyhxa MT56NmtUcbXOKgY0oh4VWppTf6AD+ZsC3jgwDfnsXUT4CGEU/4fj4UUQjw7XMIdwrX99/pxLd1I Ct9bNAjyShIqpfKPcVZIF+C9r2lPjghzvUnE= X-Google-Smtp-Source: AGHT+IFWqKrB/jwwfMGDT0N94zreaBigF9XO/ixKs8bzKIeBFXv7PUaej4KHwjCw+M371MDTiFimmNQTj/1U22Qe65g= X-Received: by 2002:a17:90a:f308:b0:2db:60b:9be4 with SMTP id 98e67ed59e1d1-2dba007b059mr7383255a91.7.1726503332118; Mon, 16 Sep 2024 09:15:32 -0700 (PDT) MIME-Version: 1.0 References: <20240820194910.187826-1-mmaurer@google.com> In-Reply-To: <20240820194910.187826-1-mmaurer@google.com> From: Miguel Ojeda Date: Mon, 16 Sep 2024 18:15:19 +0200 Message-ID: Subject: Re: [PATCH v4 0/4] Rust KASAN Support To: Matthew Maurer Cc: andreyknvl@gmail.com, ojeda@kernel.org, Alex Gaynor , Wedson Almeida Filho , Nathan Chancellor , dvyukov@google.com, aliceryhl@google.com, samitolvanen@google.com, kasan-dev@googlegroups.com, linux-mm@kvack.org, glider@google.com, ryabinin.a.a@gmail.com, Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Nick Desaulniers , Bill Wendling , Justin Stitt , rust-for-linux@vger.kernel.org, llvm@lists.linux.dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: mdxq167r5cez81fzfgbd7yi3zuohhxxc X-Rspamd-Queue-Id: 60F4A180009 X-Rspamd-Server: rspam02 X-HE-Tag: 1726503333-450752 X-HE-Meta: U2FsdGVkX19L2uB8FjefcTskDuWdM17kYhvjLeszpENzgMxt1/pqgOPsZvDAJEcacFn3Ky8Y8rjVlhq6LLLn0h9do7vAG3BeO22iMr6m/Xrn8OpupI2hvu4qXm1GX4RRGYSWFnPzAdz5dQ50i4HRNIgEiqCUUorIbcSbqMvWPwtNca8CXWI9SYpepqp52kAZFBrE2QeOpN8nm8xT4P8wERj2L79AQG0DLVSM4iqQzJUc/CKd2l2w+D3qnkBG6QP5w0FrK1U21hDfW9Bnzb+ZNVASpssyDtBxMqe5YsMnPo4++G18Qmd0xP4eUyz9ta0jDw7eYXgaAGASNpRdDCft9RUzHQfjRAozlborzoRVFVU+5MHWbHKcpAQ9NH6/dCQLPUiZFesusuyzDCJzsf/UvT8gcS7+fLNMoEj5bb533XV8F/quJ9+71iiAYbBYgYW3HxVqTQKQ/9GtZyHnNzsOmDmLX6kZ46W2dxQSg3o/dAaGCCEIXRLbfSn2Nua4Y3dCpiyhMpYF8/WRpYfgcqUIRgsBl5LEqJfzL0p/JLtOJeEcFFkf0BLgB2xYHbbimmF4F1ym7Yqur1B4CP/UxgD+lN97Rib29gz0We3V5Szqb+yl60QfOJxMO2vtKDiLB+kcDWbXqMH/3v2368sGg3qsUQcIYuiFk3dLXAIEOVPGcZ+t3+60vt2FeLXYdkFpGP/m2aKmaAT15vGCxRmDQ9Zlg11tTC1ABGXdtN+K1LbKMjlLvpK7FJ0FeWQs5e6S18C3LtzBlVStk4sKzo3rVw1OWiE8Fut7qGwmFUiBsN28ZLb/dceBozXIAkWRccvw3G9snK5ysiS9Ehh7sn3a5S+AZstgUndgfqogbxsdNnyfJHGX7F6jTsr0ja2QJo4dHdsYs/MZitPJfF5B2yKdVEVN0f8qRaMFUOJ0DVy88f2uuF5szL0tZegdUfO9mcsJJn7XVbHTpbGLUQ7B9Mw7GHs IHL0q3dz x3TJ+nSxL6NnrWlrhSeSezHAIgHWRL6aRxtQ7nObTcwLu3YAy1vyFXU2RduyqpPzuUAphsb/xfEgCCSm4Kh9VkMMKnlFnVFK/FzcsiU5zPa9ickKqIFw8KhT4JQFi4h2wPa3Zs+r/Dam7GaV2jcEupKvryZNpGmb2maajLpdtklWM7DOIs8MM+dBEBf1yHc87Tkq0q+PqVbGSW4BdawHNqRYvyebZFl8v9jdAW4zlpvTKK1qZspNvu51zD7DDIXdy8sNWXHPbA7q2WLxXNUDdUc0b6+8U7PSjAJ01lW24QyIJwNUr7acNRkEWECOG3nX5GCKNZnzE6+vFb0qjBhoL7yAXVPiKn7ZwXf/zwp8HJRLw19+oVW0Oc9OJlstzX14eJUMg04di372AIK3TGihaeScaWRF8OonlEaLzXzG5ALtkMFhtGbO0L9vI18+NT2VSrocfVK6Dm+sEuMGM/CCUbCIHBqFrea1vpk8C X-Bogosity: Ham, tests=bogofilter, spamicity=0.003705, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Aug 20, 2024 at 9:49=E2=80=AFPM Matthew Maurer = wrote: > > Right now, if we turn on KASAN, Rust code will cause violations because > it's not enabled properly. > > This series: > 1. Adds flag probe macros for Rust - now that we're setting a minimum rus= tc > version instead of an exact one, these could be useful in general. We = need > them in this patch because we don't set a restriction on which LLVM ru= stc > is using, which is what KASAN actually cares about. > 2. Makes `rustc` enable the relevant KASAN sanitizer flags when C does. > 3. Adds a smoke test to the `kasan_test` KUnit suite to check basic > integration. > > This patch series requires the target.json array support patch [1] as > the x86_64 target.json file currently produced does not mark itself as KA= SAN > capable, and is rebased on top of the KASAN Makefile rewrite [2]. Applied to `rust-next` -- thanks everyone! [ Applied empty line nit, removed double empty line, applied `rustfmt` and formatted crate comment. - Miguel ] [ Applied "SW_TAGS KASAN" nit. - Miguel ] I think `TMPOUT` needs to be passed though, i.e. like I did in https://github.com/Rust-for-Linux/linux/pull/1087#issuecomment-2218445303: diff --git a/scripts/Makefile.compiler b/scripts/Makefile.compiler index 057305eae85c..0ac8679095f4 100644 --- a/scripts/Makefile.compiler +++ b/scripts/Makefile.compiler @@ -20,6 +20,7 @@ TMPOUT =3D $(if $(KBUILD_EXTMOD),$(firstword $(KBUILD_EXTMOD))/).tmp_$$$$ # Exit code chooses option. "$$TMP" serves as a temporary file and is # automatically cleaned up. try-run =3D $(shell set -e; \ + TMPOUT=3D$(TMPOUT); \ TMP=3D$(TMPOUT)/tmp; \ trap "rm -rf $(TMPOUT)" EXIT; \ mkdir -p $(TMPOUT); \ Or is there something I am missing? Cheers, Miguel