From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4AF4C54E4A for ; Fri, 8 Mar 2024 15:23:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 267DD6B03A0; Fri, 8 Mar 2024 10:23:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1F1866B03A1; Fri, 8 Mar 2024 10:23:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 093BF6B03A2; Fri, 8 Mar 2024 10:23:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id EB3056B03A0 for ; Fri, 8 Mar 2024 10:23:46 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 91E2AA04D0 for ; Fri, 8 Mar 2024 15:23:46 +0000 (UTC) X-FDA: 81874241652.11.2F595C0 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) by imf17.hostedemail.com (Postfix) with ESMTP id E304540009 for ; Fri, 8 Mar 2024 15:23:44 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=LvhdEYk+; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of miguel.ojeda.sandonis@gmail.com designates 209.85.215.178 as permitted sender) smtp.mailfrom=miguel.ojeda.sandonis@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709911424; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bcBcmCbNUNK8QMRYlD0suSpFuYeDhzgpUC/IVV9/I8w=; b=JmC8iHbtFgwmUU+kzTSY/b1V/nBRA6BVXzJglP0RrrRSY5G5q1dTxTLYgJqNQxqNIuq+yX d0RUuc9kdlSsOgGhA8tPArPxfA4kGZrU+DlRhnnqpsRpW+K8UvAs2cyyycSiN/JK3C9unG DuAWHsl2yWEAeu/PHidvgMekJOb9t9s= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=LvhdEYk+; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of miguel.ojeda.sandonis@gmail.com designates 209.85.215.178 as permitted sender) smtp.mailfrom=miguel.ojeda.sandonis@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709911424; a=rsa-sha256; cv=none; b=agaryrVAYxJmHNiOQirPnnguxxfQYzV5POG3vuFamNk4NhMtW04L6U4AL/6alxMtvIED8+ CWmL8F9CPEmri+oZ2FwAWWhHEDuIv46/5TUE5NtmutkWQxhfHjjD/emsGpaKyXF9bBDTqI UUi7ARSUGFXolnCJHNK8qXSZAoj1bVE= Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-517ab9a4a13so1925356a12.1 for ; Fri, 08 Mar 2024 07:23:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709911424; x=1710516224; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=bcBcmCbNUNK8QMRYlD0suSpFuYeDhzgpUC/IVV9/I8w=; b=LvhdEYk+wkVlU/0/BC+jYTd9w1ELUMFKcbboMgsNaTBztz+Yx9QOhfCHBWXV3UYTYA tq3jds7Yf8hhvHP2CkdzKxHlRgWkgpj+D7XXCCwSlGUQIjHuHR0A4ko+0x6sPPSeVTj7 06htQ3onmes15PDxGZLt8sUCw9UhOFssmPpxLuo8LdHsZTuDAeST7zt5FqQoqz3Lugrt qkbt/HPoH98zJpkinV4S0pdvaWlrkBYlhbZAQTVA+NLz8oSRleAtW0g58cLRCTfkvQyb BDpzx5Mjles+L9bVRKYvvVHSb7YlgtNkFSPFbB3JD6VnuH1sO4P6Ej9aVFKlCBAl6gpo lFBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709911424; x=1710516224; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bcBcmCbNUNK8QMRYlD0suSpFuYeDhzgpUC/IVV9/I8w=; b=tHO+RzmQoS7mHeSKFhLYcbrwv1Mjl6gg50vgaAtRIirN1UC1AiMCR9nSy4MSbkdlUb Z5FO/uShJOTrBstOAsCnecDZN5v6YZQKwfnUxJWZgbhHOq65x+9bssRdrELb2s46JAHH Dg7GBjplEh6mc1NaDVZVXRWI4fU7HUAfFL7VQZLSvkjtdo7rVxDcaxEXKRbfGVZTI2l7 4u189QY+IozrYO77LcghT3Wx4pEEDOuu2LuD7gzT1uH85MhXc8Rz/bYzyz7MjEZIAYQd plQGFFaAJxAWmaatl76iHoc2HrDNA2R37mBBwrCOXdnFSGqgVPxA5fKUVCMVn1cX/bA1 vC4A== X-Forwarded-Encrypted: i=1; AJvYcCVG/O7OJ5RA2PIEDLsnfpFVfmoxlzrkODlnvBvLkR8F2sSB8W/jVdddyAUp3W3qc//O8NdX/Igcxx9JaYQTqf/91DA= X-Gm-Message-State: AOJu0Yx/2+EqWvdW8qrfh3BaEfLn1m6MnT75uM1Lbf8iWt7+smmLjblj KTaOBwpy/5Tf7g0OYf/PVPWFGx19vQzcm2iC8o3VjWjR/1I7S1EYPgISbOX+0f7R9L7IDTqOrya jOaBG2tmonvuCysThU8DOOnZeueHeVRRjxIc0gNV3 X-Google-Smtp-Source: AGHT+IF9xXotb4fKJPIBJiGa5DZoshLJXVEv2bCNouhUyzFoUp1xvycg5pN3kRgz/qcs+lTDSybyD1fvb7+yeBualoQ= X-Received: by 2002:a17:90b:613:b0:29b:90d7:36dc with SMTP id gb19-20020a17090b061300b0029b90d736dcmr281082pjb.19.1709911423609; Fri, 08 Mar 2024 07:23:43 -0800 (PST) MIME-Version: 1.0 References: <20240306182440.2003814-1-surenb@google.com> <20240306182440.2003814-25-surenb@google.com> In-Reply-To: <20240306182440.2003814-25-surenb@google.com> From: Miguel Ojeda Date: Fri, 8 Mar 2024 16:23:30 +0100 Message-ID: Subject: Re: [PATCH v5 24/37] rust: Add a rust helper for krealloc() To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, jhubbard@nvidia.com, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, aliceryhl@google.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org, Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , rust-for-linux@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: E304540009 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: psurrcdy1y51sjcm8jujhowd7dp3nsnh X-HE-Tag: 1709911424-107746 X-HE-Meta: U2FsdGVkX1/3VTmbqE4+k0eDELkg0AR5NU+Sn1jbkg3kYANdfdEjYg+/FndGBbovTvFbsbTWPpOZ1qRWXuduCTokU619+bZ+iH1rVeoFKN8InT1FtAERzwIE3cnH++te1UV3hXBGyRlhqAWKPaBlQ4rzfMQ5acvIbhlfrC/1tTGxmKYpiUefXDl1hWbA6opctX9mRJxavd7hLPTrAAj5JB95aShEKwbJ/gc1AQyh6i3BbMfnfdOmc/ts6D+6qD7mZfL+Dd5KtaN2lqb7i5NZz8aTS3IOjpktJkV6nYhB6thIWK6dytgoLly8ocYJbdVI3FJHokuoumu92cy38WWrKDTtwrUasgJC9ZOO6IbxuhN+4ewG88FGRJN8PdBmHRMYTU+NKp7/4JkyvbLi4N8+bGbKT3BIQOMa/gvGZHBnChJ4JZXa1m0mO/CyiMOhe2wsNakJbl5Pb6UdVOisp9OfFThwJ8hUpff6e1gE0Vj2eQt2SpwOpxnph2dkuGgQ7Y9lc5/HNJQrJiXDGTqZLKLCPxwsrznS7ZWviA88+ytvYwXu7Y/J/96bW0RLgLcryDnpnTEHYbekArPu0CXUnnwFxLCKgi7oXtaHrcejXt6LOZWKVxGqp+GuqRYyl4VpgSDcRBV0U1pbNZEj6I4+DZqXgi9FoSIy2W7b4TUSn92zSEq9a148DgVOdxKLA1vxgMXatmVPV/18iqTfmyKUalYJv8GXGZmnCnLKpEcv5RzsA4iNFWCCwU06CGX0v4o2gmprpIcPjsjhQsseHgGlYRVwaDsB2HwdMNoRyBT9PooIliekfO/SuzL9fhkxJdLpvFOVMmIa3zTrzSXST/ZRXEuNoM7aEOJmcMqoCqfc3svhBWVn+qVlXQhy2PYlZokcVpxcsNO8jNCgOy1Lfys4aRfyqQqxlwXCAp8ETu6iFSyyI/ffPftbo6OHknb93FuRRKHoRXNBKVOjC/e+ZjZuhCp s2D45ozB J0UL34KnNSZ/x7m81b/IEZM07P8mEN5JMGbHaelRQEgb3idMAw0HVhQjj5N6tMbimO2N4HnfBeO3G8boLHCyIGsca/KMtynuWR4hw9I0dj3PkAetDtkX67gCtiPAAyYVVv6FaJEUQvxUXF48= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000041, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 6, 2024 at 7:26=E2=80=AFPM Suren Baghdasaryan wrote: > > +void * __must_check rust_helper_krealloc(const void *objp, size_t new_si= ze, > + gfp_t flags) __realloc_size(2) The `__realloc_size(2)` should be placed earlier, i.e. this triggers: rust/helpers.c:162:20: error: GCC does not allow '__alloc_size__' attribute in this position on a function definition [-Wgcc-compat] With that fixed: Acked-by: Miguel Ojeda Cheers, Miguel