From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2466C433E0 for ; Thu, 4 Jun 2020 15:22:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A60BE2072E for ; Thu, 4 Jun 2020 15:22:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="L2DmN0uX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A60BE2072E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3E54980007; Thu, 4 Jun 2020 11:22:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 395E88E0006; Thu, 4 Jun 2020 11:22:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2AAB880007; Thu, 4 Jun 2020 11:22:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0144.hostedemail.com [216.40.44.144]) by kanga.kvack.org (Postfix) with ESMTP id 11BC08E0006 for ; Thu, 4 Jun 2020 11:22:30 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id C41D2802CD59 for ; Thu, 4 Jun 2020 15:22:29 +0000 (UTC) X-FDA: 76891896018.07.flag51_15b3ff67eff55 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin07.hostedemail.com (Postfix) with ESMTP id 6FD1018079ED8 for ; Thu, 4 Jun 2020 15:22:29 +0000 (UTC) X-HE-Tag: flag51_15b3ff67eff55 X-Filterd-Recvd-Size: 4480 Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) by imf27.hostedemail.com (Postfix) with ESMTP for ; Thu, 4 Jun 2020 15:22:28 +0000 (UTC) Received: by mail-lj1-f193.google.com with SMTP id n24so7768583lji.10 for ; Thu, 04 Jun 2020 08:22:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Hll+dJXiojyLXcK519mMreswBK6PHaxvzDLgh0p26WU=; b=L2DmN0uXC2KyUjBXJZi+YdM6TZcgHaAo/hwU1tP/L4478bcM5q0UoroK+b7mXP2R4P CY4dtFPVvkSyAVNSadDFjTzPdwsP+D6eUqcI3kZvGZ6ajCkMMqMOFbgr3IfT104hlH1u lRWeEsjQCwyQyAj9FSqtUsV2OVn1GCiiakgSfTvZ8K2MYTUl7u0hUTkpplg3e1KrWY/9 snhpOMwvfzp6FxIPzFqDy43iUYePSSShfDdso4J4gku4w5tWVs2i8FRQHbva/jSkg7vd YZLPjLfOXFlhjCK9IXDlSvavi8M3D5kpvb1fwEUGzSEYis+R9Un5BXefFLYIPHMBjNN1 WgrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Hll+dJXiojyLXcK519mMreswBK6PHaxvzDLgh0p26WU=; b=TizOvSCO18JoVtrhCkt3C4zW0YG+KeXs7YJkAqHMsF9pdQuhcTK0kzA2fPybktbhO9 K6FrvYGPrgIhPezmgzgiov9ADGOLfXvfOcSYatwAKlfg5rezXO5gsStOMWiak3zRlwbU k5vTopnidfQXxD+eXPKlGFDyt1+VoH6gOQdG1LGtoZuKOyRBMhDTkYlV1GmjFKBvEfDQ mlsjDhD2lJb4CwpSBrpXUJlimfioBrlTmh3vjgx9SDn6+BOrmOOkqc1jPb0R1nCAP0qj H8sgTpMsUC09AWIqs+cuV6rURo6mcvPHQjUAvFQKlYgjEpQ/rc5KTnobFDMy3FmEdOU8 buzg== X-Gm-Message-State: AOAM533HCqr2r9ARl5rVaBADmTtYnW65CCdMzOHV6iHREsycjsKGwDi0 dtnNn4/LH0hmoFglsW5LQmmsFbR66LvNqX18cPQ= X-Google-Smtp-Source: ABdhPJxQH/KP1voSsxjAeba8kcNASoNK9+7gLFDlFHUbaiNIt96Mc8wIex8PnUIxUMkLvQS6umX4ZEAcM7RZRhjcGv4= X-Received: by 2002:a2e:a544:: with SMTP id e4mr2625204ljn.264.1591284147467; Thu, 04 Jun 2020 08:22:27 -0700 (PDT) MIME-Version: 1.0 References: <20200603233203.1695403-2-keescook@chromium.org> <874krr8dps.fsf@nanos.tec.linutronix.de> <202006040745.525ECD1@keescook> In-Reply-To: <202006040745.525ECD1@keescook> From: Miguel Ojeda Date: Thu, 4 Jun 2020 17:22:15 +0200 Message-ID: Subject: Re: [PATCH 01/10] x86/mm/numa: Remove uninitialized_var() usage To: Kees Cook Cc: Thomas Gleixner , linux-kernel , Linus Torvalds , Alexander Potapenko , Joe Perches , Andy Whitcroft , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , drbd-dev@lists.linbit.com, linux-block@vger.kernel.org, b43-dev@lists.infradead.org, Network Development , linux-wireless , linux-ide@vger.kernel.org, linux-clk@vger.kernel.org, linux-spi@vger.kernel.org, Linux-MM , clang-built-linux , Masahiro Yamada Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 6FD1018079ED8 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 4, 2020 at 4:56 PM Kees Cook wrote: > > Er? That's not what it looked like to me: > > #define IS_BUILTIN(option) __is_defined(option) > #define IS_ENABLED(option) __or(IS_BUILTIN(option), IS_MODULE(option)) > > But just to be sure, I just tested in with a real build: > > [ 3.242160] IS_ENABLED(TEST_UNDEF) false > [ 3.242691] __is_defined(TEST_UNDEF) false > [ 3.243240] IS_ENABLED(TEST_VALUE_EMPTY) false > [ 3.243794] __is_defined(TEST_VALUE_EMPTY) false > [ 3.244353] IS_ENABLED(TEST_VALUE_1) true > [ 3.244848] __is_defined(TEST_VALUE_1) true > > and nope, it only works with a defined value present. You are right, it follows the Kconfig logic, returning false for defined-but-to-0 too. We should probably add an `IS_DEFINED()` macro kernel-wide for this (and add it to the `coding-guidelines.rst` since `IS_ENABLED()` is mentioned there, with a warning not to mix it with `__is_defined()` which looks it was only intended as an implementation detail for `include/linux/kconfig.h`). CC'ing Masahiro by the way. Cheers, Miguel