From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97B9EC3DA4A for ; Wed, 14 Aug 2024 15:37:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 138E76B0083; Wed, 14 Aug 2024 11:37:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0E9446B0085; Wed, 14 Aug 2024 11:37:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EF2A76B0093; Wed, 14 Aug 2024 11:37:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D0B7E6B0083 for ; Wed, 14 Aug 2024 11:37:12 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 90207140EDF for ; Wed, 14 Aug 2024 15:37:12 +0000 (UTC) X-FDA: 82451254704.02.C931BF2 Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) by imf19.hostedemail.com (Postfix) with ESMTP id BF2B51A0007 for ; Wed, 14 Aug 2024 15:37:10 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=QGM4Wyta; spf=pass (imf19.hostedemail.com: domain of miguel.ojeda.sandonis@gmail.com designates 209.85.215.173 as permitted sender) smtp.mailfrom=miguel.ojeda.sandonis@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723649760; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cqf02PglwzMnUewsw7C/MM2gxFs0r5loGQKEe2O/En8=; b=IaJIEFB3jbMQkc6SrcwUgdgtJ3j1cfpEVNoTe1DqtYQeC0FXnJnzIgEeusBBMj5FYb9c9p Pj4W5aIMCcgi2GAVt3JUp9yZAo/TAoHcizva2YbVD4ReiKrZMPMksVaIJ1ap4QJXeFgTPK 98Ip4MHUCxIoh+5COE81RKumubc2P20= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723649760; a=rsa-sha256; cv=none; b=CgmQAdOI7rMDjh/i+b5T4xaTKE5W5G0KDMlIr2OaJagdHRqNZ+/T3Co4vgoqLlPVkmMOXz u3x1phXKhcvNf15/US0RJ8oB0baRu+WDgppVJ4osZx10jBK8z78qTyh+mOGqEP7axcUo+e gE8HSBrSEaKIKJVZQ+4kF0Eja32bb44= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=QGM4Wyta; spf=pass (imf19.hostedemail.com: domain of miguel.ojeda.sandonis@gmail.com designates 209.85.215.173 as permitted sender) smtp.mailfrom=miguel.ojeda.sandonis@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-76cb5b6b3e4so48237a12.1 for ; Wed, 14 Aug 2024 08:37:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723649829; x=1724254629; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=cqf02PglwzMnUewsw7C/MM2gxFs0r5loGQKEe2O/En8=; b=QGM4Wyta/2ZGzMAZy8lQZ+34C9/aiC49+6je2NX2UDxIViuxDUKUogwzyRXEQBQ4Fx NA+OgkuhiOhAoKCnBBpMIQNDmr9CBy8YyN6ORRApql3cHN2Uhqe5cmUKLA5JwNi6Ylne jW3miPtZ5c01EcmnAhbJAkUIWpldDC6C18WsvCHKn2Wj8Fx4qspzIPi+2swT5WDas7CA yMbh01vPJ/j7ayC1PyCQIrcpbMD0gPdbPPQOM1MeO7h3erbcYey7P+xJ0tZQrY5PdVf4 gYy2cd8xFeUDItyZAiez25eKX/xe2UHYavDBWa/sIh1824EblCp3faJQJVujH1L12Nhy VcNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723649829; x=1724254629; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cqf02PglwzMnUewsw7C/MM2gxFs0r5loGQKEe2O/En8=; b=Xs7uoP5U3xsa733lJWHhApFBvryLYBAEin27faoun5ySFqn+PGOVlnrScilY1HhgPu 6rOb2Hbrn55mPazWZxEFABdYWbfquwHc+BO/5KrdrU4qGvebD35kU5mtVIXjvAvZTIvw 0ZepJXyjjwR3aogq01VPbDshq0YEFGJfJ7xqbaR0E5ikQJJnOt+VB3jEKrZb9kVoIIOy uTYiXw/PDbFvIYLRdsYdLkiSO/u3zHqE4poNxFMylgY7TbTyNE3nmLQTZnt2+qzs4/tJ B4MeEHH9KXTiEcndDuPc3ondlF2LS0VqCVG5Odx4bswYuR+/Z6tERBIMZ9yr7/FODaTe tn7g== X-Forwarded-Encrypted: i=1; AJvYcCX4HCTNG9s0LqBb7j0X5DO8bk2wYbPsZo7kYIwibk4NiqCvrC8dGdBF02IjukKDAGGCROLMcYiopUoeg4XliSZ/kQo= X-Gm-Message-State: AOJu0Yyzwk1XWfuaVzv8P9HYKK4tFSnbAOGWO3hQe5ZuVDdNnXjzd3rD vspcdGy+rk0+c7f5Nkk1e/6dyovRC7c+rDu9MUJkiBXNRrVHrxHqyK2IXNjqW09MXiHdo7PI+IE OQOh1B0ldJ0hf7CRF2i8gj7ddRbo= X-Google-Smtp-Source: AGHT+IFDBONZW0uAyZZcOL0emyNtvuyvo9UQfc/vnpEfY8xrJ1IHvo6JR+e3rtaebfSBwGdTBBl8COcr1zrbck6P8to= X-Received: by 2002:a17:90a:ba8f:b0:2cf:fcce:5a0d with SMTP id 98e67ed59e1d1-2d3aab87063mr3577203a91.35.1723649829061; Wed, 14 Aug 2024 08:37:09 -0700 (PDT) MIME-Version: 1.0 References: <20240813224027.84503-1-andrey.konovalov@linux.dev> In-Reply-To: <20240813224027.84503-1-andrey.konovalov@linux.dev> From: Miguel Ojeda Date: Wed, 14 Aug 2024 17:36:56 +0200 Message-ID: Subject: Re: [PATCH] kasan: simplify and clarify Makefile To: andrey.konovalov@linux.dev Cc: Marco Elver , Matthew Maurer , Andrey Konovalov , Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, Andrew Morton , linux-mm@kvack.org, Miguel Ojeda , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: BF2B51A0007 X-Stat-Signature: qnpo91uyrqh7nnjbdfbteff483req8mc X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1723649830-6048 X-HE-Meta: U2FsdGVkX18iqTXSOCnpTqShXXDImiw7YxotoIc2GlYGq2EG9QWhLXKdtJKwp44LHny9CnmgcBgjkNJzthhY6VgcSxg5EyIAEXvyGpKgs1S1yy9/a1qWZ3cbKiDleP4rIMQE3hxN/9QzL0e8ym+zPp1IJcYqLrGJBR/zlI/lD0K59pgnhBLiICljP0llmBdGWYjzEuJ3uQz2XswA6fBx/uq8P+o16724oM5lW+7HD+HdBwG35BNTXloVrdipC0TxheYsZ2+o0bWj21vOZgXcv3SidPw1PfHSF6Lp0VQL+As10oSefiV6Q/H1VwK5fW97apWjsC5/cZoRU/4cv8KjzJnV+QoOC1RvR2bBy86DxjTuCinmGdv3rSzoXo0T+DxcbbtIfZqcmDgqA/EsEHvMxJD5M8qobeFt/w0rJdFQFIYRXCNIT3u+PHOtPRzU/YoMYRA1jIxGkNztLdc4ZYvf5SCtx0ORSi9SXTNN1sDUXEbf1IWpPXMlmLjf9PoUK8lE/PudPGmsjccql/ugIZvYZy/+mYN+pt9/UHHyxrAqB/cOby6t4ywrZSqkIWNtPiuufTSeeCZohVxLXReInCyLpDqXhpfNPq8161BpXNOOhJsCkqfu27LtSLQji910gMjrhy9StMQNU5fif8a+q7V0s6Ya4yPVmRrGCPwP8uznim7NRDuQdmBY8tIKFE7EGhV+7RAYRN5ZnZOMFzsX+sCgnbbRIhr9waMSu1gBKMHQ4R66INTrGjMnr/kWWU8aVqzjuBpSOKarsw0UXGlXn+wAeUJcLOKwdPwUGWQ1Gmxzg5ppjwy0WSfdDZfZq1HYXNh4HRlDurExPVsiV3jQL5j+JLArNFfkK11iz+ebrTMAt9XBFGn4IBvxdSGo5ITm8ftRjCjxtFjoTlvUtwl/3hd6OwywULWboFhLupCSnyNIorHLRzS0mZrLjg1aoNqrvWuwRppQbUeYmJM3oSiriVc YLRvIe20 p0Mj1j6ResoxhqoC3ycM3CXh6xxnVTZjYz5bHPiIO92tzx2MUs+0azWT51skl8ybivj4Et31XYS/GOaGUqplOWGwc8xevsPoCXmijBFybQwVBywYbQJprlFSDPRTornfWic1TRiKnWUqbo7U+iFYEfKbijxDZsYKkg/9idG0kC+nyAEuNZren0s/EYx387k0/rPwbd8IgT8Kj/0AbVUx/j2beUAuF64m7rreo5yVLuc/gn3S1Etv0R4HcVzgDosyiRBUQwVoBNXo0oRyQ7IV68bWXSjcbfWn9bC8sFsxGMrYqbq+qhE0jUylj8NRQAu7z2yVVzCiR65fEDxdNX4zu0pI5ORpuYRUg7kOFPNwa8DRQZcrRT85RltK1ncVpjjiVRbSYERfETqlxWK9iXMQhujYszUG/GcGRHiWHEykRLoQCFPbhnVn/5f64vIqEaBUCU8kS X-Bogosity: Ham, tests=bogofilter, spamicity=0.067382, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Aug 14, 2024 at 12:40=E2=80=AFAM wrote= : > > Signed-off-by: Andrey Konovalov It is easier to read now, and indeed GCC 5.1+ and LLVM 13+ both support the flags, so `CFLAGS_KASAN_SHADOW` can't be empty. > +# First, enable -fsanitize=3Dkernel-address together with providing the = shadow > +# mapping offset, as for GCC, -fasan-shadow-offset fails without -fsanit= ize > +# (GCC accepts the shadow mapping offset via -fasan-shadow-offset instea= d of > +# a normal --param). Instead of ifdef-checking the compiler, rely on cc-= option. I guess "a normal --param" means here that it is the usual way to tweak the rest of the KASAN parameters, right? > +# Now, add other parameters enabled in a similar way with GCC and Clang. I think the "with" sounds strange, but I am not a native speaker. Perhaps "in a similar way with" -> "similarly in both"? Thanks! Cheers, Miguel