From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: andrey.konovalov@linux.dev
Cc: Marco Elver <elver@google.com>,
Matthew Maurer <mmaurer@google.com>,
Andrey Konovalov <andreyknvl@gmail.com>,
Alexander Potapenko <glider@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
Andrey Ryabinin <ryabinin.a.a@gmail.com>,
kasan-dev@googlegroups.com,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, Miguel Ojeda <ojeda@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kasan: simplify and clarify Makefile
Date: Wed, 14 Aug 2024 17:36:56 +0200 [thread overview]
Message-ID: <CANiq72mCscukQTu7tnK0kXHg05AiMtB8sHRDTvgjWgcMySbhvQ@mail.gmail.com> (raw)
In-Reply-To: <20240813224027.84503-1-andrey.konovalov@linux.dev>
On Wed, Aug 14, 2024 at 12:40 AM <andrey.konovalov@linux.dev> wrote:
>
> Signed-off-by: Andrey Konovalov <andreyknvl@gmail.com>
It is easier to read now, and indeed GCC 5.1+ and LLVM 13+ both
support the flags, so `CFLAGS_KASAN_SHADOW` can't be empty.
> +# First, enable -fsanitize=kernel-address together with providing the shadow
> +# mapping offset, as for GCC, -fasan-shadow-offset fails without -fsanitize
> +# (GCC accepts the shadow mapping offset via -fasan-shadow-offset instead of
> +# a normal --param). Instead of ifdef-checking the compiler, rely on cc-option.
I guess "a normal --param" means here that it is the usual way to
tweak the rest of the KASAN parameters, right?
> +# Now, add other parameters enabled in a similar way with GCC and Clang.
I think the "with" sounds strange, but I am not a native speaker.
Perhaps "in a similar way with" -> "similarly in both"?
Thanks!
Cheers,
Miguel
next prev parent reply other threads:[~2024-08-14 15:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-13 22:40 andrey.konovalov
2024-08-14 15:36 ` Miguel Ojeda [this message]
2024-08-14 16:10 ` Andrey Konovalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANiq72mCscukQTu7tnK0kXHg05AiMtB8sHRDTvgjWgcMySbhvQ@mail.gmail.com \
--to=miguel.ojeda.sandonis@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andrey.konovalov@linux.dev \
--cc=andreyknvl@gmail.com \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mmaurer@google.com \
--cc=ojeda@kernel.org \
--cc=ryabinin.a.a@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox