From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85B99C52D7B for ; Wed, 14 Aug 2024 16:18:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1A7936B008A; Wed, 14 Aug 2024 12:18:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1581A6B0092; Wed, 14 Aug 2024 12:18:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 046076B0098; Wed, 14 Aug 2024 12:18:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id DB78C6B008A for ; Wed, 14 Aug 2024 12:18:52 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 90E73A7A62 for ; Wed, 14 Aug 2024 16:18:52 +0000 (UTC) X-FDA: 82451359704.07.3B55AEE Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) by imf14.hostedemail.com (Postfix) with ESMTP id 99EE210000F for ; Wed, 14 Aug 2024 16:18:50 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=TIq42FrX; spf=pass (imf14.hostedemail.com: domain of miguel.ojeda.sandonis@gmail.com designates 209.85.208.176 as permitted sender) smtp.mailfrom=miguel.ojeda.sandonis@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723652235; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PB5dkBysx9T6fJTBpImmumJYpuaHzNjh7FBAg1c/aXU=; b=F+jMdVYedPcfUVUY2yTmLOGLIQOBoJ8WHHQaNv4pDe72bw4v3n4ugvjLyzP1eWS/xvhTtm qySstMWFBp3YA3wcBrWyu08YHHVHKhDDpIxmPXmRW6HDix3xKGjHrgcmQd4bnmcs3oBuc+ Pf4oG5XpW62S/rZi5ov5ezcxL3dHhYc= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=TIq42FrX; spf=pass (imf14.hostedemail.com: domain of miguel.ojeda.sandonis@gmail.com designates 209.85.208.176 as permitted sender) smtp.mailfrom=miguel.ojeda.sandonis@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723652235; a=rsa-sha256; cv=none; b=WkSu7vvZqLanlqQaqGmPUT2NX62s8TE6B1OfnjyQJ04zpgP+VAsEr7LasLMzh8RgP2xSUj lX++LMGLz6enT7SmPT2SeWYe7yE+UlcHCaV/1lDxsEOWARTfGQ+hinsRqJP0fN4Zjs6o7x 2/7ugJdEMemwwKqfiIDrP5Y5R94Vq/w= Received: by mail-lj1-f176.google.com with SMTP id 38308e7fff4ca-2ef2fccca2cso798431fa.1 for ; Wed, 14 Aug 2024 09:18:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723652329; x=1724257129; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=PB5dkBysx9T6fJTBpImmumJYpuaHzNjh7FBAg1c/aXU=; b=TIq42FrXfr7mNZjvQMaSxCYQdSNkqtvfeiZYfVcv5almmwmfEfKWfivuHTjxlhL+ph TJfMlt0Vn1hhDeLyy4n6Ifr027HoVAOrQVgeCV5/0UoiXPjimF2SMPmQRhBnC+lpSFPZ n+uuN4nIOw+2E77ksHPomOmIho6A2hBSzAsBTOW+1EtMI3RC/pfOY/qjKRaqeWHw7/aU jbR9xKFxBRGLJ/tEo/1ZsuP0OfVNHddzyb7cV6Q2AcMNPH8L4EtPubYcU5xSfhue8Mp8 Be8wUznJvqBs9oLdo/M5x4RXLawjjXkK7T5iX1x/SxTk2lpDK0j5F4BOEP/PF4txbUnk mZiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723652329; x=1724257129; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PB5dkBysx9T6fJTBpImmumJYpuaHzNjh7FBAg1c/aXU=; b=tzjBNUQ/UAKIrin1t3lbgMtZC/aJUT4YqogJqXVG3s6zJKEp4jIwO4U+XtYJX7Yp9p m29kgJCor7VzbHBL3yKoYrCRUkSq+U+XBrkK5p2Ov1fiCzo+bhi3DT122/L/LRcLE8Q2 7kxor5a1qlBzKdiUmfP4743i4VSVkqBgNLluAEXJuhEFnrtno2GFoei8R7qSED8BApTI OfH5+gnIjGwXX2HYsbGOgBr5oBowT9/cnbp+n2B97Aaug2BfrXqepsSMdrXKBxIKFtgF jzbM2CA9W0i/a87adIy5kL5PM7ZnY9S6GY/ogsXAvvzhRo/IGfLD5m1OPAQADHYNwpDq Ydng== X-Forwarded-Encrypted: i=1; AJvYcCVMKpvCtvqoC/hBMqEkC0x4+onrUZJSXAoGogMrLjO6GmehA4GyDvmM/JuHLmdNS1XT6tV8iTLHcvvzxqs66cxmLD4= X-Gm-Message-State: AOJu0YzwCHeRALEQIwd5PoGHZVlUIsexziWkqvaWTXzI2JbdbQXRv/B0 6RJ3mkXjH31C3pPT1PdWrwlMaQB4LPvieGGakSdqCIM43ObR6xHkHRkcmt2BJ9u6swbpqimMq8W mMPPMLUx+zYI5RDzSHLxMN43Qq8w= X-Google-Smtp-Source: AGHT+IFdJJ9Ga94FBFog8/Rs/M01x5LqjaXMvJcUJF2wIIPlOEq5QOPwKCyibrm2Nbrd4U6tH1VD27icCgoXLwh3u20= X-Received: by 2002:a2e:743:0:b0:2ef:1b64:5319 with SMTP id 38308e7fff4ca-2f3aa1bcbf6mr19089351fa.11.1723652328498; Wed, 14 Aug 2024 09:18:48 -0700 (PDT) MIME-Version: 1.0 References: <20240814161052.10374-1-andrey.konovalov@linux.dev> In-Reply-To: <20240814161052.10374-1-andrey.konovalov@linux.dev> From: Miguel Ojeda Date: Wed, 14 Aug 2024 18:18:33 +0200 Message-ID: Subject: Re: [PATCH v2] kasan: simplify and clarify Makefile To: andrey.konovalov@linux.dev Cc: Marco Elver , Matthew Maurer , Miguel Ojeda , Andrey Konovalov , Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 99EE210000F X-Stat-Signature: rofa94qho3gpmco5mcrkfpmuwdfphizc X-Rspam-User: X-HE-Tag: 1723652330-454480 X-HE-Meta: U2FsdGVkX1+JYAttqUASRXyiFMlW4EAqy55zSajrL6AG24lPorAnYS/mDKCwur6lkQtyLO2YdmeUxok43xqqScJdeIPOSUjJmt7TW8Ollu5Nt5OHDUzC1nQCSdgZEp0Zg9a8TyfhUh4MvnGkqC23G+SLEKgL4LuQPlo33bO1/iK7yMw+oArx7mdbEqBLXoh4t1GP8KQu8dyTYq6mirxUjQDtxvrDuPrMTho1I8PYz62vVinb33Tyi2LBl2wjMuPH0a8b9fMUdkYvKc3iUlGQtpCOAaptcHfLgTAEj4fhoTyUh/ppFlXQXqETd/+/zfb/dlfTMUgj3JWGc8sK08j2Dr28e4LgpXeMZN47VIyicMFzdF19rP2zzoWRtdaTAh9efcspW4bzfZhAC0xt6o4yFWPM9vVW3Onno+E77hnsOb04QGgrt+2Sm0JwR2+2BYSAevwUJQ2JJgvk/+HDe6LbLfhNJg2qJAiOrhGzDpvw6iFkNUuAQT6VyEQIrfnlPFaFoVs+m55ZI4d6D/nhDSZW1PMIcrw9D6bbDG7AP1PNtD9ABGwC7NDFlCnvJS3EP+ONXUscaPbxsOi4ZPW/cfh/o0gwoy7a32RLzHijXvOjyZlJp27Dr2LMiyWwTai0h0RyjvgyxdnEa3aLuVez8mb5/5RK/I8YvVcJImD77Twecyfk3mZ+dAQZwoEXqC6Q9SlFkm44bEd+vMeAxLhqSrq72pCHhr+pb/7U5MB2WJmAtwEJzECDNNhv+KdF12pIbRCM8HDwMy3yPK59qxxmls0z3UhvVEMVXG4aUTOoWfPFF86xswsOVw2dNhbLpM2uEGwHXw1Y4IUseH5b/DMjEWWe2oj7iLmLIh6Vkcj2UYeFwZ4n/gy4kC62oWpY0FrWqeXQ7n/zKjka11hScIQrrVa1RbTATHa4z8pWQx+BNAvnaXvaR7yF5b4MvHe/KVEdcPdJB6GhoZkxUqRzsCHYsbW +DaFsPw9 N5C0WNGp0KYEed+aw8cKMPOGxBAHvkK+75fgTs8GALL0nhJ/aSjwF1Tfs42v92D3l/RkZTHCfiB0rfhyODa9hK8f4J6ndkVapA84aW6nOfoBlX3D1IL4sPTgFeCfi0CmSEwqAJADukgbf94LOZVkVKfNZhfJy7Ybqfrzt0/LnQlCMP3oRExy2N7M27vXNLKqbhQrsbuWkJ68pN8HMIXFL6BJxuH2p6l2PeNvVWeRaHkS/FK/Wx8yLIZN5Yc0Ba8BWlzSlS7ZONbSdvydw/XEMvE7nzcNjo+RMyVUuywNxA7ARUjYuAf6o+GVYmOg7YUwYdFH5/y+sqZ4Wi9IUrqzAzENN1UXq5p4X7UXinRHQtK5jQzBoTDIbhds6dk/jCxBagSp+IBujhed3n5U44IThsA8aftcbOR1rgCf1vRenH7s21p1jUGx8xMUEtQfJx/8tU7SbO17X1GCJHeyzJb6SE2NgA3L/chf8uAYN X-Bogosity: Ham, tests=bogofilter, spamicity=0.103940, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Aug 14, 2024 at 6:11=E2=80=AFPM wrote: > > From: Andrey Konovalov > > When KASAN support was being added to the Linux kernel, GCC did not yet > support all of the KASAN-related compiler options. Thus, the KASAN > Makefile had to probe the compiler for supported options. > > Nowadays, the Linux kernel GCC version requirement is 5.1+, and thus we > don't need the probing of the -fasan-shadow-offset parameter: it exists i= n > all 5.1+ GCCs. > > Simplify the KASAN Makefile to drop CFLAGS_KASAN_MINIMAL. > > Also add a few more comments and unify the indentation. > > Signed-off-by: Andrey Konovalov Looks good to me! (I didn't actually test it, though!) Reviewed-by: Miguel Ojeda Cheers, Miguel