From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: andrey.konovalov@linux.dev
Cc: Marco Elver <elver@google.com>,
Matthew Maurer <mmaurer@google.com>,
Miguel Ojeda <ojeda@kernel.org>,
Andrey Konovalov <andreyknvl@gmail.com>,
Alexander Potapenko <glider@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
Andrey Ryabinin <ryabinin.a.a@gmail.com>,
kasan-dev@googlegroups.com,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] kasan: simplify and clarify Makefile
Date: Wed, 14 Aug 2024 18:18:33 +0200 [thread overview]
Message-ID: <CANiq72mAce+-NCgBTE8FsaKC=87x+tGJ6xWU=BTiOLPGYObOFw@mail.gmail.com> (raw)
In-Reply-To: <20240814161052.10374-1-andrey.konovalov@linux.dev>
On Wed, Aug 14, 2024 at 6:11 PM <andrey.konovalov@linux.dev> wrote:
>
> From: Andrey Konovalov <andreyknvl@gmail.com>
>
> When KASAN support was being added to the Linux kernel, GCC did not yet
> support all of the KASAN-related compiler options. Thus, the KASAN
> Makefile had to probe the compiler for supported options.
>
> Nowadays, the Linux kernel GCC version requirement is 5.1+, and thus we
> don't need the probing of the -fasan-shadow-offset parameter: it exists in
> all 5.1+ GCCs.
>
> Simplify the KASAN Makefile to drop CFLAGS_KASAN_MINIMAL.
>
> Also add a few more comments and unify the indentation.
>
> Signed-off-by: Andrey Konovalov <andreyknvl@gmail.com>
Looks good to me! (I didn't actually test it, though!)
Reviewed-by: Miguel Ojeda <ojeda@kernel.org>
Cheers,
Miguel
next prev parent reply other threads:[~2024-08-14 16:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-14 16:10 andrey.konovalov
2024-08-14 16:18 ` Miguel Ojeda [this message]
2024-08-22 13:49 ` Marco Elver
2024-08-22 21:46 ` Andrey Konovalov
2024-09-16 16:14 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANiq72mAce+-NCgBTE8FsaKC=87x+tGJ6xWU=BTiOLPGYObOFw@mail.gmail.com' \
--to=miguel.ojeda.sandonis@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andrey.konovalov@linux.dev \
--cc=andreyknvl@gmail.com \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mmaurer@google.com \
--cc=ojeda@kernel.org \
--cc=ryabinin.a.a@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox