From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3E94C433DB for ; Sat, 20 Feb 2021 09:44:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 822CD64E2F for ; Sat, 20 Feb 2021 09:44:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 822CD64E2F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D40A26B006E; Sat, 20 Feb 2021 04:44:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CEF966B0070; Sat, 20 Feb 2021 04:44:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BDEEB6B0071; Sat, 20 Feb 2021 04:44:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0131.hostedemail.com [216.40.44.131]) by kanga.kvack.org (Postfix) with ESMTP id A3C316B006E for ; Sat, 20 Feb 2021 04:44:04 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 5D2798248047 for ; Sat, 20 Feb 2021 09:44:04 +0000 (UTC) X-FDA: 77838160008.16.B6055ED Received: from mail-yb1-f176.google.com (mail-yb1-f176.google.com [209.85.219.176]) by imf06.hostedemail.com (Postfix) with ESMTP id D1E5EC0001EE for ; Sat, 20 Feb 2021 09:44:04 +0000 (UTC) Received: by mail-yb1-f176.google.com with SMTP id x19so8045595ybe.0 for ; Sat, 20 Feb 2021 01:44:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wCFYHvazUgNRbpVltxCwLpepYDDeFNsVpUeCIrSJCvM=; b=JLMWTVwttG4/wt8dP/Hn1zFDg99TQ1FxNKlRwGfp3isAlX17xKBaSatISTMiUATPhS SIxo2lq8PYU0Qpx2z6ExaTM9BEg2j5LMGDFPzxtKNqHZY2CN1o5aFiikxwgbgYY63h3g 8KhhHDtH1ckrsckWIjQLnLCoORmdWKRE8rH+8Ailr99dpHgeCvMrISLgmnrHn7htPo/t f72OUfwMgqAe10mfxRlWK0LX8FJU6Y6uI0bcXrfJybhmXjZkeoKQXegqNVPQew8MUPWM fQxD1G4cTwzlIrkQQvQadxHlMsMwyXv57vg/EL7RX8efB3meMuNl012I4XlNF7+8QcKd IZOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wCFYHvazUgNRbpVltxCwLpepYDDeFNsVpUeCIrSJCvM=; b=iCiXNS0EG/WcP8mwXgp9VWzGbWHWceUmbF/DvNBc9FbrJ1rjQXsA0LQS1BH+QvtEx6 mYbwckpDvG5FLA5EFn3cJmiCPAReTDs35P0blMvB8Dnmz0qDLQ6XwiVT3L1GZfP75gAK /6/+DdCooqqj1A2ue55euH9WQMvZ+I5JN97Gp9n/71L3Z0w4WtFPrjua7zAs45IWGU6s kbLi96hZbfB6vCGmmqcPQyMZJWKde3QX1881D8r9Wzh+gTO5WRBtnKqQ62MKqbuNOonL GUp+rotmoNPKKtnuwXpisPZsLEALGVZomVgvWwO4r7Z9hLLJVt/A63FEIBVFlND5wk1z fsuw== X-Gm-Message-State: AOAM531z1Yzz7wdNSxHfb1Ja24agMFqrgXBVNeIi5KZyxlcGe5WLUQGm RXvm54AvL+XHHIMf+EGGBoXVeKP13iLSE+sDx6I= X-Google-Smtp-Source: ABdhPJwYfD3OHEt0vkwp4di4NFV2i5NCwPFa420ctU7h4tBfggHHAL5jqsivYhO0S4Aco9GN/B5VbijRBBQ/KIJRsbw= X-Received: by 2002:a25:b91:: with SMTP id 139mr20140258ybl.115.1613814243268; Sat, 20 Feb 2021 01:44:03 -0800 (PST) MIME-Version: 1.0 References: <20210215204909.3824509-1-willy@infradead.org> <20210219195509.GA59987@24bbad8f3778> <20210219205403.GX2858050@casper.infradead.org> In-Reply-To: From: Miguel Ojeda Date: Sat, 20 Feb 2021 10:43:52 +0100 Message-ID: Subject: Re: [PATCH] mm/gfp: Add kernel-doc for gfp_t To: Nick Desaulniers Cc: Matthew Wilcox , Nathan Chancellor , Andrew Morton , Linux Memory Management List , Mike Rapoport , clang-built-linux Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: D1E5EC0001EE X-Stat-Signature: ocwqio45zd1b68jpfhhdmgkfibjwyhfr Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf06; identity=mailfrom; envelope-from=""; helo=mail-yb1-f176.google.com; client-ip=209.85.219.176 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1613814244-901446 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 19, 2021 at 11:50 PM Nick Desaulniers wrote: > > (There is a separate warning flag for broken header guards, > -Wheader-guard: > https://github.com/ClangBuiltLinux/linux/issues?q=is%3Aissue+label%3A-Wheader-guard+is%3Aclosed) Yeah, this would still help cases with headers without guards (not really common, but...). > What happens should the kernel move to gnu11, as discussed once GCC > 5.1+ becomes the minimum supported version for all arches? > https://lore.kernel.org/lkml/CAHk-=whnKkj5CSbj-uG_MVVUsPZ6ppd_MFhZf_kpXDkh2MAVRA@mail.gmail.com/ > > Then the warning will not fire, since it's only really meant to help C > code be portable between -std=c11. I think it is a fine warning to keep in the compiler nevertheless since you already have it, even if disabled by default or only in -Wextra or something like that -- e.g. I would use it in my own projects since I never intend to redefine a typedef. > https://lore.kernel.org/linux-mm/20210215204909.3824509-1-willy@infradead.org/ Thanks for the link! Cheers, Miguel