From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00BDCC3DA4A for ; Tue, 20 Aug 2024 20:50:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5D2336B0082; Tue, 20 Aug 2024 16:50:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 581DA6B0083; Tue, 20 Aug 2024 16:50:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 449F46B0085; Tue, 20 Aug 2024 16:50:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2293E6B0082 for ; Tue, 20 Aug 2024 16:50:10 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 77BE7C059F for ; Tue, 20 Aug 2024 20:50:09 +0000 (UTC) X-FDA: 82473816138.06.31E5024 Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by imf07.hostedemail.com (Postfix) with ESMTP id 966F14000D for ; Tue, 20 Aug 2024 20:50:07 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ckUeiWeB; spf=pass (imf07.hostedemail.com: domain of miguel.ojeda.sandonis@gmail.com designates 209.85.167.53 as permitted sender) smtp.mailfrom=miguel.ojeda.sandonis@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724186945; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VzJFd4bvLYVyrRq91pLVKMp6cHYmymXxbjKHf0cCDsY=; b=k5pN3sogxA83leo1rwRyFXMLcUDJ2HwvWOmlSBpgYUdHonX5mmG2kfTvkEor2GzzoDSmMF CkGHMgEXuxDwzzWcHGGWf5zKw8RxftbBuC2CEDHxRbIz9rqltZWT4baeNPheyMibe8Kw2T Rl6iHMUOu87wMWj9NwNvytX/4Bwk+4k= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ckUeiWeB; spf=pass (imf07.hostedemail.com: domain of miguel.ojeda.sandonis@gmail.com designates 209.85.167.53 as permitted sender) smtp.mailfrom=miguel.ojeda.sandonis@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724186945; a=rsa-sha256; cv=none; b=0BZA4SRl3Tw3vRyR1tNghyMzmDkapq+H3e0G+bQvs/ku5jNuVzXnEgquYVQd/IEUI/KuwQ SjaAZFibggqwdIJ6ny1gitSpDZkbYjvW7hWl/L83Bb/VAOFf+kLPSgcMZovaDQfMcNne+U pLP53ob/LELRoBfyv6KbdhVC51HbKlI= Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-53345676179so17282e87.0 for ; Tue, 20 Aug 2024 13:50:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724187006; x=1724791806; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=VzJFd4bvLYVyrRq91pLVKMp6cHYmymXxbjKHf0cCDsY=; b=ckUeiWeB1z423o1MESxAo9wUdqUEe0ZwVw/OLcO3dTk36Ygt/MVl4nqjtp+vwkzQU3 RLWUo5fR4T88sHeQNOTjq2ScoxKeHtUAFTTtA6Lfyza0b7SR34gM5yexziled2vNRwJG dAOGOUR8YMe0bf4fp1rGqbNGBhWp7mGUcoOmom1HulRntgNRwnrXEHBloDTk/7Qo50Eg Lb4jflZXQeUmw6QE1za/mJqUWpnv4gy8CutmK9QT3+ktZrPXJ9mua0o/RJbj2DvzjfbE 4V6/1M8l5DAesUr8rLIN0pgDli4F+aJi8OYN79DYqF6GZqebC15SJuXEPOaqogA9WBS3 hLbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724187006; x=1724791806; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VzJFd4bvLYVyrRq91pLVKMp6cHYmymXxbjKHf0cCDsY=; b=PLB1bqh991yHC6jIIOcWNzI85n7UHjGR1QNEHTk/rVlLBoJ/1y8YdR4y5FLNmWoODp jCsDkh08Ad90Y674zF8QBsEh5LgsRz4oDR9VDiXfP+q7a8nlKjDwzJo/jo5Th3vmaqkU 3oZZ7RdQGFtJc5Gh0L42X9WWJYlJZ5fw8FTiWBm0/4amlXun1TH1tdScEhu8KYR2wJvX 9qWCA+FzXbux8YbNNsOxq8LYuohX8IgNk74647rmW50E3Cx45VMdizeiGLN2Vyk9Oh2M 6iNkrsUrHqOTANYJLxu4JOQcUleQOoRfO4TDNmTkmd+3fYLxY2ZWXyB97Hy4qpQNtLYQ XqxA== X-Forwarded-Encrypted: i=1; AJvYcCWn+49WZa24cpTKA3hlg8cOKYj4ivwEYj5Aw87qetQvZxllx+ey7PI+NyOsylQcP+AAvbKN+VJnUA==@kvack.org X-Gm-Message-State: AOJu0Yy4WOSg+sv1tASszVL6eZMtsMPKwwGVCHeNdxor3TCK22Wka5bY M5ZV6W8W3QMOFRzw6FsZHRTtmEWOo8yASUdcF7RenmrfNo4ig1CHWwn1rAIpwKiwauSRTXsqW1u HE+G/PWZf1iCzFRdHznJ3H9vUfd0= X-Google-Smtp-Source: AGHT+IF4A2X5DHiMp2y/ISoHY4+FoDb2VARi23ScSmyW+z0nIW9IUdjYL2vjnS5voFYAV9Yn/hORkomSr0zeq2FvaaE= X-Received: by 2002:a05:6512:b99:b0:52f:c337:4c1f with SMTP id 2adb3069b0e04-533484ee187mr12476e87.0.1724187005190; Tue, 20 Aug 2024 13:50:05 -0700 (PDT) MIME-Version: 1.0 References: <20240819213534.4080408-1-mmaurer@google.com> <20240819213534.4080408-2-mmaurer@google.com> In-Reply-To: From: Miguel Ojeda Date: Tue, 20 Aug 2024 22:49:51 +0200 Message-ID: Subject: Re: [PATCH v3 1/4] kbuild: rust: Define probing macros for rustc To: Matthew Maurer Cc: dvyukov@google.com, ojeda@kernel.org, andreyknvl@gmail.com, Masahiro Yamada , Alex Gaynor , Wedson Almeida Filho , Nathan Chancellor , aliceryhl@google.com, samitolvanen@google.com, kasan-dev@googlegroups.com, linux-mm@kvack.org, glider@google.com, ryabinin.a.a@gmail.com, Nicolas Schier , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, llvm@lists.linux.dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: f9tebtb1jipurcbtgr1ytdm4i6zr3rg9 X-Rspam-User: X-Rspamd-Queue-Id: 966F14000D X-Rspamd-Server: rspam02 X-HE-Tag: 1724187007-262792 X-HE-Meta: U2FsdGVkX1+zzg/4tIRmt//lD7cB7un12AwoqGya7NRQvkxjUvsM1Y9ubCyaROtxBczPyKg1OncIG+Z77Zap/alHhUeegrvQbUtYptMbLX49rPfFgCj3qOMfxKYXfzadDX9qj8uLS1CwhgSGM4V+1jbtsq7A+OWmZQq+ePOzlHLOuOeVxL1fOvqNL2xDLUfkKEwM+as1yCjOxBAly5Gs6Ts/KVO4otNUhRQ7/306xFBBF7U4SEhybglWcizj6KNq/RNh5FOl9t3IzwRvxCXYkY/mvl9IDdFoccUWBkYJFE6IGW9LayCpey46SztLWPrCSZKz3NQM9r9c+wttAHy+Moj2aPunexqVN1ISuuSTtU7752PqeN4qlSx7/W6asCv26fwfnQNvvqDp8T6xle5Xl2EMIiIFSis2afS/Kz4+cFeBV7ER84E1AXaBCREjZHYEetBO+MTIhefd3X9SddsF/M0YcdhTN8UqccEmHLPOB+jAwg8YbEEwX0NOE2xd4afpkUitsEs+9mchQP0IDZi6sJVH3Lq0Tx0kayI0GHT/OGqK7E7o9fv3XFzEKNwZGfzwpXxaPFNtbgWTQ3TU/8Sdl2UO2K3W+TPIZ1jH0japu6m304ie0g6z4pcgdR7UmcrzgWCOyfvI/MM9+F0Rv/X2tmqQ6YhyD6q7W7gpW0kznqOsd2WoinC/z1sGJCqQfCCZuNvXMGqBwR7ARE/0iXXEqQb80zO6OErro9SZ2LKRFru75mLLU2F9ZpsAFcvb2uf5LczwqUNFLf8IWK15KOujU2iSvP0U0PpTfunN8PO19+gAzCH2TQe8ASfPvDI49kjoXXrpT0WMCP5NrPRYAK5UP7GuVi3VRjjXrtu3kBPHeouaj66KLKIaPl/pXwgUmqEpRxOO6TiaikreTPOyvvZ3w+0u97FT3YgMcTlgqU4+9DRnv0YS/GjFqVK8G1baw+PdXxZNMoIw6mVVz+705Rs m0Au06k/ zI2DS13QAMEWpRZCVMXBwaI3uKWWJGDZ3neN9l9Kk6a4kAOGxatAaO+lXZcJV56cm6IZNz7vghipPTp+oISHbR8YNO5rxJ+ujkBAZEuEtJGsNfgLfc4fMZoW1YNLnNJxATNqNLBEZ1I2hTm4BVoECKUTEvB3xMWkQwZJhExocuMcBfpK1t5XO0ESqLsmfWcvrwEpG3rCVlOhvScVAacX50fdIwMykR8yIWcDI0ZgFx/Nd0aCtOrb688yK76UZqY4xC9YfLXcktLjo4uoQrLF+IG7b31wPPcJRYcpIHGdXMekUDbgjQWE3OKinRgBZc6rxgMa2quwKmzTAjc6VkW1njmrO/KEJISWNMEBlbXyAgq/P5S2YE6AwIRVqOTYB7W8sX8rTt2IDuQc9qQYdDax9Aerw1VQOGGyPy2561clGehswjB45d/bZYGafNnAMjWdiZi2T X-Bogosity: Ham, tests=bogofilter, spamicity=0.306494, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Aug 20, 2024 at 7:22=E2=80=AFPM Matthew Maurer = wrote: > > Sorry, I did miss that in the refresh. To respond to a few points > before I send up a replacement for this patch: No problem at all -- thanks! > I expect this to be potentially used for whether you're *allowed* to > set `RUST=3Dy` - for example, if a particular sanitizer is enabled, you > may need to probe whether Rust+LLVM supports that sanitizer before > allowing RUST to be set to y. Yeah, makes sense if we do the dependency that way. > I don't think so - I can't think of a case where we'd want to error on > a warning from an empty crate (though that may be a failure of > imagination.) Do you have an example of a warning we might trip that > we'd want to make the build reject an option's availability? IIRC back then I was thinking about something like the "unknown target feature forwarded to backend" one, i.e. to identify whether a target feature was supported or not. However, that is not a warning even under `-Dwarning`s (https://github.com/rust-lang/rust/issues/91262) unless something recently changed. We can add it if/when we need it. Cheers, Miguel