From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by kanga.kvack.org (Postfix) with ESMTP id 632E56B000A for ; Fri, 5 Oct 2018 14:09:16 -0400 (EDT) Received: by mail-qk1-f197.google.com with SMTP id v198-v6so13090252qka.16 for ; Fri, 05 Oct 2018 11:09:16 -0700 (PDT) Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id b48-v6sor665238qvb.3.2018.10.05.11.09.15 for (Google Transport Security); Fri, 05 Oct 2018 11:09:15 -0700 (PDT) MIME-Version: 1.0 References: <20181003185854.GA1174@jordon-HP-15-Notebook-PC> <20181003200003.GA9965@bombadil.infradead.org> <20181003221444.GZ30658@n2100.armlinux.org.uk> <20181004123400.GC30658@n2100.armlinux.org.uk> <20181004181736.GB20842@bombadil.infradead.org> In-Reply-To: From: Miguel Ojeda Date: Fri, 5 Oct 2018 20:09:03 +0200 Message-ID: Subject: Re: [PATCH v2] mm: Introduce new function vm_insert_kmem_page Content-Type: text/plain; charset="UTF-8" Sender: owner-linux-mm@kvack.org List-ID: To: Souptick Joarder Cc: Matthew Wilcox , linux@armlinux.org.uk, Robin van der Gracht , stefanr@s5r6.in-berlin.de, hjc@rock-chips.com, =?UTF-8?Q?Heiko_St=C3=BCbner?= , Dave Airlie , robin.murphy@arm.com, iamjoonsoo.kim@lge.com, Andrew Morton , Marek Szyprowski , Kees Cook , treding@nvidia.com, mhocko@suse.com, Dan Williams , kirill.shutemov@linux.intel.com, Mark Rutland , Andrey Ryabinin , Dmitry Vyukov , Kate Stewart , tchibo@google.com, riel@redhat.com, minchan@kernel.org, Peter Zijlstra , ying.huang@intel.com, Andi Kleen , rppt@linux.vnet.ibm.com, Dominik Brodowski , Arnd Bergmann , cpandya@codeaurora.org, hannes@cmpxchg.org, Joe Perches , mcgrof@kernel.org, Linux ARM , linux-kernel , linux1394-devel@lists.sourceforge.net, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Linux-MM On Fri, Oct 5, 2018 at 2:11 PM Souptick Joarder wrote: > > On Fri, Oct 5, 2018 at 4:19 PM Miguel Ojeda > wrote: > > > > 1. Introduce the vmf_* API > > 2. Change all PF-users users to that (leaving all non-PF ones > > untouched!) -- if this is too big, you can split this patch into > > several patches, one per subsystem, etc. > > We are done with step 2. All the PF-users are converted to use > vmf_insert_page. ( Ref - linux-next-20181005) They are not supposed to be "steps". You did it with 70+ commits (!!) over the course of several months. Why a tree wasn't created, stuff developed there, and when done, submitted it for review? > > > > Otherwise, if you want to pursue Matthew's idea: > > > > 4. Introduce the vm_insert_range (possibly leveraging > > vm_insert_page, or not; you have to see what is best). > > 5. Replace those callers that can take advantage of vm_insert_range > > 6. Remove vm_insert_page and replace callers with vm_insert_range > > (only if it is not worth to keep vm_insert_range, again justifying it > > *on its own merits*) > > Step 4 to 6, going to do it. It is part of plan now :-) > Fine, but you haven't answered to the other parts of my email: you don't explain why you choose one alternative over the others, you simply keep changing the approach. Cheers, Miguel