From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48E00C433DF for ; Thu, 4 Jun 2020 11:41:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0923E206C3 for ; Thu, 4 Jun 2020 11:41:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="uOadSoLG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0923E206C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 98FCB8E0007; Thu, 4 Jun 2020 07:41:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 940E88E0006; Thu, 4 Jun 2020 07:41:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8554D8E0007; Thu, 4 Jun 2020 07:41:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 699D78E0006 for ; Thu, 4 Jun 2020 07:41:21 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 174A82C0C for ; Thu, 4 Jun 2020 11:41:21 +0000 (UTC) X-FDA: 76891338762.03.feast00_802272369fe56 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id C39DC28A4E8 for ; Thu, 4 Jun 2020 11:41:20 +0000 (UTC) X-HE-Tag: feast00_802272369fe56 X-Filterd-Recvd-Size: 3616 Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com [209.85.208.196]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Thu, 4 Jun 2020 11:41:20 +0000 (UTC) Received: by mail-lj1-f196.google.com with SMTP id z9so6815430ljh.13 for ; Thu, 04 Jun 2020 04:41:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=R0o4OOvzJQjARhQ6/49UmmkOyadJDn2uKBj3nrOAqQo=; b=uOadSoLGhaseNrsSLG0CEfcx1B7ZyXtznA1jW/71TjOkJaQ3v7NhDn32mtbkkPd0Q+ 1UDuNRM26ag+jysBJHImSQ2kyqAxp6Pbe8OVsuK3/X6E6BLOFRucdGoxisc/QkPMQfn9 DSP221R/DYOdjftqL2dmeYiibVPWWApyDr996ybowslc4DnYfcHTAWJ50hppvye4onSW Wki6t+mbrF7ejKkqVkq6hFcUNg4F2aeKBWSYX0y86zDfF0gdQIlIFvOHHUjNdXP4a7ct pto6mvk/UvVFDpzwyBErLblgdgk4M9JUrlkGy+vs2gLKfjfB2m/WaWMIrcXH9QqP6urW FvAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=R0o4OOvzJQjARhQ6/49UmmkOyadJDn2uKBj3nrOAqQo=; b=e6XVJaJL0yBUpFaWNL41CN/cWESjZLn0zcXhW3MX+zP4sVUVsaSkkJxzDn8cfqEBZa arJQEWZotS2M00vQLonrxJ1vdmiRMpMVjb8HyI+BsArlnYfoIbQ3vn0yd4kQMtOpmjIU pn7IS4Y4K/3GK9lcZ6uUOFdX982WHMN6BeD16hMzyOnxjiUJYjqp7bvcI8IcpEXL93/T TTtZLkwS4KF/2wULrW/MdAbRRbo+5k6/Pl1VkvMYqVdBTVjmOwj0LdOIZ9NoMUKVxe9A aDAZ7KV71xmXf+zYBsCUpnOBn2l6+A6MsOlWceRz3O2gVTklGTqEOn+2D0mpUMA8QrQG 3DlQ== X-Gm-Message-State: AOAM5315+2dKzVjAeM0wXmg+/JTZytqpUEtLMMgn9hn0QYkcNIaJHHXi KqQdUlp14ab1Gd7LOQlOS0VNxwUe07stXTbXPQQ= X-Google-Smtp-Source: ABdhPJxccA+5mnrfVxyneHXrV0mVelE29mG9oDomdWWW1fU5ho8qKcvQdw+EQpyMOql3tRqQBW/MgmXYvs677/gUgQE= X-Received: by 2002:a05:651c:11c7:: with SMTP id z7mr2085283ljo.29.1591270878905; Thu, 04 Jun 2020 04:41:18 -0700 (PDT) MIME-Version: 1.0 References: <20200603233203.1695403-2-keescook@chromium.org> <874krr8dps.fsf@nanos.tec.linutronix.de> In-Reply-To: <874krr8dps.fsf@nanos.tec.linutronix.de> From: Miguel Ojeda Date: Thu, 4 Jun 2020 13:41:07 +0200 Message-ID: Subject: Re: [PATCH 01/10] x86/mm/numa: Remove uninitialized_var() usage To: Thomas Gleixner Cc: Kees Cook , linux-kernel , Linus Torvalds , Alexander Potapenko , Joe Perches , Andy Whitcroft , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , drbd-dev@lists.linbit.com, linux-block@vger.kernel.org, b43-dev@lists.infradead.org, Network Development , linux-wireless , linux-ide@vger.kernel.org, linux-clk@vger.kernel.org, linux-spi@vger.kernel.org, Linux-MM , clang-built-linux Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: C39DC28A4E8 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 4, 2020 at 9:58 AM Thomas Gleixner wrote: > > but if we ever lose the 1 then the above will silently compile the code > within the IS_ENABLED() section out. Yeah, I believe `IS_ENABLED()` is only meant for Kconfig symbols, not macro defs in general. A better option would be `__is_defined()` which works for defined-to-nothing too. Cheers, Miguel