From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3DB6C001DC for ; Sun, 30 Jul 2023 20:43:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D4B75280007; Sun, 30 Jul 2023 16:43:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CFAB2280006; Sun, 30 Jul 2023 16:43:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B9AF0280007; Sun, 30 Jul 2023 16:43:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A81F9280006 for ; Sun, 30 Jul 2023 16:43:52 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 70B2A160351 for ; Sun, 30 Jul 2023 20:43:52 +0000 (UTC) X-FDA: 81069454704.07.36008FC Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com [209.85.128.170]) by imf27.hostedemail.com (Postfix) with ESMTP id B37A840009 for ; Sun, 30 Jul 2023 20:43:50 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=SvzWDh2a; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of miguel.ojeda.sandonis@gmail.com designates 209.85.128.170 as permitted sender) smtp.mailfrom=miguel.ojeda.sandonis@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690749830; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9mDvfJJWxk9twVy3Oy4rXAcXGiHrz6rR6pv/vxBssrs=; b=8eXKuiCmXFTDdTehn/DTbfefdrRfq8nIYSyIVw2rc1sJObI7EbfSp3fa1DINJFzkB9ZLor lY4vPrDCKsl5MbjiLtz9thmNaVPDzY2Xgk7aOr80TTVcVkSjNpOmHk51ekhiYkuRm/uA7V OLy7xPIdpjHkdtITqxwP/JAp8K9i5kE= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=SvzWDh2a; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of miguel.ojeda.sandonis@gmail.com designates 209.85.128.170 as permitted sender) smtp.mailfrom=miguel.ojeda.sandonis@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690749830; a=rsa-sha256; cv=none; b=UorjNleg8t5SOSeTdk6nHsZMeOeKO5XnDanklRqStWLhxPy4rZ0XuNviMXgXu2bpzrJQWp eWLht0bCCFj+fW4bXOENvAYSRDFI06yQ5As745aDclanxmK4HdLD42U2bL6W/rwkqGykYg rtKIcVRRzNCpz2ifGUIbkFT2HTsyNVU= Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-586147e5ad3so6525477b3.2 for ; Sun, 30 Jul 2023 13:43:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690749830; x=1691354630; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=9mDvfJJWxk9twVy3Oy4rXAcXGiHrz6rR6pv/vxBssrs=; b=SvzWDh2azm6F4Uu3toK4qISg1tNtJekhxtPPKEVr5LWDKNma14QIb3IdRm4QSooiCw HpVLjaxLYZmna3NV4nDwi+XyeR3yx6Y4cXn07KpuQo56stgXeLvBsg13FxiluvectFU8 gwVw4NzGWSrUraj4TY98/49Q3/MdyUiTzACf+W+L+4eLmhWVqBMgZZlzVv0dqtn1pDDe tE3YEdI9tx8ewueIRRZoyE2TlVPlvPyLIVCy5GifHuAaTqGBFEWu6Y3khIEWGaF4thv9 7/uWaGJSLDdOLwFYx2rTXvxyqFiyulhM8R3dWwXeH9rWzPUJsiOfl2rmmD8+mrbxOW70 zLPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690749830; x=1691354630; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9mDvfJJWxk9twVy3Oy4rXAcXGiHrz6rR6pv/vxBssrs=; b=kBeqRhogTfYrT2G62dKIRBaCYLQ/JE/5qddT2Wrbbf/tqtCLwyymRoJq5nr6WmS1k8 YrfUae60ouznS/SHzKR/8RyrX0Dvd7ROZoDVSComNhzj3HCFjEEAtPwsYNwqR644nbrb Ck93VFN8YQLVAfAVyhv4rePBMvjJMgvx/mJ6CPt0VrkoYiYMPqfV3UoBS9BydAMJFdOa FkaJDhg3JqcNW340CF/wBQLsX5kmC+Ubll5jceI45FKksctp5YQ13RlvblyXUSLsqSK3 FzO0teocbAjQBaF338m3GtIoMLK6riGif1Qei5jf1N8R115m4T1gq2zPVnVgX+h8WtSh VEmQ== X-Gm-Message-State: ABy/qLaNvcVyuilEfjcZkx0fq6diOPTxzET67078fp2Gx6SRXxxmVVru +6j0EFHUyG10zKV2TMtJ+YoSk7DyYVmAM6tHYkw= X-Google-Smtp-Source: APBJJlHuvAmNpM0DJMHi2ovKVgNsxjBAxDuY4RdcUYR80/VN27ZIuNM+G3dMgtbBcXvXXTBbbknBHxoYOcDFXLo1uKs= X-Received: by 2002:a0d:e84d:0:b0:583:f936:cc5a with SMTP id r74-20020a0de84d000000b00583f936cc5amr7457243ywe.52.1690749829759; Sun, 30 Jul 2023 13:43:49 -0700 (PDT) MIME-Version: 1.0 References: <20230730012905.643822-1-boqun.feng@gmail.com> In-Reply-To: <20230730012905.643822-1-boqun.feng@gmail.com> From: Miguel Ojeda Date: Sun, 30 Jul 2023 22:43:38 +0200 Message-ID: Subject: Re: [PATCH 0/3] Fix alignment issue and prepare for rust 1.71 To: Boqun Feng Cc: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Martin Rodriguez Reboredo , Alice Ryhl , Dariusz Sosnowski , Geoffrey Thomas , Fox Chen , John Baublitz , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Kees Cook , stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: n1mr9xdkx8rtpf7k7wky5dzdts9iym8u X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: B37A840009 X-HE-Tag: 1690749830-859348 X-HE-Meta: U2FsdGVkX1/tsMO/qhUUXn+wXoxdDn6VQB6EoVoB5x1engPYM7IcCYF16QETkviK1hexcJ9j7ocVnV25M6PCaRSOl8Nuzj/djZqxwYdhe6k8kGDKZlFteRyTIgdowXuBZE8o+EPDqN4e8iN0VdbyYmfBpcEQbA1x7UyZep2RuXH3hC7MDVU1qtAz/6T2XRsAuUVC4qwg2qhgdnO0PNtzZw+CNv4GfqGoycW7NDwesuLt+CUyZ/Qreae3JqLxAJ+3+5/2HnLz/EhM05OWdtPAhShUNvAHYruUFvo29gzZnpJzWAOssZ0yElMykhCpjIjNfJ6FpY5f5XvstE1mzBbk6AogKKYoy+N9w0Ae0odpqqA65WsmMtOfEGgR8XPNkWFnjn7fxlr2r09MD832Cuin0yE8h9pkZLh9QHnn6QJvAkNSoI5Nzi6oWzS1lWpG5u5F9spHEID6poZf6Wj9fobQ4qYeyvboEjUvQFTp7kOIaX6LbtLDTLtiRwZuvpz920WWUrAQqtVhpQYMTJ14DvnO9VecGPaA8VAm1YRZcxEvdqMZ5bjqKM7VWBZ9dnu8ZT6B6OtN5m/bO6zMGjLRqN7a8FHvrypWwwEoaJV4RDoKjnGDQOIhCkke7eCRKOV50h1ETeF0yFUA2vHMQldOaxqopL1b29hqqUF4Nf1pB9w0S3XtFiypMI5jOti71YSAHGR1iRno44+2llA9ru0FQ8bje0hMgxIfsmPprkRT6x2rEtAMMNhwN+bxsI6hIa+LGtlgHuImqefLZQv4B8NP6fzF5AviKTJ0E7yBnlf7rF66lA7R7bCDOiwhjOEPpcZIAYVOERvC5gdfGZftaXK4f4hK43+T0l7C/mIVqJyoS6U3iB9LVoATDZami8/cdHfCjVJPhC5pdg5fb6rqbHavtmcxqRLmsgth8Ya4eiJX1FOKuIvCa32wyz9SlMAix9RaeG+TlgOZZBX3S4ZU/NR5W29 XaL54aPV Mev9w2hPBXJmzumpONX3TzjfrThHWvRB0bYDa6CYwPxh4cHMKPrivyBRIXBxY8xBqSRxLwT92YIoEWa6M6Zl3DfaPTbM7GdY7uZOb9VDvIbGVYfmOscq/oK1gXNTPM5NK0sqT5m62UMWreb2CQ3tpGwMLgzMXx/RM5ddQb09/xO7JGnxSVfM5oGuxpcl3JHOsSzhs0YuxlJA1laEwACunbP4DPgi60HqX3sG0SDJbCnkIlQtfYR67CzZXTVyr8VbQ81lwfX0SOe+hkCPFUL/xG3MdnI2iJx6CF+u69EpStDdfm8S5ac5YH0QQrz36OVT2poZb2F8dwhB6C5AKm+I2/yk5VLiqJztuJKJidn74t5b27SrDjGUa5pHCs/C36JFppnDBPIQ1XzxDlF4aUWldXq7SIthXiOIbzSEXVNu3iOhY09YKBR4WUf0TxrQ3YQpTt/WhbKeHLDbdhG76wodRN3ivlbVddJkuDAql X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jul 30, 2023 at 3:29=E2=80=AFAM Boqun Feng w= rote: > > Patch #1: introduces the core helper function that help calculate the > correct size for krealloc(), and also use the helper function to fix > `__rust_*` ones, this should be backported to stable kernels hence the > Cc. > > Patch #2: use the helper function in KernelAllocator > > Patch #3: Bjorn's patch with correct use of the helper function. Looks good to me, thanks a lot! > I have to add a few more SAFETY comments in these `__rust_*` functions, > which may cause conflict with your 1.71 series. No worries. > Since all previous patches get refactored a bit, I dropped all the > Reviewed-bys, appreciate anyone to take a look, thanks! Thanks Boqun! Cheers, Miguel