From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5D04C432BE for ; Wed, 18 Aug 2021 13:08:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6649661058 for ; Wed, 18 Aug 2021 13:08:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6649661058 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id B48BD6B006C; Wed, 18 Aug 2021 09:08:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AF8A76B0072; Wed, 18 Aug 2021 09:08:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A0DC58D0001; Wed, 18 Aug 2021 09:08:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0074.hostedemail.com [216.40.44.74]) by kanga.kvack.org (Postfix) with ESMTP id 843F26B006C for ; Wed, 18 Aug 2021 09:08:00 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 2F9DC8249980 for ; Wed, 18 Aug 2021 13:08:00 +0000 (UTC) X-FDA: 78488229120.25.20187CD Received: from mail-io1-f48.google.com (mail-io1-f48.google.com [209.85.166.48]) by imf26.hostedemail.com (Postfix) with ESMTP id E54CB20061F2 for ; Wed, 18 Aug 2021 13:07:59 +0000 (UTC) Received: by mail-io1-f48.google.com with SMTP id g9so2652959ioq.11 for ; Wed, 18 Aug 2021 06:07:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+tNPb1/FPZA9eF7X+TOOmGLZvE3KZSt2M0L0KXp9Ah8=; b=SZR+b95l8v5SjC4+pZiDHCcUX+iSblqmeJVM/s+LIVGE0d9M2XKc2eZf83W/VLtwau YV/K9Pr2J8jSXAxTCvF5wwLMSc8jy1rwlr0TiM5c7lmyNSdybD34PCPJXGRbWfhZMG40 /C6GhCo91LCITlZissWVpybP/AUB/Vxecy/5aPbNqmmtACa6T3ivbL83rlLU3G5A+LHf rF5ztA12/gyeoarYk+PXsv3UmoYrmUnCp2ROMX5zee5xAr6Nuyif0vq/u6LOeT5ZwcFQ 9nDpp76bChkZFsI29y0uFkDoajLUMgEmcBWrOeUi7mBItCPNEDeNoZVodoxXcFWFPjjQ +5ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+tNPb1/FPZA9eF7X+TOOmGLZvE3KZSt2M0L0KXp9Ah8=; b=qyiJy44j3pFMK2uQIhA3W7H5WY8QngQeK+h2i/YrSGURrsO7GXAfmZXZ+72b9qoagc L/k+jo3HsPMm0HbCMMjHrLe9acUR75FFA0S+g0r3Ec4+XJyNMB9st8Fma0hFKvwbj/g3 x9Kj5F33/zGMQC4/XDJurK2QNoj2c2oJFWo93OJKnSHjnZh+LeL3cJRGRK4r5bZIHuuS 3ZiQmti5nSpsKU2TXgnHPJh1Mi3TpjRG3bDHqSxNsgq9DXCQCKHseyrT2DltX9fQ5OY4 cdHNI5g6C34StpblEq7v1Tbz/imuq0L0EIuiNeEAuDtKC9WwO3TvXChM6mO0p3p7hnNv AG5w== X-Gm-Message-State: AOAM532lB1BmBE4S7HjtcWf+lLifQ5iQovBOf22HobzpVtJddEp+uymd 1dIX115XEQu0B6piTThG3fzsPStKimKoLgwRExY= X-Google-Smtp-Source: ABdhPJwNu2W+2PWsc1G3Nxzpq/lkQoh4zDm3Fav5536uGTKbeL3hSVC+lNuNBiMw408aS96WJUW43MyH/xRVFiXPkoM= X-Received: by 2002:a05:6602:2c05:: with SMTP id w5mr6948405iov.91.1629292079292; Wed, 18 Aug 2021 06:07:59 -0700 (PDT) MIME-Version: 1.0 References: <20210818050841.2226600-1-keescook@chromium.org> <20210818050841.2226600-2-keescook@chromium.org> In-Reply-To: <20210818050841.2226600-2-keescook@chromium.org> From: Miguel Ojeda Date: Wed, 18 Aug 2021 15:07:48 +0200 Message-ID: Subject: Re: [PATCH 1/5] Compiler Attributes: Add __alloc_size() for better bounds checking To: Kees Cook Cc: linux-kernel , Miguel Ojeda , Nathan Chancellor , Nick Desaulniers , clang-built-linux , Andrew Morton , Daniel Micay , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Dennis Zhou , Tejun Heo , Masahiro Yamada , Michal Marek , Linux-MM , Linux Kbuild mailing list , linux-hardening@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=SZR+b95l; spf=pass (imf26.hostedemail.com: domain of miguelojedasandonis@gmail.com designates 209.85.166.48 as permitted sender) smtp.mailfrom=miguelojedasandonis@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: E54CB20061F2 X-Stat-Signature: ffonwft9g5zb64y59g13rbx7faasecu6 X-HE-Tag: 1629292079-827116 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 18, 2021 at 7:08 AM Kees Cook wrote: > > Clang can additionally use alloc_size to informt the results of Typo. > Additionally disables -Wno-alloc-size-larger-than since the allocators Disables -Walloc-size-larger-than? > already reject SIZE_MAX, and the compile-time warnings aren't helpful. Perhaps a bit more context here (and/or in the comment in the Makefile) would be nice: i.e. why are they not helpful (even if rejected by the allocators). Cheers, Miguel