From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4DC2C0015E for ; Sat, 29 Jul 2023 14:01:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2E0458D0002; Sat, 29 Jul 2023 10:01:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 290E68D0001; Sat, 29 Jul 2023 10:01:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A73A8D0002; Sat, 29 Jul 2023 10:01:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0C4528D0001 for ; Sat, 29 Jul 2023 10:01:19 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C464DB1CFD for ; Sat, 29 Jul 2023 14:01:18 +0000 (UTC) X-FDA: 81064811436.12.0585863 Received: from mail-yw1-f178.google.com (mail-yw1-f178.google.com [209.85.128.178]) by imf30.hostedemail.com (Postfix) with ESMTP id 53B8A8002D for ; Sat, 29 Jul 2023 14:01:15 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=a34dpUbr; spf=pass (imf30.hostedemail.com: domain of miguel.ojeda.sandonis@gmail.com designates 209.85.128.178 as permitted sender) smtp.mailfrom=miguel.ojeda.sandonis@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690639276; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2xuh5Cs4UBqNeUNMN/mQsgq83P+5ZISF3WH2e6OwpnM=; b=RTTWJDcu9FcjDFplfIQRIB34c/OT+94C8ViH6asiaJvGkeDHUwDo2SbU2CKT5xgP1j4ycK 27n9i7d88O5WgxcXcaez9uuVGG72gayPMO0JB29QSxaaCmT6Jd+erQqIBiCyehQL/CqEP+ Qti1ASOixo1mXqtKI/8fTj9uwKUD4VM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690639276; a=rsa-sha256; cv=none; b=otkSPPO/BPsgBaoqJY3O2a9+MnIfqCx/Crj5qDhC9k7NJQQ4sOhc1b++oHyyuOtVha7Swf L6dyKNBz9Yin6co0S6fdn7Hvq+loqS+of/au86U2GQ0DBs4OHeupk/pkjXlWPX1e3z9Cv1 peGgEAdpPDlSAckqyiUv9lO+go3oBls= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=a34dpUbr; spf=pass (imf30.hostedemail.com: domain of miguel.ojeda.sandonis@gmail.com designates 209.85.128.178 as permitted sender) smtp.mailfrom=miguel.ojeda.sandonis@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-yw1-f178.google.com with SMTP id 00721157ae682-57026f4bccaso32568457b3.2 for ; Sat, 29 Jul 2023 07:01:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690639275; x=1691244075; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=2xuh5Cs4UBqNeUNMN/mQsgq83P+5ZISF3WH2e6OwpnM=; b=a34dpUbr0J+lB/6X/9dOdt8MIolcJxJtduwWqrPhvTUwrs0Oq/zRrmUWRmmDtQZLe0 TM8yy9ifgT5MD1+ZpTrgN54Ely0YOdnxPKx8uO6cTXD5YcDnm6LRFxHFFhfkXU3AynOr pcd/BITAtsC8UqViIR9zgoRIpZFqReCbuegTSbGYQLpJEfPO521QXrHz8NRUtToshF9Q 4M6N/DbwqxkFzgwZJxF3GV74bWIn+tyOicxu6aHDWnAmL8xv9kGqoKftZrR0gQOaiZPs fI1cVfhx1UXDdAsG9xUejDLLFejyz1FK6om+88Vzw37QbboNYlwGr044OVa8Q7DmjfEf 7WyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690639275; x=1691244075; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2xuh5Cs4UBqNeUNMN/mQsgq83P+5ZISF3WH2e6OwpnM=; b=INaZPDmtLA5Smr6W6wcRGp22/gb5p7HVg6Ln5ugzrv93iPHT9t7JwuZDi+b/P3yAlN Ikx8YWXRGuqVOdDWP7QgWOjvawzEsTz9uTT5jj8obDIcrr6Dnb1MkGUApfzoCaeVQn/3 9JYWWa+2pwtga0Gc1EvDZYHyXJYEEeQzmOAyEXFxsNbZehvv9RAnpNmE+0xEFTCkPwtT asGNO0nHEo0upxmwf1n5Kea+NvHBiZ2eVpuHpdNM98ITSkY6/kJr8qhy2JTjjOfSgiRd 5q7oLFwXzm7RgUvgPWq8vH9rHjFzlM7xDHt+qlCKHj7xx55Tzx0NbtpXmhAs1ly8bQS/ nMiw== X-Gm-Message-State: ABy/qLZuryNof7z/FoFpzBmHT0K3OyMKJLQ7YH6ZQHVJf8a9pEeDx+cu wq3NizO5A0HjBJ3SWwNRDXJKGzmmcij2ZJykWzk= X-Google-Smtp-Source: APBJJlH2f7tTSk2LKKiyU6HMdSYF5+PJWAFjy4HpY/d3u6cNzJrPmo83donOPCTz6iRTWqsUpKARd1HO7nnRDRO7xBo= X-Received: by 2002:a0d:db44:0:b0:561:c5d4:ee31 with SMTP id d65-20020a0ddb44000000b00561c5d4ee31mr5593709ywe.38.1690639274765; Sat, 29 Jul 2023 07:01:14 -0700 (PDT) MIME-Version: 1.0 References: <20230613164258.3831917-1-boqun.feng@gmail.com> In-Reply-To: <20230613164258.3831917-1-boqun.feng@gmail.com> From: Miguel Ojeda Date: Sat, 29 Jul 2023 16:01:03 +0200 Message-ID: Subject: Re: [PATCH] rust: allocator: Prevents mis-aligned allocation To: Boqun Feng Cc: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Martin Rodriguez Reboredo , Alice Ryhl , Dariusz Sosnowski , Geoffrey Thomas , Fox Chen , John Baublitz , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Kees Cook , Andreas Hindborg , stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 53B8A8002D X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: wu4wrceyccdsiqei1xiuubwrtm8qepiw X-HE-Tag: 1690639275-461234 X-HE-Meta: U2FsdGVkX1/EcJ72srnUIUByu8w3Gvw8c+qKaX9SBlnfEid3qf5l4QFUIp/wG3IeZOC0uGxvfLw4M2QEk1dQaz79GLRUiKE3YgJ4z+wHdrxkOnCiF64x4n3SyzhMJc7QyR5Ku+3dcz2yQVrrDac1Z/Dyy7XjLwarmzwthMmgrIs4BgxtZvc1Xo93tF/onAMwFd5DKoqeceOQRrwesuD/lKab3rmd/Xrmss0mg0bucF1jr6FpHD0vUTJZk8TekQErKeHLtAuhJjl9a8tykr2f5c3G9kua6/VAqNcXzf28CQ+PhvYhkhIphTBMfCscWcKn+ulxbnDRtu93L7f6ep7aJigba6zGxqsiQx53WCgPaZHTokR88NVjZ7mnug0qI0UTAPBLfegkGfIpkpzd1W0Y6XEPDwd2V4OQslAd706wNRcDq6TAV3Eg5PDUW0p/DIM2mhCAUzSSO9YbFe/63sFI4jnERT77uT1MJS8x9HrRky3x1edLkUg/rj2ikVX5nJWVolyKgXGjYXLugjli1FJzBCFjdAapx1aCQxQ7zUEmKgTEL1jbZ+JONq5Grn8gUGJF6/EeQUqlWBSK5iaHzMBUN2XMwtERYgx4LIyJ3RX8QXIf7v0l2HGQqvfZLu6G9wZSglmDuo9oyqd/Q6yiEmH8pRE2/HNhGVaBl+17bBfY5MrbRXFLTgyv0eS54wxqpbNkFYza4zoEfGik4n0+r1QtUXVIG7mH5Do/61K1eu5W8EqqYg1SknvnmO4K/joDc+2zsJ+PL+ZdD3t4vddmmm6hn4V58Me1PcysEzUCy2/Sah/PXhzxxkWAHV0v5GtvwCLx6kowuW0PZcIfXQHyGLkjr/E5PObYaEyVLw/ejjXeXJZnGVgvdjJVo65QXXXbphSCnUXmV6/YW93elMOXnsz6wAuohm8mA4S+E4sBHYM8B35zIfYLbC6jyfDMCrpCGqP/0zin0m59s8Lm59I8Udd 01oqCB9s LR3R4mobb4fIFULmTsvfZibNPtkHdokIJ7N64CHq50EImZKjmfrfyrW66+Js0v1bpR334BbLhclpJsWjpIJ4A6mELThMuIoii5PePlhGTaM8DhP2Pjt6vLF00Sn7pZkraJ62VeJ33phKwB3A8H+1rUChxlOsaSWDlqo9d6DHR0t6XlI8yL/bRmCWEtDg6GLgqsqkamGKrt93wKPcuGVCMNeNIf5x97GHmIHlUTEsOEAv0QfecDemRKtpaMjcP3ZdAFvo7B9HmaIM/pxcSQuuC52rZz1DFpBjpfzEZ8Tp6j9biDTaNkXLOLVWQRnLI0UtveYq/ILq5cG+kR0J+4BGAJSk1uqs+xtK55PPI1cZ04rvSuFOBf9pxgxUzzxTPWJxgEs+DbuBUF43UjiCE86Mdv9n+N7eofftObdR1Swx661CIsa/pyvMol66b1v+tn5Ta7+Nqk7DsYa8E8PhVAoX6JuPxAVcZqE4YakqKt/tzLlFmsqY6um7AJlWd7Wi4/ho+rsOZF/NczKWvQ2dZlw1VWCmW8F2WDWfBqdl5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000017, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 13, 2023 at 6:44=E2=80=AFPM Boqun Feng w= rote: > > Cc: stable@vger.kernel.org # v6.1+ Applied to `rust-next`, thanks! However, should this go to stable? The actual functions being called are the `__rust_*` ones (until they get removed in 1.71), no? Thus this is not actually fixing the actual functions being called, right? If that is correct, then the fix should change the functions below, perhaps adding `krealloc_with_flags()` from the other patch (it does not need to be a method, by the way), and calling it with a `Layout` like the generated ones do. Then I can rebase `rust-next` on top of the fix that adds the `krealloc_with_flags()`. Cheers, Miguel