From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41CD3C41513 for ; Mon, 31 Jul 2023 00:13:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8C6FC28000F; Sun, 30 Jul 2023 20:13:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 87672280006; Sun, 30 Jul 2023 20:13:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 73E6528000F; Sun, 30 Jul 2023 20:13:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 614CC280006 for ; Sun, 30 Jul 2023 20:13:58 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 301891C9748 for ; Mon, 31 Jul 2023 00:13:58 +0000 (UTC) X-FDA: 81069984156.07.D154516 Received: from mail-yb1-f181.google.com (mail-yb1-f181.google.com [209.85.219.181]) by imf27.hostedemail.com (Postfix) with ESMTP id 7754C40011 for ; Mon, 31 Jul 2023 00:13:56 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=iIX3rm27; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of miguel.ojeda.sandonis@gmail.com designates 209.85.219.181 as permitted sender) smtp.mailfrom=miguel.ojeda.sandonis@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690762436; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YxcxzYh+eRe0jLj17RGPzPTU9bsNELCXWRjDPqz5Xds=; b=fK2wJfhX+9Y9XYaRAQyU0MOjacXNPM0w5B/kzEsPFrTAvwbpq+5GuuQHJDbd+n6IB/BjTR 9TdVEagXV5HysyfwwtQSmf/zrfpkxs9WmJuV+cXPiV1LwzdCXpNvdt7z9til8767h/aTpr NiB9ZunVjR5YY5kCxCMzH/XBp7gh7uY= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=iIX3rm27; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of miguel.ojeda.sandonis@gmail.com designates 209.85.219.181 as permitted sender) smtp.mailfrom=miguel.ojeda.sandonis@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690762436; a=rsa-sha256; cv=none; b=egvmttoZwY17jGBJn3SwLJkwivqorl97cCPO8rGj9qnLf/kMUEhMX+IVHcVvbEmTIPYTtG L1n70HsaNKiI0rfy7vMG3etPK73fgPplsdWnbHeL0H0AQqRtjjgqX1ngfjVwgsB/nnDHRS S39xfyG8+NvvG5u+SC9eFCHL0a0DD14= Received: by mail-yb1-f181.google.com with SMTP id 3f1490d57ef6-d2b8437d825so1703539276.3 for ; Sun, 30 Jul 2023 17:13:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690762435; x=1691367235; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=YxcxzYh+eRe0jLj17RGPzPTU9bsNELCXWRjDPqz5Xds=; b=iIX3rm27Srf9Kp7m4EZr5m4I5D8l2keT3jNRf1MtDyaC2p2aNg25S7WXO9GPJlxumN A1qXNtJ6D9+gLiwvUWIVcKu3Nnjc2JYr9VkTfGH1JDHNS0gVvF3iYwikBmvg/dlMQOHE rOjLSHxxEE7N7+9KdzfjI651X6ZcMv7VYWAKgIqLVqvOrv4WtLEgMw6UI8J5lDHHM3vk pvxOgz6qzHvl0rfl8SNznjTcGz5ZeYb7uPG+Zmqz6Xa3SBwYQYcaxGz7dLNaggNpGE/E 9QQkj9682Mr+dQfgz9s37/s+eDWrYM/lAbSnlWl9ME743mS7xsjOspwa2RUIuFBHVf5n mZUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690762435; x=1691367235; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YxcxzYh+eRe0jLj17RGPzPTU9bsNELCXWRjDPqz5Xds=; b=kXZqa/j2C5bP8dLcO/zxelbDqFKBGIjQl1MGPF6A+Mc11fiyUUfkWSUtPPilFTqpn5 3dafAEMeoRdGWrGsAB6LtoSZvIpbueY6w9paaMxgtgK+HoOdoMjIYDj/vi40Eho09iKJ oeQ5i7kT9/UwYk8ixuRnypmZ1m5tbwyzfs+l/apUcVyBTxk//LYEIeoZ+5yl8GSkwguE Ox/3ZuuuwrzOaK8ovXO2Fo77axB50VfjxJtqSHO+WHpcZx5JwI22t/gtjqcqYIfEQWlc FheD5hUhZxv+T1ZZJX41okL4gOn7RkdoT5p0j15Bm2rQcqh2Z5BZhfXs7AA1C+CmGj6e CP8w== X-Gm-Message-State: ABy/qLZQm5rnzfaXTlb63cevM5BTekV1yslOJ5FzMxezcn/Nx8ZYcKhy G2liU6TLuQvbOj2Fn6SBBurmevTvKGanw8wKvEE= X-Google-Smtp-Source: APBJJlGsIy3HmZ1rOv1QWKk8I7vFIuCtffLci+mjycRk1R/nR0bx1Cpc3iOx+dyG8M6B5F30izeTav6/m9uTk4xlwDE= X-Received: by 2002:a25:e758:0:b0:d0e:b924:8e20 with SMTP id e85-20020a25e758000000b00d0eb9248e20mr7598351ybh.22.1690762435501; Sun, 30 Jul 2023 17:13:55 -0700 (PDT) MIME-Version: 1.0 References: <20230730012905.643822-1-boqun.feng@gmail.com> <20230730012905.643822-2-boqun.feng@gmail.com> In-Reply-To: From: Miguel Ojeda Date: Mon, 31 Jul 2023 02:13:44 +0200 Message-ID: Subject: Re: [PATCH 1/3] rust: allocator: Prevent mis-aligned allocation To: Boqun Feng Cc: =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Gary Guo , Benno Lossin , Martin Rodriguez Reboredo , Alice Ryhl , Dariusz Sosnowski , Geoffrey Thomas , Fox Chen , John Baublitz , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Kees Cook , stable@vger.kernel.org, Andreas Hindborg Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: bb3uq74zr99xgspyemo9jgeat4nnqkw4 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 7754C40011 X-HE-Tag: 1690762436-36107 X-HE-Meta: U2FsdGVkX19Xk7AErSWf6Pfru/pV1lcDYhZL3IklxcAVLfQuTzIQDBa0t+iIO4hJ0AcR4ICVHJMTk+mt/RoNx0o/tmmvql6ScWtFaK6KSFkNlRNLlP8FS0eRmZFM3xKCtc16UGcpWi0Ys/FKC7CXiwH0eBgbyVRAIrVxJCJthd081sOGBpOvVD5tGGONKDXnCfWMq0oosv07deWgbbNKZ6ByXEsSfMyu/zxOEqpLHojlNkMzzzRaOqJSuommNpTt5GqWif4+J0+7dvxuNnVYLPKhzrQ5zzyie6UNXLGHfqInqweFy1snH8Qa+flj36stVZTJ96Z6mKLS+tPsE2uXPHxbosdqTZO7HYyvOyOdd9xhihpwIbhw++eCStGRkqg7FXwfoRovCU7aEFAgwMnzmfPlZ2C1p1k3qZPekOHyTI+jThTZdNtaSyMTw7ey7mvRK7DHN4cJ+UaUn3GGG/taLk551b1nEQCjR0GCskNaImkdUGvMeoDDWGk8yNK03o4qBEOSJrmd4ZEPw0IpmAhlEQkaLDXTGBCZvsvTFmfqoOdSEzJxHVBoCPSIgrh3PHGJg2qAIRXWMmSiFy3pupen41QPVbwBk4qJ23QLIQzQVxVH8TLvaMGDDMTe36JrME3twMaQjbeAhkaGzwxKFvscX2fMxhuNZqjijJjOXmJ+9Eku/cAIFiRSNmbxcs6Wc8Am2Bfr3dGmM74U+vFF9hq+GyPOkJTeqxa9cRU28bdl8cT59h8Tibkduj2WCJ0Fs2LX5JN3RKDFRn0Boj6mC6xAEjyuz0yruMDgXE8XmtztjZewuXGL7BroXhtrJliF24KjhmkSImXPU75oLEpP9YDtP7HQ4ucMusdZCOQWKcMsrzjI/oWu2AHaX+f4kZKcRlT40Zhi+of2D2R09DBNAL9/7vW2hBpMed6n0xC1jj2vWVQvfMB3xXw0Lqe7jyXgPT3qSDR6mWBCd1oNakoARL9 iHz3mfOA 2+Bq6fl23fF3wN4DxHcqIQ7ViSXe+ZbbPYGvhix2G/YzHOChro4esMygH+rGO7nUfEZzWXdAiJZrhyJgmn4WiorZyZf7Mh4hO+PW3bNeIuA6Jn1S0kp8QILYMmeuv0nIqAIbJ0KZ+h3AtvGUEjA7Rfn377bTxiTu6fvCiAsa87ukBpsSSROmEiQw1N0FPGZz6DvXHeYKr6FSyTbY5SKS0tYEJMvMmYDUGteVmDObGu0b1krf064bnjpxR5Q5PblYWG13dah+aum8FnURjG1G1u7hxiACG8oks5yZdnEgUIgs8iyI1hxQ9Sl32ZOXmvD7TKacQlBT+FNXfvZ1FbkeC2YEjRqLVlFX6YymMMLyW27utWjVNw2mq7NHbKCj0oMDgYQu4TXAQz1FIo+WCY7SqJSs8CSXdiLCr3d+9OFGOiSpHDAwTwJRB42861iiE44KVwJbz9+wQToGsc0dQKNKyLZU+7+Rcg7MOe0GV X-Bogosity: Ham, tests=bogofilter, spamicity=0.002051, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 31, 2023 at 12:54=E2=80=AFAM Boqun Feng = wrote: > > Good to know, thanks! Yeah, thanks Bj=C3=B6rn! > Agreed. It's better. So reword as below: > > // Note: Although these are *safe* functions, but they are called by the > // compiler with the parameters that obey the same `GlobalAlloc` > // function safety requirements: size and align should form a valid > // layout, and size is greater than 0. +1, thanks! Applied to `rust-fixes`, but please feel free to send `Reviewed-by`s. Cheers, Miguel