From: Jan Glauber <jglauber@digitalocean.com>
To: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: Fix shmem THP counters on migration
Date: Mon, 19 Jun 2023 11:59:56 +0200 [thread overview]
Message-ID: <CANhVioJwcCZJC9Hbz3omq81oe=EcV4yFJHE3_fdsKBUVOU-a3Q@mail.gmail.com> (raw)
In-Reply-To: <ec37f55a-181b-a035-8b71-3cde3cb8cc66@linux.alibaba.com>
[-- Attachment #1: Type: text/plain, Size: 918 bytes --]
On Mon, Jun 19, 2023 at 8:40 AM Baolin Wang <baolin.wang@linux.alibaba.com>
wrote:
>
> > diff --git a/mm/migrate.c b/mm/migrate.c
> > index 01cac26a3127..d2ba786ea105 100644
> > --- a/mm/migrate.c
> > +++ b/mm/migrate.c
> > @@ -492,6 +492,11 @@ int folio_migrate_mapping(struct address_space
> *mapping,
> > if (folio_test_swapbacked(folio) &&
> !folio_test_swapcache(folio)) {
> > __mod_lruvec_state(old_lruvec, NR_SHMEM, -nr);
> > __mod_lruvec_state(new_lruvec, NR_SHMEM, nr);
> > +
> > + if (folio_test_transhuge(folio)) {
> > + __mod_lruvec_state(old_lruvec,
> NR_SHMEM_THP, -nr);
> > + __mod_lruvec_state(new_lruvec,
> NR_SHMEM_THP, nr);
>
> Should be NR_SHMEM_THPS.
>
Sorry, was testing the change on another system. Will send a new patch.
--Jan
[-- Attachment #2: Type: text/html, Size: 1425 bytes --]
next prev parent reply other threads:[~2023-06-19 10:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-19 5:57 Jan Glauber
2023-06-19 6:40 ` Baolin Wang
2023-06-19 9:59 ` Jan Glauber [this message]
2023-06-19 7:50 ` kernel test robot
2023-06-19 8:11 ` kernel test robot
2023-06-19 8:11 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANhVioJwcCZJC9Hbz3omq81oe=EcV4yFJHE3_fdsKBUVOU-a3Q@mail.gmail.com' \
--to=jglauber@digitalocean.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox