From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98189C43334 for ; Thu, 30 Jun 2022 14:59:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 01FC28E0002; Thu, 30 Jun 2022 10:59:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F37708E0001; Thu, 30 Jun 2022 10:59:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E257B8E0002; Thu, 30 Jun 2022 10:59:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D53828E0001 for ; Thu, 30 Jun 2022 10:59:29 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id AB8FC807FC for ; Thu, 30 Jun 2022 14:59:29 +0000 (UTC) X-FDA: 79635210858.24.44948D0 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by imf15.hostedemail.com (Postfix) with ESMTP id 65776A0032 for ; Thu, 30 Jun 2022 14:59:29 +0000 (UTC) Received: by mail-pj1-f47.google.com with SMTP id n16-20020a17090ade9000b001ed15b37424so3130980pjv.3 for ; Thu, 30 Jun 2022 07:59:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vDdC8MWrQ6wZJiRG/CDlxCW2oNQMtGgdO4bcX2PBWTo=; b=hUkLdRk5Sl/4Klb0oO55UMPf9zmWbX29THlfRNeOGCiw929jeEGHVT+X8rkl2+0b0W AxVBSV73eAn41PobV29GVgABmsQZcvrWWziySDPM9LeV5+fJlQVX1EA7l3wuQ0gGvpuX KHKqvN9vj+dZorzYnrPQCQ45MagiZJExnu34wMpGveMtM4vXX5axppP5X7A5LPus3Jke 72z4ETDKKHjxz+b6saIKbniCZvDz6ujimO4EBBMX3iWNrnnQIjb7u8t9VYwxONIj5o/x j8acEPrL8LBSs5WiRVRwLLQBrXWc1Fl34zfA10r7Bc3xWAOlSPVKmwFqxxP5horzQppO aRMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vDdC8MWrQ6wZJiRG/CDlxCW2oNQMtGgdO4bcX2PBWTo=; b=kSnBZr9NpUp7/b6+9qv9KiF1gu4BrEBAdFZTd6kP8u4GRtFqGtgQiIdEgywtRlekHp WlNk/J9CuAwwqev8aOUR/PG39L2lZH9HKQO9ruuYaP1WilPYMfGUHNBOTKdAesRNM0is VfgOJ5M2NSxoObj5/lisd0EVyFe2+uEcrPPDJv11pOD2hXoAPoZ2eA9W25CLEsqtcjZ5 ek5EZTPMFnPHRBJRkEw7xAJRfFbYIGofAtTyADv1EJ35hJgYtDXwjU11AEQ/i9naVEPz CiMPX6EHfPuTT5EVVSh5s9YbDKZ2Qa0ei3Mn4NF4fQB1ZnFqarFd4iK/qwsX70ZQ3G+2 O6Ow== X-Gm-Message-State: AJIora9catAfGsYm3Ekze1Ml+2/1H+s83/lBwLkD3bfHYqhqHSnX5CcG EnC+HWHj6WGAhbUEEp+w6RMdSMFx3JRHHaFGpSE= X-Google-Smtp-Source: AGRyM1shSTsxwuCBHUACAQlZ5+ZkkdgCKu271yMVqtcvNSFnvG1kqiGCJylg52i/qOqhou6yjlR/94Q8T+U7Nqxk2kQ= X-Received: by 2002:a17:90b:38cc:b0:1ed:474a:a675 with SMTP id nn12-20020a17090b38cc00b001ed474aa675mr11080856pjb.149.1656601168472; Thu, 30 Jun 2022 07:59:28 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Mark Hemment Date: Thu, 30 Jun 2022 15:59:17 +0100 Message-ID: Subject: Re: [PATCH v2 5/9] mm/mshare: Add vm flag for shared PTE To: Khalid Aziz Cc: Andrew Morton , "Matthew Wilcox (Oracle)" , aneesh.kumar@linux.ibm.com, arnd@arndb.de, 21cnbao@gmail.com, corbet@lwn.net, dave.hansen@linux.intel.com, david@redhat.com, ebiederm@xmission.com, hagen@jauu.net, jack@suse.cz, Kees Cook , kirill@shutemov.name, kucharsk@gmail.com, linkinjeon@kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Linux-MM , longpeng2@huawei.com, luto@kernel.org, pcc@google.com, rppt@kernel.org, sieberf@amazon.com, sjpark@amazon.de, Suren Baghdasaryan , tst@schoebel-theuer.de, yzaikin@google.com Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656601169; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vDdC8MWrQ6wZJiRG/CDlxCW2oNQMtGgdO4bcX2PBWTo=; b=b5Ui3BkvrGsiBe8Vf4PeHD++Vy5g85NGbGtv3k67iXxdwsLwhRl1bK8mOPyzweuEytyWUk 6hSpdJve2sdq4O645matLkqjHpfxfM/b4vkoap0M6sPoCbPfV7c8JowZpDy8s/23nO49ME DxrB9zqh/XOlk2ad3qUGdWGQJjF4rgQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656601169; a=rsa-sha256; cv=none; b=h7RRDvHZz3ooMZffuDsx0ooSMeNvaXdndqj9/8m60wstNMh5FbCm66K8Y3CM9THehRRZpy 5FF695GmZc9fFO/oEgXuHXdMXceteS8eXbmnr+d8SeQeTENlUQrDKouaJ5lcbG+lhlbe92 O4NBHiVm37Q3WiEGiYMOKzzy9yHeKSQ= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=googlemail.com header.s=20210112 header.b=hUkLdRk5; dmarc=pass (policy=quarantine) header.from=googlemail.com; spf=pass (imf15.hostedemail.com: domain of markhemm@googlemail.com designates 209.85.216.47 as permitted sender) smtp.mailfrom=markhemm@googlemail.com Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=googlemail.com header.s=20210112 header.b=hUkLdRk5; dmarc=pass (policy=quarantine) header.from=googlemail.com; spf=pass (imf15.hostedemail.com: domain of markhemm@googlemail.com designates 209.85.216.47 as permitted sender) smtp.mailfrom=markhemm@googlemail.com X-Rspamd-Server: rspam03 X-Rspam-User: X-Stat-Signature: 47ryufkcnpueabq6aorzj4ocfmhi1gxi X-Rspamd-Queue-Id: 65776A0032 X-HE-Tag: 1656601169-457662 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 29 Jun 2022 at 23:54, Khalid Aziz wrote: > > Add a bit to vm_flags to indicate a vma shares PTEs with others. Add > a function to determine if a vma shares PTE by checking this flag. > This is to be used to find the shared page table entries on page fault > for vmas sharing PTE. > > Signed-off-by: Khalid Aziz > Signed-off-by: Matthew Wilcox (Oracle) > --- > include/linux/mm.h | 8 ++++++++ > include/trace/events/mmflags.h | 3 ++- > mm/internal.h | 5 +++++ > 3 files changed, 15 insertions(+), 1 deletion(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index bc8f326be0ce..0ddc3057f73b 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -310,11 +310,13 @@ extern unsigned int kobjsize(const void *objp); > #define VM_HIGH_ARCH_BIT_2 34 /* bit only usable on 64-bit architectures */ > #define VM_HIGH_ARCH_BIT_3 35 /* bit only usable on 64-bit architectures */ > #define VM_HIGH_ARCH_BIT_4 36 /* bit only usable on 64-bit architectures */ > +#define VM_HIGH_ARCH_BIT_5 37 /* bit only usable on 64-bit architectures */ > #define VM_HIGH_ARCH_0 BIT(VM_HIGH_ARCH_BIT_0) > #define VM_HIGH_ARCH_1 BIT(VM_HIGH_ARCH_BIT_1) > #define VM_HIGH_ARCH_2 BIT(VM_HIGH_ARCH_BIT_2) > #define VM_HIGH_ARCH_3 BIT(VM_HIGH_ARCH_BIT_3) > #define VM_HIGH_ARCH_4 BIT(VM_HIGH_ARCH_BIT_4) > +#define VM_HIGH_ARCH_5 BIT(VM_HIGH_ARCH_BIT_5) > #endif /* CONFIG_ARCH_USES_HIGH_VMA_FLAGS */ > > #ifdef CONFIG_ARCH_HAS_PKEYS > @@ -356,6 +358,12 @@ extern unsigned int kobjsize(const void *objp); > # define VM_MTE_ALLOWED VM_NONE > #endif > > +#ifdef CONFIG_ARCH_USES_HIGH_VMA_FLAGS > +#define VM_SHARED_PT VM_HIGH_ARCH_5 > +#else > +#define VM_SHARED_PT 0 > +#endif > + I'm not clear why mshare is using high-vma flags for VM_SHARED_PT. CONFIG_ARCH_USES_HIGH_VMA_FLAGS might not be defined, making mshare unsupported (or, rather, broken). Is this being done as there is a shortage of non-high flags? 0x00000800 is available, although it appears to be the last one (quick check). (When using the last 'normal' flag bit, good idea to highlight this in the cover letter.) > #ifndef VM_GROWSUP > # define VM_GROWSUP VM_NONE > #endif > diff --git a/include/trace/events/mmflags.h b/include/trace/events/mmflags.h > index e87cb2b80ed3..30e56cbac99b 100644 > --- a/include/trace/events/mmflags.h > +++ b/include/trace/events/mmflags.h > @@ -194,7 +194,8 @@ IF_HAVE_VM_SOFTDIRTY(VM_SOFTDIRTY, "softdirty" ) \ > {VM_MIXEDMAP, "mixedmap" }, \ > {VM_HUGEPAGE, "hugepage" }, \ > {VM_NOHUGEPAGE, "nohugepage" }, \ > - {VM_MERGEABLE, "mergeable" } \ > + {VM_MERGEABLE, "mergeable" }, \ > + {VM_SHARED_PT, "sharedpt" } \ > > #define show_vma_flags(flags) \ > (flags) ? __print_flags(flags, "|", \ > diff --git a/mm/internal.h b/mm/internal.h > index c0f8fbe0445b..3f2790aea918 100644 > --- a/mm/internal.h > +++ b/mm/internal.h > @@ -861,4 +861,9 @@ struct folio *try_grab_folio(struct page *page, int refs, unsigned int flags); > > DECLARE_PER_CPU(struct per_cpu_nodestat, boot_nodestats); > > +static inline bool vma_is_shared(const struct vm_area_struct *vma) > +{ > + return vma->vm_flags & VM_SHARED_PT; > +} > + > #endif /* __MM_INTERNAL_H */ > -- > 2.32.0 >