From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C98F6C54E68 for ; Thu, 21 Mar 2024 04:27:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 686676B0083; Thu, 21 Mar 2024 00:27:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 637316B0085; Thu, 21 Mar 2024 00:27:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4FE596B0087; Thu, 21 Mar 2024 00:27:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3E87B6B0083 for ; Thu, 21 Mar 2024 00:27:14 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1A331161486 for ; Thu, 21 Mar 2024 04:27:14 +0000 (UTC) X-FDA: 81919761588.22.9C2D1C3 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf23.hostedemail.com (Postfix) with ESMTP id 82838140012 for ; Thu, 21 Mar 2024 04:27:10 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=a783LUz+; spf=pass (imf23.hostedemail.com: domain of chrisl@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=chrisl@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710995231; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OtSttZdeL8cIO/qAimcdAFVEJRiVabrqEZeRMJUT1fg=; b=yg/ZrNGixH+H+HKwNFt6weG9I+MDYkY4dimIc+q+oVPXtxR3uM/u0K3f1I7/kfxSD6EFXV dYj0GAuHs1BKbDYeBd498OGVi9BfKFnrWzq2i6BPSoZlWTSSeZjModft1Tqo73rWk97rpk wZ82g8cgjOn46khqJCbyTyBOm0W3OH0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710995231; a=rsa-sha256; cv=none; b=u2HlWni503b9bKRT7U92KmZs8PaHpdes66VoaPpDHTzyTkXb36gl8lYajtseP8TgkFWAjD 3ieo8YJKJ8eYo9kPLZc0rWdMyU2YiZlQIJeQxcm1VrIIgC3P8hVfj/Oe9u6YfAQtYnJqMf 9fzfnfyxI7qOO07oksqMe2uahLn6YF0= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=a783LUz+; spf=pass (imf23.hostedemail.com: domain of chrisl@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=chrisl@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id D4D99CE128D for ; Thu, 21 Mar 2024 04:26:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E682C433A6 for ; Thu, 21 Mar 2024 04:26:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710995219; bh=OtSttZdeL8cIO/qAimcdAFVEJRiVabrqEZeRMJUT1fg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=a783LUz+YBi0i2roWjvbR9L5BqH/jMYbVxk8StyclDB79gBeHpjSs7Doju6kDMBk2 ecCopZetZoByUFvx9CJgtOMURWJnhTMj0XIgzmxzySSwKUqTvZ27kYNVP4NivNPrlt lBjTvgRP5BJo39wfyZhF1EKpzfs1cJwS+ens/9IEoAzbHXVEQYGVCa7CQKFBbBz2ZX +9fwYZeqPLrxfnpmmi/+VQynFwe4QomKYbbZmLL1CDdQ73EdL+nRQezswcAvtfjE6i NSqYK+AH0sjF3vcP+cl68qL8gZVjD6WUlaHaBE2L+7dyCU8l+ACE1I2Ia8tJiQm9KP mmdF/oU5QfD3w== Received: by mail-lj1-f181.google.com with SMTP id 38308e7fff4ca-2d48ba4d5ecso15101051fa.1 for ; Wed, 20 Mar 2024 21:26:58 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCWGcvCnBuukLeE7EJqB5XGJKTJOrEePLALTlAEvs4RctX9noYO9g+J7T+OInD7cdWycNJ+53S88EiM7gXvMnghwtso= X-Gm-Message-State: AOJu0Yx2gNtRxzZr4LWnBkVxiItDKZgnp+fXxBHPAfOlrnuzBZgrGmFW E0hVDaFECFAaZf+ksuZO/IDQuP0lZijUkUQOJ3q0/AC6gOSYs2ZxNBXB/aROonWgh9kGTvBo5aq voCt5dEoIBj+P2TMYyToOi67AUg== X-Google-Smtp-Source: AGHT+IEZitZpPaA+yQ4CQ1lxQCDb2pwwCLNrX2CRCKvlDrSsDXITENodVIruip3qR7mOcmNumdHl84SVDx5DYEwAWPQ= X-Received: by 2002:a2e:3a12:0:b0:2d2:b99a:4f6b with SMTP id h18-20020a2e3a12000000b002d2b99a4f6bmr437080lja.8.1710995217664; Wed, 20 Mar 2024 21:26:57 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Chris Li Date: Wed, 20 Mar 2024 21:26:43 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC] Storing same-filled pages without a zswap_entry To: Yosry Ahmed Cc: Johannes Weiner , Nhat Pham , Chengming Zhou , Linux-MM Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: uf9cm3htji8xc4jw6pmfb9uf1xrrjnqd X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 82838140012 X-Rspam-User: X-HE-Tag: 1710995230-578985 X-HE-Meta: U2FsdGVkX18el22sxJM8hRyvR7eRQDtlTksjFCSdzrtZBQU4JL/HXZVfe0Zwub0lUCENfoIN+/X2vgt5mU2fBKjalEBG9v2VuwRHbNp5yEeQB72m/b3ZguOqRobw41jUhvw4GW1XBKzHfcb/d8CHKfdp8JpHE3wZaVEbSHnrxS/JFtY4ZGCffkMMzvS+49PGAy9jwAHfSnnTdQMaJVR38Mg93gUQujoMJWoUFAyS3H77bOp3nCNRfGXMESTWPjv3XAWkjREA+F1RXFOvVKsudw8Z2N7vd5m4j8EGbB3aa2uFNrvfF/gatSlzFst+qQdtnAHU0Qma1ha/KSZy6jxZNu77X0SEa1kj+p857wOQSYGWzQ7pns8DjXU5Df8xYp9lBvUUC/nNZPC+0HUSxdTt+59UjHidz2B5qtGETHLdqpOYBgYYcPUPjPmhKORQ27PBWI3KXbN8Qwz6YHYU+zeT5Nk28qe6nyk/5JjPly+z5JLLPcLSfH0AtmTKPHWF4Fi/Kd1DdlKUUOwM99yraAMJ0f2ksI+d9IDkG+Dt8sfgoJL22zaDu2+UBde6PviGowVsvPWQNqYNgA6JGMuKwNNQX8lHfow7jf+TzE3p1XtAKcOqPDxjndSFZetkB1LNuKU/6v95Aj9NByESFSJgOBOuy68pwhD7AxOPZnx4piYFJkOpjI/Jo7Huuu5689VXg4XO/+2qlWZoSTRtrS1ahSKjg9mHloe+Luz7Ha7F4dnotanQAnveYTlZy+hbnYFKX2fXhhWOKCKkj44PB4rQmbgGzY+4aDh+ddPmvjJYXGqneLQC3CdnQSwPBsHwv2zblD20Pc+IbDD1DfWjF74HACOMmN2oaOnAZ/AXOtQ6LvjZXXGGmLshPOmHBKof5pydzKizkJBXvy1X98iz2K/Kl/Hn6P3p5W9oCWv3IYyzBa4GiBOyLFTz8BlGehNra0oYnNb80gvWOSq1BiGyR22aLwL 1LWOb2YJ No3WaIEZU1uUtH6jxvJYsoXz3QV8/W2yZQMzstniGhuc30eAvI8Rar8Rp7ukxU4G6HSGhZ6RzrzKx8kvKbJIbB2sSC/Fw1fuwWImczjlcSZn2lruS2SiAjgKalDJ3pq4ZPtZzeKJw+o+Bu3IUEF/uPoAdArwTLWWzeuGi0Gk8tqr/H7622rZuEz+CeU5OMXPSh3eUj3aqFfHg9BpZg9lLk5SKEqC4FU6Pm4D2utVMcTYlBaCfq7Se/HlW9vupisuN7Veqjcvc5xTJL0huwzJ0Q/3BGg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 20, 2024 at 1:49=E2=80=AFPM Yosry Ahmed = wrote: > > Hey folks, > > I was looking at cleaning up the same-filled handling code in zswap, > when it hit me that after the xarray conversion, the only member of > struct zwap_entry that is relevant to same-filled pages is now the > objcg pointer. > > The xarray allows a pointer to be tagged by up to two tags (1 and 3), > so we can completely avoid allocating a zswap_entry for same-filled > pages by storing a tagged objcg pointer directly in the xarray > instead. > > Basically the xarray would then either have a pointer to struct > zswap_entry or struct obj_cgroup, where the latter is tagged as > SAME_FILLED_ONE or SAME_FILLED_ZERO. > > There are two benefits of this: > - Saving some memory (precisely 64 bytes per same-filled entry). > - Further separating handling of same-filled pages from compressed > pages, which results in some nice cleanups (especially in > zswap_store()). It also makes further improvements easier (e.g. > skipping limit checking for same-filled entries). > > The disadvantage is obviously the complexity needed to handle two > different types of pointers in the xarray, although I think with the > correct abstractions this is not a big deal. Another idea is we can make the zero fill zswap entry immutable and share by different pages. That way it does not depend on the xarray pointer tagging. It can share the same code path with existing zero fill page handling. Just don't free the zero fill entry. I want to reserve the zswap xarray tagging for another purpose. Just some food for thought. Might have less complexity because it doesn't need to deal with two different kinds of pointers. Chris