From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EB25C54E58 for ; Fri, 22 Mar 2024 00:41:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 222276B0087; Thu, 21 Mar 2024 20:41:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1AC176B0088; Thu, 21 Mar 2024 20:41:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 04C1E6B0089; Thu, 21 Mar 2024 20:41:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E54856B0087 for ; Thu, 21 Mar 2024 20:41:43 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id AC5BD160975 for ; Fri, 22 Mar 2024 00:41:43 +0000 (UTC) X-FDA: 81922822086.22.4FF7657 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf23.hostedemail.com (Postfix) with ESMTP id 0D16614000E for ; Fri, 22 Mar 2024 00:41:40 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=SaisNmUg; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf23.hostedemail.com: domain of chrisl@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=chrisl@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711068101; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rULrlfNNbO4toVtA/kJZRPn65fH4y/dco0yCxSWokgY=; b=4tDGg71vNBb3dtEEGYSsPE1/Qg33Sal2KJpkmD8zYrJ+ToRN9y0xnv1hq+mtt/Bu78PwI4 1og5JkF/ZQEy9zPdNgNxV2lb4g1t7PyELNJaUcMqcyn4yvKbtPwdJ0rOoHElrok+lbe+yV 3G6K8Uv4JSzQwMrBP/E24hwoje+7zug= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=SaisNmUg; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf23.hostedemail.com: domain of chrisl@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=chrisl@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711068101; a=rsa-sha256; cv=none; b=v30bPzHclfJIkN6heFoW1fQINCUd7fCvNFesWyOrSaeVQdGEs+s/xasdb51Km7EN4eU27A oVg3PdBWbCsFaqfvwraPHU8S1T/SZTiEDagd/encFUClvngmOUQRgwtbiY/5NIQ8R9tvLA r2XEMn1OTwzT4rDGR67L7Zfr4LqzGwM= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 432ECCE1286 for ; Fri, 22 Mar 2024 00:41:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 75D98C43390 for ; Fri, 22 Mar 2024 00:41:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711068096; bh=UH+4ywsql5/vQaJCNVmGGH/4GxhNtUwh9xnmpT32IxU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=SaisNmUgBsMs79qSLQPh0egDdyqI0icXbBoOH4Hxnb7gpyIAmJco4NRzCf+L+5j1y ad70brPIgO2uxEPdWH0A46rWPYgEj7T4TqU4qdOLl3dFoDE52XYm/CBfvWnM7k5HoY odM3Q4plzH03XpoVROgoYi2w7KV64s7HOQTMy/YyXEvk2qyjtryBaFWwXyZw/Bn/TQ 8I4uQb3y9FuyxB1EHfX5K0vG2T3qblx1uB9YDhbWKCU8HCywtliMCF3rV+vKecK6pT tXa8VdWzt3SKDbhnDv8i6o8sRh2yEUZpc1DI7aIbJfj07ZVS1dN2AZ1Dw9BJPwwIRa DEWsCP0QRcxDg== Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-2d47a92cfefso19852511fa.1 for ; Thu, 21 Mar 2024 17:41:36 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCUYR4hnROqYAiwTbRxYg98S7VjbOSvfiz3/SBdVF/pxedACIwaW1O3I9Z+mbQTRWs7LUxZ/L58D1uXXtTK9FvvH70Q= X-Gm-Message-State: AOJu0Yy3asKGyPW1k5FCL71LrQLEIMVUsRaNhDk6QHIwrJaHT9YqR3XN HCjNpjfgs4CSFms43ZzYUZgtWwOUFfCo58TBlc8qc5KKmMdliPXd68ZhJVjzAEVZ24GorldNIuK 92la8qbY5D1lTUUjGP5c8XOaZeg== X-Google-Smtp-Source: AGHT+IGGWjaY9cfNeIvOIRdpQr+qInr9/bOKNfk7UJKEEU3pIig/YFIE259HZrZQ6V+sQXZ6yoFf7ZDCGv03EvrUfqo= X-Received: by 2002:a05:651c:1037:b0:2d4:5c0c:77db with SMTP id w23-20020a05651c103700b002d45c0c77dbmr653235ljm.3.1711068095191; Thu, 21 Mar 2024 17:41:35 -0700 (PDT) MIME-Version: 1.0 References: <20240321-zswap-fill-v1-1-b6180dbf7c27@kernel.org> In-Reply-To: From: Chris Li Date: Thu, 21 Mar 2024 17:41:23 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] zswap: initialize entry->pool on same filled entry To: Yosry Ahmed Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Nhat Pham , Johannes Weiner , Chengming Zhou Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: tcasutsbur6kg1mnmewcy4abyui8n7fm X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 0D16614000E X-HE-Tag: 1711068100-332968 X-HE-Meta: U2FsdGVkX193hqp4wtXF3RbDDZlxMEVLZIqCNB+DA4iguLJ8jX6X9umosZHnKt8s738wG36uxK1f1W0FzpM2Jadywe26dCkb/pSukwhUtUgTE+MA/hV1qXo3YbMR9rz2wJgTl8G313dUovCz50p4ffryWyF5kfWxw/W8xV2J/ybwgGjH0eXEyzsuUZMCyhshbuMTfPxIiEhOha3sZ5pKBZ5HVLINzZL9/P5v5LC01C5tj1RHOBzFKLnFlrZ9HIuM7fxEvbf+Ch3SgmKQtWaw13Xb9Gq/c69g0/RUqj47yu6IdIugndhU8nESubCHHRNYEszwO7m87oX0ghzAvsk+g+YV2/Q/zrKa7vaOXHm0FcMaRD+ODpCfch3Yb89AkfRgO/6t6zWyAOVapfoGlqjmEgDx0eQIPYzKH5nSX2zxKCwD2xdR9M2Z60+Qa0856Y+SBnWZjpVuzcGyonLb0KD+S0r8Nv2xjjhVse32MQhrxoeK5j36ZKGTmNENZUJpA6bvc4HPL/UlUO97sTSCXBPMfP91Ilv1tPaOecKG4+WYCL3kSTx84FPdGxrU2H2rqSep86Jhqz/HlTNPc3kZG/8w/06on3t0t7EsEqqypd0QL6ktmv22cyxFk9e57DPHgtp3/+6uUTt6OBarWfZ7x0YvIZKPecDZQqpRybU63UEOk4FVnbATVLZ8GePh5u9wKEEakC56T4Qu5PTQvfkp+Ye0v10yTOz2VUFXp9o5s43sCl7Mhcl9tfPFY6M8SvurlQ+Ji7eRCUuWLwYTNbhXN0nmeHMiqvqp+OL2X7NHgYs5wZKFzeJJzAroevd1Z/Bouc+X2ecbs7UehOZ+cPTYoNlrG1hG13zbkoY9IfvxgW7E8B8u+Gcz62fBwY7aSptuCseACoxq1C1KAkJg6l4PcbZkQ0vmye7QYDpIvy/ECMgXv1soT2mSjK/RaFXTlzzYPvMqVM+UQQy50wWa83N1ZJE vkTlcw2k lRDcly8IQHnys2/H6qWRC0WmM+6KVmKN/KJIpNbtWUlrbkPnKkkNQ0Okh86UTQP6C9C3mlvGRTTG767Iy3E281EVZUOSO0WaJVJ+vZK4T4RSXo2N4pw9qD2rtPwuroCCm5nIT2sqgXq4F0mj9AKqV4f0GgsQvobyORJkTsJP9Iuok9GrXCkIY/ebOFzMrT7otBQE7iqqaqwH547uCBh/fbOAJsiULK66M3iBho29bwCiOTjYI/jirBoQhCzEOTgvIFEEbwIXSQF+KFptakaThdW1liUaEabCmHdw7cQ5fa3N82QQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 21, 2024 at 4:56=E2=80=AFPM Yosry Ahmed = wrote: > > On Thu, Mar 21, 2024 at 4:53=E2=80=AFPM Chris Li wrot= e: > > > > Current zswap will leave the entry->pool uninitialized if > > the page is same filled. The entry->pool pointer can > > contain data written by previous usage. > > > > Initialize entry->pool to zero for the same filled zswap entry. > > > > Signed-off-by: Chris Li > > --- > > Per Yosry's suggestion to split out this clean up > > from the zxwap rb tree to xarray patch. > > > > https://lore.kernel.org/all/ZemDuW25YxjqAjm-@google.com/ > > --- > > mm/zswap.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/mm/zswap.c b/mm/zswap.c > > index b31c977f53e9..f04a75a36236 100644 > > --- a/mm/zswap.c > > +++ b/mm/zswap.c > > @@ -1527,6 +1527,7 @@ bool zswap_store(struct folio *folio) > > kunmap_local(src); > > entry->length =3D 0; > > entry->value =3D value; > > + entry->pool =3D 0; > > This should be NULL. > > That being said, I am working on a series that should make non-filled > entries not use a zswap_entry at all. So I think this cleanup is > unnecessary, especially that it is documented in the definition of > struct zswap_entry that entry->pool is invalid for same-filled > entries. It does not really hurt to initialize it. It is obviously correct if we initialize it as well. One thing to consider is that, this pointer can contain user space data if the page previously was map to user space. Kdump typically doesn't save user space data. This uninitialized value might let kdump contain user space data. Chris > > > atomic_inc(&zswap_same_filled_pages); > > goto insert_entry; > > } > > > > --- > > base-commit: a824831a082f1d8f9b51a4c0598e633d38555fcf > > change-id: 20240315-zswap-fill-f65f44574760 > > > > Best regards, > > -- > > Chris Li > >