From: Chris Li <chrisl@kernel.org>
To: Yosry Ahmed <yosryahmed@google.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Nhat Pham <nphamcs@gmail.com>,
Chengming Zhou <chengming.zhou@linux.dev>,
Linux-MM <linux-mm@kvack.org>
Subject: Re: [RFC] Storing same-filled pages without a zswap_entry
Date: Thu, 21 Mar 2024 17:18:32 -0700 [thread overview]
Message-ID: <CANeU7QmCrzKJTAxhTk+VWtUstaUr+Lx4ghyDYm0ePHjTgNLihw@mail.gmail.com> (raw)
In-Reply-To: <ZfyBWSTrc5t0xHuy@google.com>
On Thu, Mar 21, 2024 at 11:50 AM Yosry Ahmed <yosryahmed@google.com> wrote:
>
> On Wed, Mar 20, 2024 at 09:26:43PM -0700, Chris Li wrote:
>
> >
> > Another idea is we can make the zero fill zswap entry immutable and
> > share by different pages. That way it does not depend on the xarray
> > pointer tagging. It can share the same code path with existing zero
> > fill page handling. Just don't free the zero fill entry.
>
> The only relevant item in zswap_entry for same-filled pages is objcg.
> That cannot be shared by different pages anyway. So basically the
Ah, good points about the objcg can't be shared.
Chris
prev parent reply other threads:[~2024-03-22 0:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-20 20:49 Yosry Ahmed
2024-03-20 21:07 ` Johannes Weiner
2024-03-20 21:14 ` Yosry Ahmed
2024-03-20 21:19 ` Johannes Weiner
2024-03-20 21:31 ` Yosry Ahmed
2024-03-21 3:40 ` Chengming Zhou
2024-03-21 18:44 ` Yosry Ahmed
2024-03-21 19:29 ` Johannes Weiner
2024-03-21 19:57 ` Yosry Ahmed
2024-03-22 0:28 ` Chris Li
2024-03-22 0:37 ` Yosry Ahmed
2024-03-20 21:42 ` Chris Li
2024-03-21 4:26 ` Chris Li
2024-03-21 18:50 ` Yosry Ahmed
2024-03-22 0:18 ` Chris Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANeU7QmCrzKJTAxhTk+VWtUstaUr+Lx4ghyDYm0ePHjTgNLihw@mail.gmail.com \
--to=chrisl@kernel.org \
--cc=chengming.zhou@linux.dev \
--cc=hannes@cmpxchg.org \
--cc=linux-mm@kvack.org \
--cc=nphamcs@gmail.com \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox