From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93B9CC6FD1F for ; Fri, 22 Mar 2024 00:29:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 12B576B0088; Thu, 21 Mar 2024 20:29:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0B5B36B0089; Thu, 21 Mar 2024 20:29:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E97A26B008C; Thu, 21 Mar 2024 20:29:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D775F6B0088 for ; Thu, 21 Mar 2024 20:29:11 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4A33B1402DD for ; Fri, 22 Mar 2024 00:29:11 +0000 (UTC) X-FDA: 81922790502.30.4EBDA7A Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf29.hostedemail.com (Postfix) with ESMTP id 4A41812000C for ; Fri, 22 Mar 2024 00:29:08 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lYIifZ6w; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf29.hostedemail.com: domain of chrisl@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=chrisl@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711067348; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uYxeWE8N12gkY/TAsjmFaAHfr6tgRc1GKnLRASlwNZE=; b=ACuQPbYdtDWUQ1YcmI3s6yudzdIjNoeJnHiZOD1x/N4ID1F7iv9YW+0bBaVOKmV1X01d4J LGRHLSkfBz7fGB7zXT6qFYeC4dRFYuOiP6DYhVfpNjY9w7kVlZjt+Co1QSNLTAGofLvJlC fGrK9cCxJyhZOlJni1h9LDIsl0kso7g= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lYIifZ6w; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf29.hostedemail.com: domain of chrisl@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=chrisl@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711067348; a=rsa-sha256; cv=none; b=UKduQqZqnmpJy3shWFjvSlQZFGcPdOX3Zu8b66IR/FfhZbtOEOHY+4r9AzB9eLL3IPm3wA AfJUaNQvRmkjMwhmKxkqjgBooeT7ySlMRdbZrH1uQInHRgEKv4IPDNdflMZwfFEBCuUNDp A4ZlLIg763GNdEwlkRaAQ9bXk1lBRfk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 43ED16132F for ; Fri, 22 Mar 2024 00:29:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DDECFC43141 for ; Fri, 22 Mar 2024 00:29:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711067346; bh=uYxeWE8N12gkY/TAsjmFaAHfr6tgRc1GKnLRASlwNZE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=lYIifZ6wfG1qe5EcRhIk0fMgCcWLRZVSmnC+OKTg0d7Btf/zHfb3862N+x6PDnXzH OuwB/uOtEc4jVnV1qzVz9rRQ0x5qxxFoaAaHQiFspXJF20h3nmVFAGYcBGxzCxOj8y 0vvQ60NNT1DKYCSY58veQ9By3N/Bfd+phKP4FsvfpW7ZJdhOTr1eCvelV08Kj7CzA2 HvT104GOtA/J8qG08v/HfSkw2xOiEnzyUOl+dpIICBI17YCK+Rq15UVCfW4MreAsD0 MhVxB6RHCF+OwqBS+XPPq55OvS2lMHJ4DMHJzwwgD9/CyRnG/WClTCppbmLxnxwcf6 VZXSnIVbpbd/w== Received: by mail-lj1-f169.google.com with SMTP id 38308e7fff4ca-2d41d1bedc9so29539141fa.3 for ; Thu, 21 Mar 2024 17:29:06 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCVDcMwhGGI4ZFVf3ZUJBJdhEhJcU002TgsP/vwEJ0k3bySbZDivCCz7hSaiV1HikpkmiP2/UAAI3decvhNxpSDUb9U= X-Gm-Message-State: AOJu0YzbNBliz/B2fuPJ+VEvhmwQn74EFH8Enn05YxUqjy++Ke4NL4it +fSz7ndcjCnXyLWOeUh3oeWp9lXzHiyqfUwrkkDpH1pOKMBkGjJHEFZqBkb0Ddiz6SRE8+02FnG e+4ylvQPqRFR4GbmE9IxPFb8qVA== X-Google-Smtp-Source: AGHT+IGLyqZfAKNcDMy6nuWHMVpUZR+Uc3s2OscfSge2BBoONVmS9BXnX8sOmhrL/DHz9xbu1it8uWEQ/amtwx17Unc= X-Received: by 2002:a2e:9614:0:b0:2d4:7455:89f6 with SMTP id v20-20020a2e9614000000b002d4745589f6mr745040ljh.40.1711067345528; Thu, 21 Mar 2024 17:29:05 -0700 (PDT) MIME-Version: 1.0 References: <20240320210716.GH294822@cmpxchg.org> <20240320211945.GI294822@cmpxchg.org> <7d7b755a-e13e-4267-b1b5-a4e2ff33d6e0@linux.dev> <20240321192912.GB3154@cmpxchg.org> In-Reply-To: From: Chris Li Date: Thu, 21 Mar 2024 17:28:54 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC] Storing same-filled pages without a zswap_entry To: Yosry Ahmed Cc: Johannes Weiner , Chengming Zhou , Nhat Pham , Linux-MM Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: g3jn4nx76ozm3wxz65oc3hbzu86an5s4 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 4A41812000C X-HE-Tag: 1711067348-506460 X-HE-Meta: U2FsdGVkX18s3JEdR3YIIJycKuNi2A7U0lC4acfoRCbm7ADRvcb/FPW/UHuHUM6CgbGsCSOHhxnBhdjA0noEQHQ8aQjVdoAcfa4e4J7S+dBFAqw8UBOgfeJgYq9m2aU7K0TAjR3eAsCX0cXh2bboi/HdHylVplghVrsvyzWhYWlIASStnRoggd1DRCbgOSt1gUfheDiN8IB2NsI25bkz5K9del1/faBsxgC3XcU/CgF7yBdT3po9OoHKHf2yiicvqlkZlY3suuBZiJC+nFrAHPSdMWHzwZ4PblhcFMKJFj0uqkA3R+GxGgjZ8Ge/4bP632rMpeNV94yrEZWL4eOZDFrxvxVxT4MKXLxZA9iIwPxvactnkH1tl43wun7c8UdPQLqs1oqSmuHlWHUlcoqw29iIXhHEVVJltTvcHBJb95JI//iCbRqVKSHc9WgxH4Y1wiYa/YEtuw3mUunxFOzxMfltSv1Wrs957r00yvEgBU28rvjYQrrRXODRv591VPWaJdQLBqKEbiNrZx6SoG4/+PHrIUv9EdyC/9XLa+X9xsFEL8DJiJbfP6wVyTf9d6NsoxpRB2RMo6iCSlBMzNK5wBhLW3VOm4heTRk04nafslarQo13LZpVm0Zy4Xn4EkEwHrCpv7sbEpkggjjJoS4N/oJTQNUuTx7vn/RLoO8hOKHVxWY6ucXZHBg+b4f5tAHq0HdxH+GPvJbCRi6l6ZgCsQGT3gM24QDglib/bVqpo/1qHGt6yW+pwRaaxhykcPc8XoQyahtucm3iyn84TXxha4IOQyxsb/Qq1yAZo2I/DGeMCfzpmNvm167WYMO2Kxx94P3jcvK7o0Ma8OolsHVYVhvHfYUV5fRlZaGZnC0lK1X+iV90JylLmtk6Cnprm89JdCsfzhNBKNrfP7MZAFdOPkSsRjaPel+vAmDDCge4MKW79j/KQsgbJ7zMQKF5wryJOyoj2XkKJErCKMVjB/a J9OQwt/w W1KmdbdyMpfmi04WO/tF6+PEMDPLLbjq3TIkTXm1/zuUsQves0Ba/cyZaYF7YEnS/pAqgft7tdqqUQFDXOF2FkYbmTiHUByH9Yekd9jBJHVg2oMu8s+vetAhONoNLNoZMq4hX7KKV0dEu5Xl3Fyp/FqyADxIUKVxbv1YJUEl+A6udDQd0bJULQ91a+7CWX30xR8CaKix/kEvMVTABQlQxqxyVWpAWPoqkqd0l1KOIIaKM9OS5+wZQDqCUaeaPOnIOhRevT7mCGPSWHDerPwtNJALI7GuhbzRntPusBhIydxGUisSW+YGCLDRG03LGoTDjOnApFCPCv9IVrDb+TZXnZkFaMw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 21, 2024 at 12:58=E2=80=AFPM Yosry Ahmed wrote: > > On Thu, Mar 21, 2024 at 12:29=E2=80=AFPM Johannes Weiner wrote: > > > > On Thu, Mar 21, 2024 at 06:44:54PM +0000, Yosry Ahmed wrote: > > > > In some cases where the current objcg is not "correct", the testcas= es in > > > > test_zswap.c may break? Maybe we can use swap_cgroup info to charge= the > > > > stats to the correct memcg? Not sure if this is feasible. > > > > > > For cgroup v1, swap_cgroup will be cleared from > > > mem_cgroup_swapin_uncharge_swap() before the zswap load. > > > > > > I think the current objcg will remain correct as long as swapin happe= ns > > > from the same memcg as swapout (or if swapin happens from the parent > > > memcg and the swapout memcg was offlined). > > > > Swap readahead will pull in physically adjacent entries that may > > belong to somebody unrelated. > > Right. For those as well the current objcg would be correct if they > are readahead from the same memcg as the one they were swapped out > from, but I understand your point that readahead makes that more > likely to not be the case. > > I am slightly nervous about using the current objcg tbh, even though > it only affects the stats. It's just less straightforward this way. I > think I prefer either: > (a) Only supporting zero-filled pages and storing the objcg directly > in the xarray. We can add the zero-filled page as a special case to speed it up. I don't think we should remove non zero values of the same fill pages from zswap though. We can never declare the non zero same filled page is not going to happen. In that case, the current same fill is still better than going through the zsmalloc. Chris > (b) Having a separate two-word struct to store objcg and value for > same-filled pages. > > In both cases, we would need one tag bit to identify same-filled pages > in the xarray. (a) is more tempting for me, but I am not sure everyone > else agrees with dropping support for non-zero same-filled pages.