From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 093CFC6FD1F for ; Wed, 20 Mar 2024 19:42:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B8EB6B0087; Wed, 20 Mar 2024 15:42:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 769236B008C; Wed, 20 Mar 2024 15:42:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 60A536B0095; Wed, 20 Mar 2024 15:42:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4DB2D6B0087 for ; Wed, 20 Mar 2024 15:42:09 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 2940DA1381 for ; Wed, 20 Mar 2024 19:42:09 +0000 (UTC) X-FDA: 81918438378.18.B2D9C43 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf12.hostedemail.com (Postfix) with ESMTP id B460740016 for ; Wed, 20 Mar 2024 19:42:06 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=B2Fc3H+J; spf=pass (imf12.hostedemail.com: domain of chrisl@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=chrisl@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710963727; a=rsa-sha256; cv=none; b=Z0eX46eAEivyylOI7WmtgvK94qlXXbk8B7fEqhWSCxD10+03V/Y7/xgDOR8Z2gUeSHOn8G h9wxRVUlb0RpIFHV7/08/35gLSn3bMUSftTkuLF6UROa0lc/4V9T4sqxH/FAuXHvw5Q+Rh o9OXw0y7O0FdhZq3vx7WtOJle15CKjM= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=B2Fc3H+J; spf=pass (imf12.hostedemail.com: domain of chrisl@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=chrisl@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710963727; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=w5Yuh9BjXp5GoGMUuDtJBbyXbQeDSwEhm62Pk+ikl2M=; b=oOjlmBp4jFJcBgADgIGIfhufSljEqrmT5B2nlQ5E2OOhehkGglmvMOHwAb/UqdjINalm/B hm4Dthh5YC+mqAs+SBmDXMqDxIdUtpdvJ96xUoYKZavmsb2zCiZNh2O31WZpSxYvN55sMy 23FZoiUTKSpBZApEHAyaYNo5oTOTQAo= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 5DCE6CE1251 for ; Wed, 20 Mar 2024 19:42:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DD7F7C43330 for ; Wed, 20 Mar 2024 19:42:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710963721; bh=w5Yuh9BjXp5GoGMUuDtJBbyXbQeDSwEhm62Pk+ikl2M=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=B2Fc3H+JI069j5/n3AEGv4loJnpcmwuGOkRsr07w/GXrXu4bZOdQVKk/P/UU/Kp9B lDUkMk6Lp110B590dZ3vyefynuj8cDOWkDO+eHGdR3fo1WbN8Us3P+iK4kycU26O8h d6LYf7vn+3wvm/DJkNFmETNAWDGmObhomjp9GFktypi6ZEoiR7v0IB1PKwBgEX0sO+ SHdUkooG3pG5BL2FlUO7FPY6L0yEfLH8RFHOWRTktD4UXYQ7/4hODxz+ft+jr+uABP 8D6LSTe2knqVbUq8yAYyP0FoKy9LqiAZSjwxeSlZaX355FE+TNzi6HVNa8zY/tJFi+ prYCrtQ9EoCmQ== Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-2d46dd8b0b8so3123891fa.2 for ; Wed, 20 Mar 2024 12:42:01 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCX4yDscT6oD/OZNht4hA0TMDhJsw7agGfZFuV9Pp7UkBqQl3W0RWlfBOzo0ogN1w+JPjHwtNJRrtQViUrYHh3xo2uI= X-Gm-Message-State: AOJu0Yyi8DoR2dqftFbDjDWnP+bM4yZcX3MWAMxmpJz/8Cli6x2IT1eu 8jclGPboRAjRGTup9shNvhV6BrsZcFcxV5nCPPnmAEGWJtVmNlE8WAjFeoC7Uj5VcUEoR3P1bhx v9Sz9/BlkIM+OWh4EhIZak+xRAA== X-Google-Smtp-Source: AGHT+IEuEA/Ge7xSFr+tZYv3Qh9H+zVKCOSSZILoz1pxl5dhujyttD81clYU9kygGRZj2V94JF/mXjdXwkpmowv9gZw= X-Received: by 2002:a05:651c:820:b0:2d4:7532:92f2 with SMTP id r32-20020a05651c082000b002d4753292f2mr10587672ljb.45.1710963720595; Wed, 20 Mar 2024 12:42:00 -0700 (PDT) MIME-Version: 1.0 References: <20240319-zswap-xarray-v7-1-e9a03a049e86@kernel.org> <20240320100803.GB294822@cmpxchg.org> <20240320192558.GF294822@cmpxchg.org> In-Reply-To: From: Chris Li Date: Wed, 20 Mar 2024 12:41:48 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v7] zswap: replace RB tree with xarray To: Yosry Ahmed Cc: Johannes Weiner , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Nhat Pham , "Matthew Wilcox (Oracle)" , Chengming Zhou , Barry Song Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: B460740016 X-Stat-Signature: s1kkspqau6osf5a1unee9gesso8kjkas X-Rspam-User: X-HE-Tag: 1710963726-918782 X-HE-Meta: U2FsdGVkX1/yeSk6sJ5MczJEtg5Hp4sqpklh572CH+J/PgYIp4dL3/RX5TaTFTE8NfWLVhNDZgTCVyL9S7Se9gxWh2Taj/VrI3EUr/jQ5RASv3pTQsLT683Huq3hZ/dBnHp+J50IkOLoHi0uhV9sF417q8A9dTlkE/s2MuR6EyCYSIQpadfcvoO0U1lgCPoFd6sn4rs79cE1vNXQAPc2rvbY8gTXMQ50Pnms2tCgtPxeukA9GsqxkvCejYlAY0aHN4eKinhWlUwElJzQ4vJOHDdTxkwwX/HVP1u2o7cUvnqxHE1zwbhGJF/P+yqQFh0geEGHwAeWvVyFiE623FrfZohrYxSUsV0Y6mERKZwIx8bVea0h+Xm3T8uC7LM6E/Nx+XYg5r6Wh4H5OKtL7WcpeRDb+ZGhmaMgjyLphrCPCHTiv5JK7IUMayKHOwnRzgnazhyCQdZvcEHBctVGxK98NnVmeHpKUvT4dYqT1Bg54UJbrWaTH743kY2+DodOQeecZjODnfPwicQtuPbYmvplo6xbaBAeB5mK3yaAVZDGnijLwo0fGRT3+/Vlc0NLKvvk7oUQbTcOAEuLmcFsSxzA0zNpuywIW1Z95mdzFFc/YSyK/re2WyzpcvQRJbKM6wHbhrztWu1f2l0zQaBUSd2k01oWG21MtI9BBlUjnVEmHllw2MdXP/ejTpVsy/V+Iqa2fmUQG3iKiXSXJs1La9DId2RysWSxw/AGEgC5BuudBl351GbUkTEwzBFBPl3v6l00Dej7nrR4IOHLVwIKeFsTdjHXBfiZL4tCOPNddAO/H+yR6+oBBIWl4KaYSBSMXcR90yHXPWgSbJFOMuhprN27ma6MI3+bfACBuUdG4jo0xVIGvT2okK9MI1A2CibxCGkiySxYtMoiLJ+t6q+zYUwDzcTHmgsRK/p7L1G4Jz9/oGFOKVFW7VxU8jIIpNYjB6+LJBp2nB37xV7HzXURdG6 +Ts9O2hi rs6I9e7miS3U1ct3b49i77NJSvYfhkJ5DhmpTTz2rasSkZ/ohEg/IAB7aLfJZfdlj7X8Lj8lB8FAJKBolv6K5Xs0ffZBTGTMm187MH7sN+o5o8cKyUGwlhwHcLtvm8i+Dq4ZvQUblYfnZuQ0nKmNFt9zkwb7wol3FsF6FVPL4m2JbMZ45+6KKEHX+GRYjCVCvlkShdcyX47AJ8DX7sLPdy7SneJNyZqzdSOrhgXui1UhwW/Q= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000261, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 20, 2024 at 12:34=E2=80=AFPM Yosry Ahmed wrote: > > you can expect it to be coherent. > > Fair enough, but don't we still need a barrier there? Couldn't some > initializations still be reorder after zswap_lru_add()? I am under the impression that the lru list handling function already handles the barrier. If an explicit barrier is needed, wouldn't all other lru callers have barriers sprinkling all over the place? Chris