From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70C69EB64DD for ; Tue, 11 Jul 2023 19:42:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CCBCC6B0071; Tue, 11 Jul 2023 15:42:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C7C076B0072; Tue, 11 Jul 2023 15:42:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B1CD76B0075; Tue, 11 Jul 2023 15:42:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 9EFA56B0071 for ; Tue, 11 Jul 2023 15:42:58 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 5F70F1C7DBB for ; Tue, 11 Jul 2023 19:42:58 +0000 (UTC) X-FDA: 81000354036.16.3E92767 Received: from mail-vk1-f177.google.com (mail-vk1-f177.google.com [209.85.221.177]) by imf22.hostedemail.com (Postfix) with ESMTP id 8297FC000D for ; Tue, 11 Jul 2023 19:42:56 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=WCXxjiX3; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of avagin@gmail.com designates 209.85.221.177 as permitted sender) smtp.mailfrom=avagin@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689104576; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dqxaqXmw1tu3QWdtuOVOPVnF0rhjoVkY2FJ4msGP/FE=; b=46EhQZ9V8I4JD43TvcfJ7k0YlBVdsjeC/igrvo/5WOKTygpTL6DUvA1dvQd1bDT4/G2ELZ nHr8j4Iaqf5l4yEIL6yf/M1rPd0J8V3w5rzbYk17DnFUU97ojqIdM15/vKhox58M5bcGsb CSoDiRCfVQxMdhHsl0nlHwKG1MZ9rDw= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=WCXxjiX3; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of avagin@gmail.com designates 209.85.221.177 as permitted sender) smtp.mailfrom=avagin@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689104576; a=rsa-sha256; cv=none; b=S1Pz0QrREJaiPTtWHTdNJtUH4bSOSH9h5iGmo64/0SmHJrPlc/jhzijSMOrr2yK6GT89rm Kx9sA45XEaaessu81MoPCrNoBgpJ/kh8Nj+nr/OW28atiTvD09enzZ/84ROJ1aMOnCcmCS 4/W8POW8VOkIPwxWZQTPaU8sZuMomHQ= Received: by mail-vk1-f177.google.com with SMTP id 71dfb90a1353d-47e25709402so2341988e0c.0 for ; Tue, 11 Jul 2023 12:42:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689104575; x=1691696575; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=dqxaqXmw1tu3QWdtuOVOPVnF0rhjoVkY2FJ4msGP/FE=; b=WCXxjiX35VIFpR0nhf5xN1cKqwvEe0aVJDmIXwy5y293z47OG3Hx8HJlUrAFw/hjFN pOr8FVTMdX0qwE6i7UKoJ1bVn+fqYysno/V/wnLgh3aFLVP7TKFvo/5IyX+FG3nEX16+ OBFdpHvbfxXtTQjgmUngDLNjEL3u4KZnbVOntpXvaVf3OpH19Zex/xseSnpZAwbay+yL thSo1fZ6zUGGJ4TDftaPNHW5df4OCCTf/o+J5S5lRPYdBfJeRceJdqr0mU4KAD4eO7rr GmwZbjcRsrAqUpmh5C2uVP4CA74PUA/Silw7HAREHHV7vWJTbneD0/BHcOgkaYlVISEv STvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689104575; x=1691696575; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dqxaqXmw1tu3QWdtuOVOPVnF0rhjoVkY2FJ4msGP/FE=; b=QYNMT0EAawUxF1HuZUNW23Xd//FrYjmWCZTvNLNGMgrXrGpqKB+IrqCkQcM846MYZU oxOk6q9/xZS10Pze+VUUCilxNvUEMoOMe1cIuzx1WuiCAWvWf0kcA+lxzBUcgEwtSdDy 87DdACcJXPxUY3uOGUV/mrhe3i8PdajlZx19uaWiZ6rBx395ZiNybfLBJZhNX7HlYu9D B2cUqUaGLY9rppfuTjSGl1kJ4iHtD3EOdHAPeGYOryqtAN74Z8vFbJamNS1DV22bsq1j /3Dn98uA3wH+2zdpy3UHDfWzeiMVFbImvULLoeS17A2YbPmh7aJ7EUmEpvrE9Iic6uxT yVXg== X-Gm-Message-State: ABy/qLah+S+SRa4hwdiv2roKeyP5SPP7YBuzAPzZQfVzSy0KpD9eI1Hk aYMTrGi+RufhavlnNF6OY9eglT8R4ZhjxK3wQOE= X-Google-Smtp-Source: APBJJlFESZwse+XBzfdEG7gPgKtm+dr9PqBvDRHkx0QyDpPtucriutBokoi6nHj9mpK7MC+ZT1zx1fvPJQ5h6dotD6o= X-Received: by 2002:a1f:5842:0:b0:476:3544:773 with SMTP id m63-20020a1f5842000000b0047635440773mr8354569vkb.11.1689104575315; Tue, 11 Jul 2023 12:42:55 -0700 (PDT) MIME-Version: 1.0 References: <20230711125241.1587820-1-usama.anjum@collabora.com> <20230711125241.1587820-3-usama.anjum@collabora.com> In-Reply-To: <20230711125241.1587820-3-usama.anjum@collabora.com> From: Andrei Vagin Date: Tue, 11 Jul 2023 12:42:44 -0700 Message-ID: Subject: Re: [PATCH v24 2/5] fs/proc/task_mmu: Implement IOCTL to get and optionally clear info about PTEs To: Muhammad Usama Anjum Cc: Peter Xu , David Hildenbrand , Andrew Morton , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Danylo Mocherniuk , Paul Gofman , Cyrill Gorcunov , Mike Rapoport , Nadav Amit , Alexander Viro , Shuah Khan , Christian Brauner , Yang Shi , Vlastimil Babka , "Liam R . Howlett" , Yun Zhou , Suren Baghdasaryan , Alex Sierra , Matthew Wilcox , Pasha Tatashin , Axel Rasmussen , "Gustavo A . R . Silva" , Dan Williams , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Greg KH , kernel@collabora.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 8297FC000D X-Stat-Signature: 7pjj7wuentr4tdfqjipss7yb6y6t399t X-Rspam-User: X-HE-Tag: 1689104576-497125 X-HE-Meta: U2FsdGVkX19uQRUXrFZc6WU6qXE0/Ay3smzDTC7J2IVzErZF/TL8w8N+yGktVOttGfarf/qQpeuU/xzSGyW7Apym9RqcXYIoHlIJ/DelId8oYE53XnLzpI6MtmZPGW/lOP2hBXgsl7fLZlC0ECGd2OLPNof8eDC7/wVDwnGKS8uTlRa+Kuu3ho0ju26/mb6EWJ1hceg8ge4j3SKc2Lcv82jxbXMVt8xqVd8UfWdtZ1oxVvh99SkpcG9Kyy+olNHbiVdS4pkCIzNUUiu+vmYPuY5wSH7cEWpNScHpf0QEj/5EJk5Ho5F3QuJWa7BTMdBsQZysbjc1frsP9VxXpBt2rxr4XDSxYmA8UPiQY9a6iqaSeB8lf/pHSNjfqVo5qXmqNh0vF9eVFoUwjJ/4jqGI88tAberNBhLor6ox3wM9NhugJp+MAnQwFnsI2jA2Ua9Ok1ggSYsvp6WVFhBCrhvAad1OauBpAn6WumZRyijwaWAKKDz7dXXIWdkiOMRqtX5ZPMpwtl4GH1kxDj8dZgLpWgOyCDbJO3UETSI90EmoVD1WzlCF74/L5gU/fiJojD28F2B9zTFu9vb/orUnbviXKXn3P4qHWhhq0FQb+O1rFj6oJj4nha9AvvJcFihfUmVjSV7o8Y+FrY0K0D4NRa8wMRyeLNxEgAo/X0H1NFrEiaKs4MR7WtemMnfi2u8pwhs6M4p9XIJUvhS4PFi22Cn2+uHAaSKDZOyM3Or1mUoeX6lZMFrFVNaIFeqs4yzOdcPh+QVsxk3aHp5kqZQej+nEho9Zt/WemLfaWQqqu4EAs6kmu/apBIsL0c+/rYkSLUhLYpCjH88jFFdAOncebninZyEiWsE70GOMsU7iTFbBkjpVWM4WV6YM4RLar8G5zc96ewKU7uvzkY+mH7bJ8MIsiQrXqzGRATBvL8VZ0HdDFc/XFfQYBEDownAefGsmLBib6yimu0RLeOAlkFwGg8W e12tSB0D YNb7qb2ErCudxpOh/riv0fD4ROJ6VxuZacaN+rK7DooFvPaKf5nCuVeh154TG59cSCpvZW9fl9dP3D8mMWEwMmIwEu9Zwfy86SHgzfvCs/VB5VoSRClKFZSIVDdqU1V5IDclNQz62aJFSzsQz5TNgEnMF6l5N4b1JeZidUAY6BWipwhklBA+hGVBnbkSHmsSKkB7ZZh8JwTNi+xdnv32YUXh4sEFRa47FZAkqlgs/xFZvbxat4U9YJRVrDNykcxbJTUNhNbqKM6SqJjm1xFAlx9Mw+C/8gZNYRt4CFknhx2K+7pZL0Xhob0DsUHT9ZS7qYu3bmswKo3uzUJCp3F4QD5uENH0HsOIkcu1xjwoSdjzUlaBzSQwmRzuGfbphNBjNdIPe7OSRMlTY9JtYQCSCkiOfMDighm4dqQHCht1EJgRZ1IeMnEVZMD4rctkcM4fqPiKrnizB8gxDIIpAAVNS21uohw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jul 11, 2023 at 5:53=E2=80=AFAM Muhammad Usama Anjum wrote: > +static int pagemap_scan_pte_hole(unsigned long addr, unsigned long end, > + int depth, struct mm_walk *walk) > +{ > + unsigned long n_pages =3D (end - addr)/PAGE_SIZE; > + struct pagemap_scan_private *p =3D walk->private; > + struct vm_area_struct *vma =3D walk->vma; > + int ret =3D 0; > + > + if (!vma) > + return 0; > + > + if (IS_PM_SCAN_GET(p->flags)) { > + if (n_pages > p->max_pages - p->found_pages) > + n_pages =3D p->max_pages - p->found_pages; > + > + ret =3D pagemap_scan_output(PM_SCAN_FLAGS(false, false, f= alse, > + false, false), p, addr, n_pages= ); Why do we report holes unconditionally? > + } > + > + if (IS_PM_SCAN_WP(p->flags) && > + uffd_wp_range(vma, addr, end - addr, true) < 0) > + ret =3D -EINVAL; > + > + return ret; > +} Thanks, Andrei