From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82128C6FD1D for ; Mon, 20 Mar 2023 18:30:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E40886B0078; Mon, 20 Mar 2023 14:30:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DEFAD6B007D; Mon, 20 Mar 2023 14:30:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CB8506B007E; Mon, 20 Mar 2023 14:30:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B87696B0078 for ; Mon, 20 Mar 2023 14:30:16 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8608BC0968 for ; Mon, 20 Mar 2023 18:30:16 +0000 (UTC) X-FDA: 80590116432.24.B368D31 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by imf08.hostedemail.com (Postfix) with ESMTP id 81D72160024 for ; Mon, 20 Mar 2023 18:30:13 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=oA4w6+dD; spf=pass (imf08.hostedemail.com: domain of avagin@gmail.com designates 209.85.128.52 as permitted sender) smtp.mailfrom=avagin@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679337013; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DaE8Cq+3HD566AAS3cNbL9kU0VpoY/kWeisZ30TMTT8=; b=HutvCKHobzUhf2NTBP76XEbaIK7bYS3eVqSmURlKuiKcPFKFK88TWjwmXqyTV9HtD5WdYc D+qJ+trQ8VuMRcoayjinEh0dDYgk9SLc5IpLtc9bErIbG/KDC9y5FbF0iO8+/JUd+ztkME Ae60Z7ppEosM5SDJ+gfsmGxedj1n6b0= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=oA4w6+dD; spf=pass (imf08.hostedemail.com: domain of avagin@gmail.com designates 209.85.128.52 as permitted sender) smtp.mailfrom=avagin@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679337013; a=rsa-sha256; cv=none; b=D28ZVVvyeFCXqQzqf++4IQQy9e5yM/rjVPg6cjsmPETw1TL7cM9RsrsD7mL8ipqwrB+lar oDOohcjmzNd5Qv6WH/RMLhIK3hNMGpEU3+k9m5m1ZTf/F591px8PQoDO//ah/hURh7+U0J EAogvWRVvAlFzVozEo/2tEhYcEita74= Received: by mail-wm1-f52.google.com with SMTP id o32so1781966wms.1 for ; Mon, 20 Mar 2023 11:30:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679337012; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=DaE8Cq+3HD566AAS3cNbL9kU0VpoY/kWeisZ30TMTT8=; b=oA4w6+dDqA8sdlaThxyc3zs7OVUqGgIdMPfb9hG5XtPf9mEQy3/Wr7hm0EwAzKZaIe vuOEuEz0WcVfDc00RZMe4OittNI9xbDVeefvoHWrkwHdE8H1IsoKsA8mi8/dq6axQC7u FWNEuGqvHzOPhL5WviP7vZvv8DnMrRSxul589MhW/wLoEVNt5hqhMKHt4FWNAnv7TV9l QxP/meyuVlI3A9mZ4O4T4nr2SHGTwch1+9hs4D86dh8onYJfn3dpqFX+5B4n/PlqsOAW wzRaFP6iKCLKWaVmcUwGbGVLRYwN6+fKF9/jET2Ox/Dz3f//3dVz8WOW/kPj4xi79ipr gMug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679337012; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DaE8Cq+3HD566AAS3cNbL9kU0VpoY/kWeisZ30TMTT8=; b=ASwL44xa/1MQnxk6J432uv146fg3beV7awRF4Bup3oM00w2qAbX9PQFdMCnldyiwoO 4nfgTuofjMQ1xs+L7bh7RIXeG8T/BZ7uXVm+j5nn5gV3pyF5ylR3gFezsYVXqSYoIBTX /gdzQAjU/T0OVLSModGteHozUH62qan7l3uHxHa+Otlc7UDJcIBvL6H+lWLKvrxjw8+6 Ox54PbiNV6prKSmlFb3FV5XtE/Z2CwYIH2J/p/wCFjuZGHh7YXaWzXf01CGGuSLXmPCL QpnNUoIAY5aqS2m1WIgYSfUHMIFR9jWuIXjt+rKihm0WVLAXXlRaBPY972JespmfYmpm ClmQ== X-Gm-Message-State: AO0yUKWyh3b8ufKyW6GaGshREbaSQraKxItMmy16RO/v8xenA16GkJ7P Sd0fLqqNUGGlwMIUgix7W5oG8EttVzp3JXCgfRo= X-Google-Smtp-Source: AK7set9Bgwg8JCn7J8ExtyKaKDVaOjrbw73S5bkBKD7eM6hgwNYtQl/5KNokOmDyTHs3W6NUlNefJfPgnBqv6sOyhQU= X-Received: by 2002:a7b:c7c6:0:b0:3ed:ce50:435a with SMTP id z6-20020a7bc7c6000000b003edce50435amr394181wmk.10.1679337011724; Mon, 20 Mar 2023 11:30:11 -0700 (PDT) MIME-Version: 1.0 References: <20230309135718.1490461-1-usama.anjum@collabora.com> <20230309115818.170dd5ef2cde7b58b9354ecd@linux-foundation.org> In-Reply-To: <20230309115818.170dd5ef2cde7b58b9354ecd@linux-foundation.org> From: Andrei Vagin Date: Mon, 20 Mar 2023 11:30:00 -0700 Message-ID: Subject: Re: [PATCH v11 0/7] Implement IOCTL to get and optionally clear info about PTEs To: Andrew Morton Cc: Muhammad Usama Anjum , Peter Xu , David Hildenbrand , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Danylo Mocherniuk , Paul Gofman , Cyrill Gorcunov , Mike Rapoport , Nadav Amit , Alexander Viro , Shuah Khan , Christian Brauner , Yang Shi , Vlastimil Babka , "Liam R . Howlett" , Yun Zhou , Suren Baghdasaryan , Alex Sierra , Matthew Wilcox , Pasha Tatashin , Axel Rasmussen , "Gustavo A . R . Silva" , Dan Williams , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Greg KH , kernel@collabora.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 81D72160024 X-Stat-Signature: u97dw9mrj5q3xaosnza1rh9atnj9m7zo X-HE-Tag: 1679337013-171440 X-HE-Meta: U2FsdGVkX18u7RoZQN9Wwhr2/kteQYdJ+kz8gwI/LlvDlG7nPBaJu7s3YpGTb3PwduG+Lbz8OYy81uAA6ODRfmh1plWsWEGvPAZGB6Bk7o6RUPc9g/nlJ8hCJmVEo3eFo6Zd65mdPt+WPLS6X/7+hS4X6yeSZo/ZN6YAGTmAHwH1h+QvuzltV+DrTQcSPhrLTGRu1huCuf+v/rCXGVAqmI6Inc+A98Cvmg7XpAYlJCqmkPT7hzaRo6Fu3adgu2BGEvetx1D2LCLoOZG6JBvrUObicb917HOrcBNdq9KpIFKgH8GSOnU8EE49UD7bcq7MSoNMHIcxAFzhGxYXQGDn9twxvzwytk/X3ZhBTikSCjN47kEQKtFBJ4uZR83sJ8mHXGr3eHaNAZUdSXoPETo4u4I3sHVtl8ASsbnG6cfJKHgTidUrb+dxVWJj89m/nwJc5jCS5yt22bwpwUHcb3YFD+VWCCpcBru7NGvDcCTx7DzpywrGD3NPYNHJTHX7TdrbDfCRNCIhzSZoRjy1irWYlSAGu+0uceEAd78VJONXi1v8sE9cMIVlZSJOoNtGS9zfgxazKzX1pEQUHplB6FYlCZvwMWGzfgsvDZ1VBde7YvGVSUAUB26wwz6CBLqPu8TG/udAyoUaqvmw5D9nV09h/j6bGpeAq9GnRLGZotZKwv+36DQz2ABFYFb5LxugnXhJL7SrUQdfXtr9OJCxmLxx85SEgXmKMHFgnUtVcck6+AyQvNvA4aSu3Y9GFbhdLZK/PxtigjosS4eLLzZL/MyW+ZOaCJObuguaJJJOay6n9HgU9TIUxGjSR/4fDP/akWkWZ3LZD57UjqNYvmEkUqjiDddvOSf4tiGto2aj4r23ju3ukXQuHDt05kjKXRNwFgeHvE2owY3AZJPjDZXtw8uMiDhKUQOk9nwc3qlj3/k5P1dcme0bIEqRdOLD5Fc7/64RwurS4ueQrfqlbTJNgAV hBKkruEb ivd6NJzyyU96GZ+PsN+cZaDqqc0CuQWpf4aIT+rtsjpdu9A0byCM+FEgShjEyzA81OlQ5pT5xDV35ewWyqfm/Xbc8Vq6SdcjvB/7YWmEOQaUkMzEgBfGQQAWlkoN3gxpyncdrEDtBQNv3nz5aohJRyU8TLmHUB+DhwF90CgTchNQi09zAjIwLT4ZZPBACcVKR3/I6MyoNkQHFb7RLUCA2MrzQkPJOMHpihMUYTMeXTo4wxDWbecXnomdc41SBaB0bhYJ4+0rlJvtZBv8/G3fj6hWcQoq2JVziBDqYq5GmATmeASCHCMSWk56Z7PDJaSRpW+Si/r5qlfioFrPgApzBOjpazBaWESwZxc+jVlsbB3offyVlipYDAkf/Jpqa5x+/YLoIAEJqdoR1A0A2liNMDVsXkobU2xFh6QrDb8EF3/B84GbjhR6UQt2JdZzHtO7Gc7QHQhhC0nszUk7V9EUwUv/q7ZOZ3dB5Ec5yk+CJicuZ32E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 9, 2023 at 11:58=E2=80=AFAM Andrew Morton wrote: > > On Thu, 9 Mar 2023 18:57:11 +0500 Muhammad Usama Anjum wrote: > > > The information related to pages if the page is file mapped, present an= d > > swapped is required for the CRIU project [5][6]. The addition of the > > required mask, any mask, excluded mask and return masks are also requir= ed > > for the CRIU project [5]. > > It's a ton of new code and what I'm not seeing in here (might have > missed it?) is a clear statement of the value of this feature to our > users. > > I see hints that CRIU would like it, but no description of how valuable > this is to CRIU's users. Hi Andrew, The current interface works for CRIU, and I can't say we have anything critical with it right now. On the other hand, the new interface has a number of significant improvemen= ts: * it is more granular and allows us to track changed pages more effectively. The current interface can clear dirty bits for the entire process only. In addition, reading info about pages is a separate operation. It means we must freeze the process to read information about all its pages, reset dirty bits, only then we can start dumping pages. The information about pages becomes more and more outdated, while we are processing pages. The new interface solves both these downsides. First, it allows us to read pte bits and clear the soft-dirty bit atomically. It means that CRIU will not need to freeze processes to pre-dump their memory. Second, it clears soft-dirty bits for a specified region of memory. It means CRIU will have actual info about pages to the moment of dumping them. * The new interface has to be much faster because basic page filtering is happening in the kernel. With the old interface, we have to read pagemap for each page. Thanks, Andrei > > So please spend some time preparing this info. > > Also, are any other applications of this feature anticipated? If so, > what are they? > > IOW, please sell this stuff to us!