From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51D3BD16278 for ; Mon, 14 Oct 2024 14:34:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C95556B0085; Mon, 14 Oct 2024 10:34:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C1E3E6B0088; Mon, 14 Oct 2024 10:34:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A973E6B0089; Mon, 14 Oct 2024 10:34:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 87DAD6B0085 for ; Mon, 14 Oct 2024 10:34:05 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id AA8A1C08C8 for ; Mon, 14 Oct 2024 14:33:56 +0000 (UTC) X-FDA: 82672452198.27.31D1891 Received: from mail-io1-f49.google.com (mail-io1-f49.google.com [209.85.166.49]) by imf24.hostedemail.com (Postfix) with ESMTP id 6BE9D180009 for ; Mon, 14 Oct 2024 14:34:01 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=sifive.com header.s=google header.b=Mvyt9gnf; spf=pass (imf24.hostedemail.com: domain of zong.li@sifive.com designates 209.85.166.49 as permitted sender) smtp.mailfrom=zong.li@sifive.com; dmarc=pass (policy=reject) header.from=sifive.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728916301; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BZFiFSV2S6ephEEXxaRsM/YTIpGDjHwKVrQbLRq0m74=; b=w7Shz1tZwa8FZ/TTTFCvEIJDLNKclbjEz83eLsVW9mh7fx1uPuVlERFOBizg4OL5TXN+0F JlLm+/nISGBnBK9Gw8Kc4T0I7D0JQ/pLM/7qSnFNpPLmtOLXErfYK8VjfymF9RUF23hdJg dKwqVZ1lANm5zW18Gy9xsGFodM4Gz18= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728916301; a=rsa-sha256; cv=none; b=hHQgOzfSbv2AZ5+fO1oDkCbW4YzTEduyzVFgVenI6LLTF37gZQ2KN1dCWmBFke+RUwl33P gwGMRCFFXuLTidNMQ127jLK+YgNXIng+8GOZQ72g/3+HAyapJjfVCQE1ygBSxmpPzOxSk7 8JZxpQ4OyN2pb2E69L7toWCzBMnqcew= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=sifive.com header.s=google header.b=Mvyt9gnf; spf=pass (imf24.hostedemail.com: domain of zong.li@sifive.com designates 209.85.166.49 as permitted sender) smtp.mailfrom=zong.li@sifive.com; dmarc=pass (policy=reject) header.from=sifive.com Received: by mail-io1-f49.google.com with SMTP id ca18e2360f4ac-8323b555a6aso272011839f.3 for ; Mon, 14 Oct 2024 07:34:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1728916442; x=1729521242; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=BZFiFSV2S6ephEEXxaRsM/YTIpGDjHwKVrQbLRq0m74=; b=Mvyt9gnfaxw12XMJFuv4DuE6uwF6R7o5ecFay4Utg/mkKqpYlrvc328HAPwrNAWNDo 6jW8x76l2/5nrM97EvyzBc8Dxpzfcq4ww183TE0CSIcAkGcFQeMWJ5WxOpotYew4DB/L HY+12Ft7pziSqtgXbLyVsRU7sMLbnkMQEF3BP0AIWybzDr3XtKAqDoVTGUb7HTBjls2f 3uB8gjyz0u2lNItgP036cDPic/h4Le4dWMYdOvXTm0wy1sR2H89XWMD53il3x7XBbkxs c5mkTXb7maVuHnz2AzfW14q9dYBpRO5vL8uvvRHZdMxUG0osnibjkCUUo3L7BIDeHh1N Uicg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728916442; x=1729521242; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BZFiFSV2S6ephEEXxaRsM/YTIpGDjHwKVrQbLRq0m74=; b=f4Y/T+uTa9/I0BMMPpKetDiTIPLlR9YQMOBTysGmBSzcwrLjFsBsM6u3I3IBJq/Yip AAsjD+MvcQrzuCXPRX1VTjm6g4UnNXuK4+iOOpa63ojYpdywoYAYYGjdvbr9mA6GqotQ l04ssmu7xaUROF11rYzRFaEBMl7pJ5n9clFb96x2cPK3m017VWiYSsT5WZo8hkK1gUuj M9w2ISXMsc+Yk93CtD/S8e9UN5E+NdHG/d0H3Paf6wFhw7+QqTYPJKtdT88PmIL01DHD kdxYWje3pTMG7tJ7Vw0NMHeMUO6uTXHtTIuGb/hQ2x49+fOr5wpz+ADc4TRx/mEuMawn BOhw== X-Forwarded-Encrypted: i=1; AJvYcCVYuJumjcP4nEgPzogXVfXWYYTr8TqUTSp5k9XRkBQ7Z02jz3o4NJWUivWy3GkdAVsG9VZwlNHv+Q==@kvack.org X-Gm-Message-State: AOJu0YyD4uMmL863vzuzzmBw3L04v8mGigzS98dsvmUSFTlvyX+9KQRI ZXJKr1V69U4M1gNUD71Iz9b6cYQ/2g3hBRKd6XMOKpWoz/aDZsIYDt346+HdcH9G7T3Tz5uzs9O KVKaqgYqtrS1b4CBsztte8dHwEvT4xEtspP30AA== X-Google-Smtp-Source: AGHT+IFYJowFNk6TiJAeIlJ6VE4pS1HwOZ1J0S0O0mVVAaMh1gyG2y64c+9AiCOVdFTYNqR+gnZqJMfVyAe4szQJ6+M= X-Received: by 2002:a05:6602:3f91:b0:837:7e21:1677 with SMTP id ca18e2360f4ac-837929fd68fmr950720739f.4.1728916441860; Mon, 14 Oct 2024 07:34:01 -0700 (PDT) MIME-Version: 1.0 References: <20241008-v5_user_cfi_series-v6-0-60d9fe073f37@rivosinc.com> <20241008-v5_user_cfi_series-v6-33-60d9fe073f37@rivosinc.com> In-Reply-To: From: Zong Li Date: Mon, 14 Oct 2024 22:33:50 +0800 Message-ID: Subject: Re: [PATCH v6 33/33] kselftest/riscv: kselftest for user mode cfi To: Deepak Gupta Cc: Mark Brown , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Lorenzo Stoakes , Paul Walmsley , Palmer Dabbelt , Albert Ou , Conor Dooley , Rob Herring , Krzysztof Kozlowski , Arnd Bergmann , Christian Brauner , Peter Zijlstra , Oleg Nesterov , Eric Biederman , Kees Cook , Jonathan Corbet , Shuah Khan , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, alistair.francis@wdc.com, richard.henderson@linaro.org, jim.shu@sifive.com, andybnac@gmail.com, kito.cheng@sifive.com, charlie@rivosinc.com, atishp@rivosinc.com, evan@rivosinc.com, cleger@rivosinc.com, alexghiti@rivosinc.com, samitolvanen@google.com, rick.p.edgecombe@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 6BE9D180009 X-Stat-Signature: i4mgz3rggj5xyzynu7g7ykuz3omiihxz X-HE-Tag: 1728916441-651808 X-HE-Meta: U2FsdGVkX19zZ7lvDz3PxHSwHyFPjArhgB21H5yFIT4eMjAqt4CwDPPzl+BXW4o8X7LonYU2cDZwwuRIK6r6ghUnozGlRmTgy4Aap37eMY6MB8PFEydy+GBmHmKtemN+G7YX9DduLGb71sPh00pv4HWn14tOz4UAXFTIE0GGmykk8oVv95iRzmKErA7xEybCNvjb3NbVtWwCTvMg4mHRkD2TsK7bU47qrlhK5ldsvV//K2pAv/YH64tvQ0/n5MaegkQC6x0mnJyI28m05CC4HHd8T2zzKbcML/AxKkct0UwlzMRek6ZLSZTMXQTW3c2Gyyx9bywHGiBVFWMJuVddSSMc5p3bbEfL1lEbbaup9DUlTFcF2+vvDbFJDmWyWS7QChhuR3rJ9K5Uiqj4q5a8hs5JlB9VwRVliR+zh+nGkt5zpfujyc1fMcVz+HnI5zzVHzCrb+j1BrSsFFY5dbN5u9jYgS2gC4cruwy70HfwY+UU6xtjrMhzH1wyQlQJ5y75xDEm67Etr0sD+IZeCvvR0RZQFEyI1DF5AOwfMC4GQHWX8jpnZMMCDnHkO8u7/bBPsmKOY5/Lsjfb/cTpL4xKB4OUp3yVNYCutJ21NvZ33Oe6FdGV8Nzn9NFONPVVgyTqGa+AyLiH9Sf1LtOY37QYL2XkNNox1duBx4KX/L1GAt1m1FO1rIWfPX8/4ExLMaxxuIoof7r/Y2XOFz9CBMDDvCzivvobkY7Bt7cagxL32qPIsPLdDkOEWst8LU+W4p2j1hJKbGfQlergor+/NhIKc6xrucqT797sqAoe/4zCT5ewNcmFf9SgcQ3FRhrJjXv9QAaOUiZu5AWUSZ7amIlwyXdfJhkIyLB0jzhDRO3INc9q2AIB/dBNe2+Kk3krjiOBqeF1RCxdM3V/G7T29lkNE4zCuyVWuKEuuEcKj8hyJTkfNaAW+aXqXySN/Q9RMRpArd6W/Genbya9V1aZiay 6G5P8r2k t6xD6IyfRf2LODtEje/njw4pdT3qyeN8pp7S2Yuf5Ykv2vtpblo0QeWQbsAQMyO5MnrB1tVwfEcm8TEqa367zoRyynAiflCVUDbcoJRoZLPtuT0ZWRqrl9p9asKiP5nGf5p0KuFRHSpimMqZCMuPOXteIHYJTHRF5woS+aOlGvRZC5VqPq05IQ90lfk4/QvNZTr9tkn6Ki8Yt2JfLEq6A0ZR+9YGXrkTTABuWhw1/QP2LKrg0ocIpAZxt30ubtRysp8H5xwihF1OsIQgtDuk30aJbeFo670YofLFI7KjR4YpOMEBPeoueyS0gG8kHNuv0zUFbC5YrudTbFD7ck6VUA0z7bZ20PcUnkaFY X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Oct 12, 2024 at 3:46=E2=80=AFAM Deepak Gupta w= rote: > > On Fri, Oct 11, 2024 at 07:43:30PM +0800, Zong Li wrote: > >On Fri, Oct 11, 2024 at 6:18=E2=80=AFPM Mark Brown = wrote: > >> > >> On Fri, Oct 11, 2024 at 01:44:55PM +0800, Zong Li wrote: > >> > On Wed, Oct 9, 2024 at 7:46=E2=80=AFAM Deepak Gupta wrote: > >> > >> > > + if (si->si_code =3D=3D SEGV_CPERR) { > >> > >> > Hi Deepak, > >> > I got some errors when building this test, I suppose they should be > >> > fixed in the next version. > >> > >> > riscv_cfi_test.c: In function 'sigsegv_handler': > >> > riscv_cfi_test.c:17:28: error: 'SEGV_CPERR' undeclared (first use in > >> > this function); did you mean 'SEGV_ACCERR'? > >> > 17 | if (si->si_code =3D=3D SEGV_CPERR) { > >> > | ^~~~~~~~~~ > >> > | SEGV_ACCERR > >> > > >> > >> Did you run "make headers_install" prior to building kselftest to get > >> the current kernel's headers available for userspace builds? > > > >Yes, I have run "make header" and "make header_install" before > >building the kselftest. This error happens when I cross compiled it, > >perhaps I can help to check if it is missing some header files or > >header search path. > > That's wierd. > > It doesn't fail for me even if I do not do `make headers_install`. But I = am > building kernel and selftests with toolchain which supports shadow stack = and > landing pad. It's defined in `siginfo.h`. When I built toolchain, I did p= oint > it at the latest kernel headers. May be that's the trick. > > """ > > $ grep -nir SEGV_CPERR /scratch/debug/linux/kbuild/usr/include/* > /scratch/debug/linux/kbuild/usr/include/asm-generic/siginfo.h:240:#define= SEGV_CPERR 10 /* Control protection fault */ > > $ grep -nir SEGV_CPERR /scratch/debug/open_src/sifive_cfi_toolchain/INSTA= LL_Sept18/sysroot/usr/* > /scratch/debug/open_src/sifive_cfi_toolchain/INSTALL_Sept18/sysroot/usr/i= nclude/asm-generic/siginfo.h:240:#define SEGV_CPERR 10 /* Control p= rotection fault */ > /scratch/debug/open_src/sifive_cfi_toolchain/INSTALL_Sept18/sysroot/usr/i= nclude/bits/siginfo-consts.h:139: SEGV_CPERR /* Control p= rotection fault. */ > /scratch/debug/open_src/sifive_cfi_toolchain/INSTALL_Sept18/sysroot/usr/i= nclude/bits/siginfo-consts.h:140:# define SEGV_CPERR SEGV_CPERR > > """ In my case, because the test files don't explicitly include siginfo.h, I assume it's expected that siginfo.h will be included through signal.h. Regarding the header search path, it will eventually locate signal.h in toolchain_path/sysroot/usr/include/. In my toolchain_path/sysroot/usr/include/signal.h, it doesn't include any signal.h; instead, signal.h will be included from toolchain_path/sysroot/usr/include/linux/signal.h or kernel_src/usr/include/linux/signal.h rather than toolchain/sysroot/usr/include/signal.h. I think that is why I lost the SEGV_CPERR definition. Is there any difference with you? >