From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA8EFC4332F for ; Sat, 31 Dec 2022 17:14:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3AA1D8E0003; Sat, 31 Dec 2022 12:14:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 330D78E0001; Sat, 31 Dec 2022 12:14:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D2508E0003; Sat, 31 Dec 2022 12:14:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0B1FC8E0001 for ; Sat, 31 Dec 2022 12:14:44 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D31DF1A045C for ; Sat, 31 Dec 2022 17:14:43 +0000 (UTC) X-FDA: 80303250846.01.7BCF4B5 Received: from mail-yb1-f170.google.com (mail-yb1-f170.google.com [209.85.219.170]) by imf20.hostedemail.com (Postfix) with ESMTP id 5D0601C0018 for ; Sat, 31 Dec 2022 17:14:42 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=FqC5ZHep; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of dmitrii.bundin.a@gmail.com designates 209.85.219.170 as permitted sender) smtp.mailfrom=dmitrii.bundin.a@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672506882; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ibcFxu0r5aq7fCHqB6aB5eCpGsM5NrAZ+yiZYLfhytk=; b=idfH4dwdxrW/SwpggnL/A867WxfhQl+aURHFRZKUuVBbh/HDQOITI2Dql1F9fy0uVd1V57 J0xQUrrT7A6HpwLgk+lg+B4hMq0jsCncSoS/UwtXUz473eKJ/TeZBStl5NaP2MjE1ntVsW J7Jygq9YO8UEGoZxDLO/v+0qyO8H6BE= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=FqC5ZHep; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of dmitrii.bundin.a@gmail.com designates 209.85.219.170 as permitted sender) smtp.mailfrom=dmitrii.bundin.a@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672506882; a=rsa-sha256; cv=none; b=Igmc7DrAoYUpO7sQ193lFoXou9GFBZel5v3JzETDPXy/6CMg6fXRsWChW6HsN9nSfsAw7h CqBaKGejOf1S27Tn8b8y0uk0lXx9is19rKYp1naiWeV1jCm5NZazChMjBxBBoE7SRCLXFX p+tEQtBlQH60kVWrhdKOsBFW5Hlui14= Received: by mail-yb1-f170.google.com with SMTP id v126so26479768ybv.2 for ; Sat, 31 Dec 2022 09:14:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ibcFxu0r5aq7fCHqB6aB5eCpGsM5NrAZ+yiZYLfhytk=; b=FqC5ZHepDUgE405pYH8EmwSWX1cJpDrq3DsvdLz05MSCJG4wA3RlisgtkAmUyfwTz3 5P3zJs6ZtJOWLsticvL2lWfgRwwHBj2Jb28Mfgn8imbegCKA84hF8QLuG9VW6o2xRjbz 92MGLlU8JTrAjRuECvpmdNjQL+6Dn++LhP76w4/uRrAvgZlUIKjwadjk1iMnJLrUv8cH 13DamiJZWSUQ57VYq7pZYjQyFJYwbfXI3i7aoAhDa30HQyLr/bWbampPjAxjr5g0i2aU ixMjDtu4n/iNapU6JiiDS/NOwiV5v2MyCULU97sRKi6gCRr4uKc/OHLlUifI6rui5Txh m2Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ibcFxu0r5aq7fCHqB6aB5eCpGsM5NrAZ+yiZYLfhytk=; b=zQv11qDxsoDTrGCtYdRabJUWpJE7KyLfw+gbwXhw6xTbAyV908rfl6EHMCQLsWcjcK 6b3GltufSUGgPn2fUTzknjjTJmjcmISFGM/o6xss/L5gftFWwRNcSeg8QPi9BywNjoCx CtDWLJiMk5KZb1cTaKudzZ55dYtFL2xAdu6k6vkTW9ITqHO+0g+65YgyKfxNw8V48OYe krBYuU5VEeBxvkUjkWD+WWIyql3ymyFV6SEU7Tc4tlhGxgYI/tqlyDSw56WzQSwEAaW6 P9Nf3bvVTv6mE5iO16CR4ZwHDvdKbGs4t2mvTZHeiP4R/8eMpMFSBeqFEXZFuW42JZ2A zBZA== X-Gm-Message-State: AFqh2krMT/pK2o9IgYnvFzR1Uzogap+6O/DPW9zvoDLVKlvhAlfOYskP hZzauJ3u+lAjLhx4tjxqV5iU64VU8zsAL/nnk5I= X-Google-Smtp-Source: AMrXdXuslAzvIwIYCQUhi4DGuPioVVUYKYBx8ue+3JA7sF5tKjP2nd+0zRsqz7Ruq1y66L0EPiynhlaxPJ4owVG1JZY= X-Received: by 2002:a25:4c81:0:b0:6f9:ece2:7b87 with SMTP id z123-20020a254c81000000b006f9ece27b87mr4093697yba.485.1672506881526; Sat, 31 Dec 2022 09:14:41 -0800 (PST) MIME-Version: 1.0 References: <20221230163512.23736-1-dmitrii.bundin.a@gmail.com> In-Reply-To: From: Dmitrii Bundin Date: Sat, 31 Dec 2022 20:14:30 +0300 Message-ID: Subject: Re: [PATCH] scripts/gdb: add mm introspection utils To: Mike Rapoport Cc: jan.kiszka@siemens.com, kbingham@kernel.org, akpm@linux-foundation.org, gregkh@linuxfoundation.org, mingo@redhat.com, x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, vbabka@suse.cz Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 5D0601C0018 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: z1koe5izw8j8sjzx1nnitsw3wmrd6hkm X-HE-Tag: 1672506882-649528 X-HE-Meta: U2FsdGVkX18ip45onAEzPxMO9YHko+jXTcJ4+uNuVbuyspDBZTwjYleXaVqfdy/rkxDXhSGPARBmWkMPj8kkmjMCWbebkhOcg8lA1/WLr5OJJjKi3CntxvNsrxPObVx+VzEv5kcGjEn3xZUdlOL1L6pNhl6W+si1j00Oe6rbPL2F+FfNKx5lHWJ3urEqzQzfy0WdQFiMG+HSA6M+W1PSuUzp7SF0GeUrgByxAghZo7q3ZyxMGdFnv7VSCWTmeanMXtlugeENlREbcmqNJA3HFxEU48OIGIEkTpVwGreBfQi0feTLZFYZcIWD0ZBEPSC73vQt/3l61Yg5GpMrvh3iAwJ8BNA8qM7M2e5jPmb0CTyobt0Dhh4hiaQ9BZrKmNedvYZwABx/ppKe7haLDpKT/34wahwG72LVJSN94ghNB0Aopelugj0/fpDylgO++Vh4V7b27Wvf3TfUxwPckAlZAIyclT/n1P6/3BHzPagqFQNE2//ZJAS8O98O22j8A+rgXvqk6W285ggwe3prdNTTZmEM+wiYhhpeq8O1zlNRRT99+dOPJtlsQH4IFBVEwBgmCoOFYVOUz+2FZtIcsIMkTRF47vfXkmRU8xKiyKqp5+Q0g3vzVMupOiU8217eR0nX6ewSA7PXLyil3mZrVLpyk3CU1ZgoTKsWOoKRqYAXY6kVmYcKgeHjUimzoH0K77nBWgf8EMp/yzOInRG2UXWmI66GLoIfzg+Bqd7YwgSTxop8O3flrq5hO1WsqZtK7jmHQ6W9ob8r92xF3Pod2c4FXD8rfPwPVYE2W4TvQSB7K1cMOmMY7sjgpUSVuDeUCjoZGtMFV3PKPMg4fawoXfa6QNRBWGcg8TM/a+4n6tI4N/L02rly8dhe9Xlz2890cXmgHIzN3J0nxOZN5OQn+29u9jD0wwOcAbG4B1EGthrYmHJmdAmJb3Xnh2D7AXj0iBEo51Z5cFbQag1C7QmM+YT OF8e2p/w vZiQPUFGZ1ZZe918MP7c2nwxCASP6vxhDIBNx7322vS2FStqC8AJgozqeUDMysAG5++Q6O5xC1UhVrHlNo2q2CuPenA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Dec 30, 2022 at 11:07 PM Mike Rapoport wrote: > > The commit message does not mention it's x86-specific. > Not sure how gdb scripts handle per-arch functionality, but at the very > least this should be stated in the commit message. > Thanks for pointing this out. Will fix it. I put the command's code under the if utils.is_target_arch("x86") ... else gdb.GdbError("Virtual address translation is not supported for this arch") as it's done in other scripts and have plans to implement the same functionality for ARM in the foreseeable future. On Fri, Dec 30, 2022 at 11:07 PM Mike Rapoport wrote: > Any particular reason to make it ALL CAPS? Actually, no. Do you propose to reformat the output with a lower case? On Fri, Dec 30, 2022 at 11:07 PM Mike Rapoport wrote: > What will happen here with 5-level paging? This is safe to do since the PS bit of PML5/PML4 is reserved and it's not possible that a 5 or 4 level entry maps a page. On Fri, Dec 30, 2022 at 11:07 PM Mike Rapoport wrote: > Please don't use magic numbers. This was actually a page_offset_base in case the CONFIG_DYNAMIC_MEMORY_LAYOUT option is disabled. Will fix it.