From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B49C7C27C5E for ; Mon, 10 Jun 2024 03:39:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E23F76B0088; Sun, 9 Jun 2024 23:39:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DD3E46B0089; Sun, 9 Jun 2024 23:39:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C9AF66B008C; Sun, 9 Jun 2024 23:39:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id ACCF96B0088 for ; Sun, 9 Jun 2024 23:39:43 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1E07340AE0 for ; Mon, 10 Jun 2024 03:39:43 +0000 (UTC) X-FDA: 82213574646.19.9DFAE6D Received: from mail-io1-f50.google.com (mail-io1-f50.google.com [209.85.166.50]) by imf09.hostedemail.com (Postfix) with ESMTP id 25FB7140004 for ; Mon, 10 Jun 2024 03:39:40 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=none; spf=pass (imf09.hostedemail.com: domain of yisooan.dev@gmail.com designates 209.85.166.50 as permitted sender) smtp.mailfrom=yisooan.dev@gmail.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717990781; a=rsa-sha256; cv=none; b=oPm1iNdtyfwntjC7RhnjNzeplSh4ucAbX5pCqdhTNreGvHoU8XSgkZFZt+M4miyXuo2ZHu XVyU2J7vT3R12GoQTuRZsE20md1Na2reV280zv7yZAUzZumckhobgfyqPVqF42DeNYQJxB FtOjHLMwYIiuTcCMtABOw5TdHkLbXgE= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; spf=pass (imf09.hostedemail.com: domain of yisooan.dev@gmail.com designates 209.85.166.50 as permitted sender) smtp.mailfrom=yisooan.dev@gmail.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717990781; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y+eIMfo/S7Cz67YDTeYts3OKQVaj8bHX07uK0ALbnNM=; b=K1ISS5toM4qL8PjlxcnIXbhIW9hfiMkmyFxhxWF82hF/dk6gRDT3y1PjR3m0+H3nYSjuu6 PmMlLD4ZCQ4Gn/DhiBBH9U+XOFhBziCEtVhBVCJmD0/c3HhKwziWw/ngfHqANMFhiAl6yG o4m+LotPyGvH8DylOkn5sXVSzEi4Pf4= Received: by mail-io1-f50.google.com with SMTP id ca18e2360f4ac-7eb01106015so175214039f.1 for ; Sun, 09 Jun 2024 20:39:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717990780; x=1718595580; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Y+eIMfo/S7Cz67YDTeYts3OKQVaj8bHX07uK0ALbnNM=; b=in+cs+7ZufLrlywrFQXTBf3A9QkpKImXCxzRXd47M17aYMHTxZf2UxH8ETGCLiISYn EzQhelLCwXI09fbHaFg/Ns9ASguSCabFA1l+hKZhb9yPG9fsUApPHgyea8mwR7iIwI// vJVB+sg1w14oCLm7dZVCDQMpEwZZdvFyRI1U197o9W6jkeuLTNZBWn112KdiLx5KpGAt IfZBnTdjG6RcYclQNoCFhuCkcRpdtBXPs3RwwSKpmnhg+o095lZBOWUExxuc9Zeoomhn YHjn8F2JLTj3PiIG/76jGiqsd5JnhskYfOMEu2IY8i8R5PQRQhmEO4IkwUe+ESSAspbG 1GpA== X-Forwarded-Encrypted: i=1; AJvYcCXH25DrVUDJgjxNConvfGwT+06DxFNR9RygD3hXB3aEIS7RWwlfX9Esvibgh/ONcwakraEmar7pS/TelNN9OXmfODE= X-Gm-Message-State: AOJu0YywpEDOk2auua8Rs3oUwKYN5wpclf/6ZTUR6iVH7NxU7CoV/oja SfmNwwrByYrrpOf0Hr6O7hgc9QVufTZhlfZ51+gKEdHz5pFYTldByI/TxDg40yY= X-Google-Smtp-Source: AGHT+IGQadtzehLw4zCRzLvxZ6m9M96IjXZNJqkn7zMV6WJEcD3+8KnEiqwHD0LX9z5FCHMTcarlEg== X-Received: by 2002:a05:6602:3fc4:b0:7eb:8887:d6bb with SMTP id ca18e2360f4ac-7eb8887f2fcmr158247939f.2.1717990779753; Sun, 09 Jun 2024 20:39:39 -0700 (PDT) Received: from mail-il1-f172.google.com (mail-il1-f172.google.com. [209.85.166.172]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4b7cad3ef40sm1307185173.66.2024.06.09.20.39.39 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 09 Jun 2024 20:39:39 -0700 (PDT) Received: by mail-il1-f172.google.com with SMTP id e9e14a558f8ab-36dd6110186so17399795ab.0 for ; Sun, 09 Jun 2024 20:39:39 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCX8OtZXiH/J4APZpQ9poBHtikQFRcj1kJd4wTxFYdHBzT2xHufGdX/dx2AfNiPga3nPmuJIvMaDC7TbJh/tD24OvRc= X-Received: by 2002:a05:6e02:19c9:b0:375:9ff9:7d0d with SMTP id e9e14a558f8ab-3759ff98134mr36892835ab.28.1717990779202; Sun, 09 Jun 2024 20:39:39 -0700 (PDT) MIME-Version: 1.0 References: <20240608152114.867961-1-lsahn@wewakecorp.com> <20240609140341.14ba3a1c62029771d60059ed@linux-foundation.org> In-Reply-To: <20240609140341.14ba3a1c62029771d60059ed@linux-foundation.org> From: Leesoo Ahn Date: Mon, 10 Jun 2024 12:39:28 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] mm: sparse: clarify a variable name and its value To: Andrew Morton Cc: Leesoo Ahn , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Mike Rapoport Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 25FB7140004 X-Stat-Signature: wnegy8nnkdb84s8cj4gow7ddwxiyfitp X-HE-Tag: 1717990780-330164 X-HE-Meta: U2FsdGVkX1+cfDVgU2biegL6+wL8RX+JbsOZk5CrRFYiIbM/xLiPqJJ7AFTXUiRnU2FJgcNETIKqX2kRJeUT/ukiMco7eYFAU2/273wKPXzM/Nkqb3aje4b3YWUkoSxb60fee7tsTdobLsfCFDZO7Q/LmI9xJ4LVv+J2fA0eZAZAZgu8EX/SnCG+t7zZu8k4VTI/8ySurxg/+GAaVI+PZzdbjo9zNwYCJyzzG0Ntc/4D1wysSa3HXTy+uggkbGbwoLBmNpTSf7GyqxFLAj4oeNVoa8A5ywgBUd7CzCZMXu49+eKj127Mn3K8Mm646Rs+jvyjoZleBwkVs5HU/RY5plcPA925vqVfPB36EwyKzvnLMtIGWo4Ub9KJSSHqeYWnoHnli21tah6zJWgFmdFK2nUNn349lLB2WZvi8PM3p68CDrwXC1B+HmIPb6qZ2o6au/nZTIOf3CCXlH9H5L7WJs1AxDTnc41BXV+knkzdH2ENVuHfogHqSVNOSP4sqCAnvk8yxtXxrMEL5osHM8dfYg17d1izzxs+PTW+mj3PUvmAKTKXOHUhDQWabL8wX2ddpS499e/Qq6Hrunj7aVuiYM33n8ZAq2oLbd3UiJwsPVZHJLwwSxozv4WSqdZNh/EXyZNMTi5qDt3XMi5uRyE3FkMrkWvW2qZblfhsA5lOaG6ks6NWWwpq7gnt/RYKLs+M3M2Kr9vXsSzsZmw/UiSdTExmZx0+Hi2gVY1v4UZHSZmVgSFHQ85pIZuuFCFlM/wKbVSj2QScGVe0Fs5yPp2HL44/1Pe+7ZGmFlFJOBXzPwBl9E0tWLuA0XGqVydprYIATE+3wiLQhejTyf/DFnoyABQiYiXQJusyH+zIgGNbz/DEMgj7vjAfUSfe2Aj90Jrxq0iQVP5bX1zAag05tNOVvJOnqe/KspxHBRtdey6yUyO8oQviYLHQ/L+TrkKD6EmK0QVO4sbkwCgqNBvbI5+ +zKH9Kij 4nk6NO9Vba2Nqi1SzA/iA0xZrGKjk/IwIEAY1mtAUJMmjt8Aj+TvX+b/V/jpdumGRi4nDNK3dMBKqhR8bxyChZiOTHyGkUWVZaGM7QLPJBIHRkYdDmoeMWiEmlEdHKtY/2eo+VZeJSx3ycQnjkEVgvCzxiB2tgDXi9JO1Oby+QEHj0/rMuv7U+z7K3LgOaSb5QfJSyhSVm8IOeY2K0kIPr726/EW+rp9VWdsyJ8bgE4a6XBYnpvxUoMqhe4MsekZrWRaIF9rbPA6PZrwUQqrOAE7lP7sp3WhMlvYNYw+76JPxkJJgyOr8XFYyg/5QqD1GpnP3MNizwR9TvqnvTlzR6ape+n6ka6CgYKv+3j+mttP6hq5o2v+Epc6OaoAi6MY7MxDglpnGv6VFi3wyEdalEodcruwS930o2W3YmgJhsajQbZBwzRcRA4mpyPSHAqpDc2fnGKlCYBm5qQoXBXYaeZyZgVCG++SYNUhJXJZtaM1/sU+CPtkPq8YH6g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.340268, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 2024=EB=85=84 6=EC=9B=94 10=EC=9D=BC (=EC=9B=94) =EC=98=A4=EC=A0=84 6:03, A= ndrew Morton =EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84= =B1: > > On Sun, 9 Jun 2024 00:21:14 +0900 Leesoo Ahn wrote: > > > Setting 'limit' variable to 0 might seem like it means "no limit". But > > in the memblock API, 0 actually means the 'MEMBLOCK_ALLOC_ACCESSIBLE' > > enum, which limits the physical address range based on > > 'memblock.current_limit'. This can be confusing. > > Does it? From my reading, this meaning applies to the range end > address, in memblock_find_in_range_node()? If your interpretation is > correct, this should be documented in the relevant memblock kerneldoc. IMO, regardless of memblock documentation, it better uses MEMBLOCK_ALLOC_ACCESSIBLE enum instead of 0 as a value for the variable. Best regards, Leesoo