From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A008C27C5F for ; Mon, 10 Jun 2024 08:20:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 661CC6B0093; Mon, 10 Jun 2024 04:20:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5EB036B0095; Mon, 10 Jun 2024 04:20:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 48BAD6B0096; Mon, 10 Jun 2024 04:20:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 289BB6B0093 for ; Mon, 10 Jun 2024 04:20:59 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D2D251A0DE2 for ; Mon, 10 Jun 2024 08:20:58 +0000 (UTC) X-FDA: 82214283396.07.A4B7229 Received: from mail-il1-f176.google.com (mail-il1-f176.google.com [209.85.166.176]) by imf29.hostedemail.com (Postfix) with ESMTP id E7E11120010 for ; Mon, 10 Jun 2024 08:20:56 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of yisooan.dev@gmail.com designates 209.85.166.176 as permitted sender) smtp.mailfrom=yisooan.dev@gmail.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718007657; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yw3XhbiXJGCTPVwL3WdCXnveLeLITAMMgMc7zLy57jQ=; b=cy4DaVRfm4NRkw0taaROuL6KUcy8zfRMbfjz+WHx6IW4BBG8aPT8L67HB5/eA70tpdFsGr IKAmfYH+/cgdXWQYlnCwbS4A3TU50SpT8054mWZZ83qZsBylYMEO+VKCCYwbS+unubcleN Cp2AmVTqrmUJH8hr+l9Hih9+UgrB6ZU= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of yisooan.dev@gmail.com designates 209.85.166.176 as permitted sender) smtp.mailfrom=yisooan.dev@gmail.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718007657; a=rsa-sha256; cv=none; b=VdA/P3S+3wZmTUzPdbykF0XNX/tDvI5l364CZjZIennegv0/WrRZT96sTEx4e0ojQR5Nm8 NtkJs3g3j/Na5goIG2HnsOiMzHu8bX9EEG8rLsGUn08xhe93xS9c9C+ClP4gP2JVopXrs4 h3r4lVocamtwcH4Tql6WfyzKMy+S0AA= Received: by mail-il1-f176.google.com with SMTP id e9e14a558f8ab-375aafb9f13so2091325ab.3 for ; Mon, 10 Jun 2024 01:20:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718007656; x=1718612456; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yw3XhbiXJGCTPVwL3WdCXnveLeLITAMMgMc7zLy57jQ=; b=Kg+JgpyAP6BwegnrezkwN2+izHckyjgHRNn9qWcJst4GLbRL0RWJTBcOr8QnQEDwlc K3nHbAk0DzRlHBYZNejovz2AWUIp07Qy8ZJ6Xrc/84TLkyza61b0n8NIxXr5uRQIfo9C hHUR6Bdjg4Utxna5/mpurRKCz2ih3fUsH2O+Y9JQXIH5J4EYy1coX0Gc1wKCrKit4pla 0346nMTIc6/bbyPinfpfMV1C6RZlgZ2cfu/wmy9kYzOLSsY2gSxIBRZVPLPUAv/NLkcr rApBkbmsvzUdWC/39EousuO0c5s+SK5dEWBWoYLJ+KLIIcDQTKnzXe6nc7wNmIsu8S7Y lmKg== X-Forwarded-Encrypted: i=1; AJvYcCWFlytSLeKhrjNgbvoV5e5rxvQWU9ErfkXFICzUyAljJeoKHKocWxmvGtk26lRIqvXAIQeyNaZqmagT0zuSd2150Mc= X-Gm-Message-State: AOJu0YxG7a/RkOYsH/mBJffEmaKd5X1kQJdwELOPtlLrnylIn0Dhupfi g6Qexb8jlXAJZ9R2BfkUcgjP2plyrBT3zZK4ApZGottab11Y6zvSM2ocur4B X-Google-Smtp-Source: AGHT+IGoPXvvTXDjNJQlOEaQf+sGDxmiZ3HonAhz05I6XfhHeLscCMj+cRzp2xHO9RG2MM8xTDiCnA== X-Received: by 2002:a05:6e02:18c7:b0:36a:1104:2d6e with SMTP id e9e14a558f8ab-375802ee14amr107435705ab.1.1718007655576; Mon, 10 Jun 2024 01:20:55 -0700 (PDT) Received: from mail-il1-f181.google.com (mail-il1-f181.google.com. [209.85.166.181]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-375a7e3e68csm3266645ab.70.2024.06.10.01.20.55 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Jun 2024 01:20:55 -0700 (PDT) Received: by mail-il1-f181.google.com with SMTP id e9e14a558f8ab-37588517095so11559655ab.2 for ; Mon, 10 Jun 2024 01:20:55 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCUEUMyFSz+tUvhsySSEOrD+Voovt1DpJ31d+rAFLV+2wJM+1/+6vOhaw8DCNd3D7MNXUkbA3HN0RfZm4E1T/wqMwGk= X-Received: by 2002:a05:6e02:1c8b:b0:374:9427:6dd3 with SMTP id e9e14a558f8ab-375803a2d0dmr100405805ab.27.1718007655076; Mon, 10 Jun 2024 01:20:55 -0700 (PDT) MIME-Version: 1.0 References: <20240608152114.867961-1-lsahn@wewakecorp.com> <20240609140341.14ba3a1c62029771d60059ed@linux-foundation.org> In-Reply-To: From: Leesoo Ahn Date: Mon, 10 Jun 2024 17:20:44 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] mm: sparse: clarify a variable name and its value To: Mike Rapoport Cc: Andrew Morton , Leesoo Ahn , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: E7E11120010 X-Stat-Signature: fsjc4steczjrye3g6qx9fzkqwrbyt5na X-HE-Tag: 1718007656-597774 X-HE-Meta: U2FsdGVkX1+szzEswBpYm3Ps5+X8omJZB2c7EtyzSbdCGIk6nEPZfHOMbf7Z+pMAjgVeb+wFfXCJ0f8A5aIHvl9B+9z4vFTz07sQZgyUxRNP9udElwLC0BRudtSIB33Y2r0lgbKqkam39YmD+omhB6VEzKf7n09JAsnI0pLafaC/lHsUWgCcbU94JMlbSA4OGRg4iSmhLxXvn2oHmbt0k9x/lKtoOKfZ2AAXgJJK9TYjHr9MtyAaWo7OQnjB3dNWFnk6MCv9KONOKpYNbteSw5MELbvqRWPsCya4+SJPH24JCN8opOS1BwcRTSAMlBl7TQUsNCy7dMVp9VLoBiV16D3yScK9A75+MjOaNKaHktCoMaNFJwzWvorFyCGybrsX7H/etdYpXBF9nq17SY++UhSVhQkh/16GyzI6Wc49V1zQ3BKUggDima6BqEMvyZhZIH3st4eVhO01EQ1INhKE0H/GPJDWEjwfAPqiugNkwzXc28npl+t+iJm0+0weNNlu++dRQaMq2T4Zh64BC/1MeVRpsPxWNmVr3AG8vukHQvdTlc5E07HY139BcR/NTPOdo5k3GX8jwfdsX6/CiHpsFYi6Sn7OZeBgebzHwVs0FJxjPp4RF3jimRqPL+Oez13DWn3Xbqt92lxj1X4TN2Mca3tvjjb1eiuYM84uMLaImb78YnEqAGwV2zMazo6rVsIJLPuEqaxgDUNXSiavh0OwqLAa+vJwXu8UaqbPgoXCX2nmbcOgDehbxGSdiJI13iKaB+id5LAmtGd0dYvlPk44Va7hr2aD3f7+q4RAUUrFZH1+fSVK63ozSPRZ0NRx1DLfUqcgeHh9K8sW8tLoZ3xfCKVtGGIC0qvNGkHd05JhThsxC8anXaOuXYSphjpjQaTdlNonRsoIp9FBYPr5NBcmOseoS1XiLaCKSsWkmrdhHoHxOg/m+t9rUXS/bsx7pI4FN9f3qR/YA5iOWiY0+Xs 1QlMZddN c/+5ihrESSQ2D9Jv1vH/OXeor+KRoHtPz6ul5PlSawC3SnCLWcQFeN7d7G+N8gzHdVIe9zPjqH+yhaIzOU41XROPHUQ7m2mqg5Go7eRRI4eKpXhUWUDNpFRgJdqonWJV+RQSjDUfaHdN4drCol50zASsbx3tWsVGbZ/QM2pLJPDGZNLcfntmIP/lGk1bqd4F2Kal6fS77YfMIZVg8RndUuOyohjMqxz7WrpdlQFAo+HVn1MWT+1CvcxAKqggF1iyF1kLXw9n1pJDs0y0XYSk5n1NES4243/Hz4C69jDRYrF1Op/2OR3HF5KIfVlJm3o2mXfcD1Yn5yZFabi4vzL69yDyWx8fHu6YAeAnmxUfzjAnE5dxjzO53oNqsJ/KArsSXjLtx76jpZ5LqVsdYJ/agv+FW4TUyBwg2QV2d1zDWYGGxNe8Nra/qP3nb+B7ZGNIdbqZKRO+BAOr3MSYJPh4Y1LbAleWjYeZ256tS/vC8By0+9i0mkwU3SAHWLf5/MkqKra0324Wj6qXgQQ6gU9DoHr+ns6g3BIhm1U4H5hFGnOMWB1oo7YQ7x9KbZifRFpRQXEY+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 2024=EB=85=84 6=EC=9B=94 10=EC=9D=BC (=EC=9B=94) =EC=98=A4=ED=9B=84 3:08, M= ike Rapoport =EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1: > > On Mon, Jun 10, 2024 at 12:39:28PM +0900, Leesoo Ahn wrote: > > 2024=EB=85=84 6=EC=9B=94 10=EC=9D=BC (=EC=9B=94) =EC=98=A4=EC=A0=84 6:0= 3, Andrew Morton =EB=8B=98=EC=9D=B4 =EC=9E=91=EC= =84=B1: > > > > > > On Sun, 9 Jun 2024 00:21:14 +0900 Leesoo Ahn wrot= e: > > > > > > > Setting 'limit' variable to 0 might seem like it means "no limit". = But > > > > in the memblock API, 0 actually means the 'MEMBLOCK_ALLOC_ACCESSIBL= E' > > > > enum, which limits the physical address range based on > > > > 'memblock.current_limit'. This can be confusing. > > > > > > Does it? From my reading, this meaning applies to the range end > > > address, in memblock_find_in_range_node()? If your interpretation is > > > correct, this should be documented in the relevant memblock kerneldoc= . > > It is :-P > > > IMO, regardless of memblock documentation, it better uses > > MEMBLOCK_ALLOC_ACCESSIBLE enum instead of 0 as a value for the variable= . > > Using MEMBLOCK_ALLOC_ACCESSIBLE is a slight improvement, but renaming the > variable is not, IMO. I will post v2 as it replaces 0 with MEMBLOCK_ALLOC_ACCESSIBLE without modifying the variable. Thank you, Andrew and Mike for the reviews. > > > Best regards, > > Leesoo > > -- > Sincerely yours, > Mike. Best regards, Leesoo.