From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx131.postini.com [74.125.245.131]) by kanga.kvack.org (Postfix) with SMTP id 66EEF6B00A5 for ; Tue, 3 Jul 2012 19:16:17 -0400 (EDT) Received: by ghrr18 with SMTP id r18so7245594ghr.14 for ; Tue, 03 Jul 2012 16:16:16 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <4FF3662A.9070700@redhat.com> References: <1340315835-28571-1-git-send-email-riel@surriel.com> <1340315835-28571-2-git-send-email-riel@surriel.com> <20120629234638.GA27797@google.com> <4FF3662A.9070700@redhat.com> Date: Tue, 3 Jul 2012 16:16:15 -0700 Message-ID: Subject: Re: [PATCH -mm v2 01/11] mm: track free size between VMAs in VMA rbtree From: Michel Lespinasse Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org List-ID: To: Rik van Riel Cc: Rik van Riel , linux-mm@kvack.org, akpm@linux-foundation.org, aarcange@redhat.com, peterz@infradead.org, minchan@gmail.com, kosaki.motohiro@gmail.com, andi@firstfloor.org, hannes@cmpxchg.org, mel@csn.ul.ie, linux-kernel@vger.kernel.org On Tue, Jul 3, 2012 at 2:37 PM, Rik van Riel wrote: > On 06/29/2012 07:46 PM, Michel Lespinasse wrote: >> Basically, I think lib/rbtree.c should provide augmented rbtree support >> in the form of (versions of) rb_insert_color() and rb_erase() being able >> to >> callback to adjust the augmented node information around tree rotations, >> instead of using (conservative, overkill) loops to adjust the augmented >> node information after the fact > > That is what I originally worked on. > > I threw out that code after people told me (at LSF/MM) in > no uncertain terms that I should use the augmented rbtree > code :) Well, bummer. Could you summarize what their argument was ? In other words, what are the constraints besides not adding overhead to the scheduler rbtree use case and keeping the code size reasonable ? -- Michel "Walken" Lespinasse A program is never fully debugged until the last user dies. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org