From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0BE3C2D0EB for ; Sat, 28 Mar 2020 07:47:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5E09F206CC for ; Sat, 28 Mar 2020 07:47:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="WOVV8fRn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5E09F206CC Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D19076B0010; Sat, 28 Mar 2020 03:47:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CCAAB6B0032; Sat, 28 Mar 2020 03:47:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BDFE86B0036; Sat, 28 Mar 2020 03:47:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0157.hostedemail.com [216.40.44.157]) by kanga.kvack.org (Postfix) with ESMTP id AA1F36B0010 for ; Sat, 28 Mar 2020 03:47:20 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 7AB03585B for ; Sat, 28 Mar 2020 07:47:20 +0000 (UTC) X-FDA: 76643990640.12.star02_5d28947b7160a X-HE-Tag: star02_5d28947b7160a X-Filterd-Recvd-Size: 4499 Received: from mail-yb1-f196.google.com (mail-yb1-f196.google.com [209.85.219.196]) by imf42.hostedemail.com (Postfix) with ESMTP for ; Sat, 28 Mar 2020 07:47:20 +0000 (UTC) Received: by mail-yb1-f196.google.com with SMTP id f14so51058ybr.13 for ; Sat, 28 Mar 2020 00:47:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9jl+BpbHZ/7r9CkbFROQ9el447QHzytPcgY1mfe7n2I=; b=WOVV8fRn0QHeIZLcDiHRypp+CZ74Q7ALHPvHpNEf9Y72LLtBAWPEWhdu1+WfMmSslm UWERIzqxKzdnY73jCAj7ReOrGf9m58xY5hJxs0UaAj7e2o8D0tsas4KPyi2OOFj72j42 NcPNtcWWUeBSr0/fk6cAAnyzC0H1eLxJaBRjwjuZc4J6XKHlXGGVoUX1KsEM0hbZByjM IyS69XD5dopcswpVYiQCH5U4YbxNbvaNyXdpA2Jymn71KM7rMcTt02v5bCIDEmmRiPqa K+m9WQstmHWeSar87A5wR2lcItFBo/9UVt4aYJC3p7uxeZDf6bMcSe5NkkFbByv2Dkpq 0dmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9jl+BpbHZ/7r9CkbFROQ9el447QHzytPcgY1mfe7n2I=; b=RyChkPms2QpN1p23/I/Ttr3E06ZKjXmBaij413f/Z5uy4xURldN+BVN+P07/bpYHep UVJh1zK0hN/WvHVwl6QsDwncDLzFztzA8H5KELdXNKhU9QOlLyN4mr1En1hIgEnOr3N7 Goei6rlV4Y5JfF5TZwBDPa/EAxuX8VkJXC/sZoHg2qtz2cpYo7pebPgG6aj/yKlg4OQb 1VbmgBQ7e350L2tEeSqa3g70BaI0Q7dyum/qhaPtKATwbmz+J1QCb11lA/bfLVlrRkAj IbktuP/EawXWclWRZzzIA4SVpO9iVTFm3ETrWF0s4yTyDy7Cyws0g/2vogMBQ9iDC5iX 9CoA== X-Gm-Message-State: ANhLgQ2EcQXDi1VSs8cxRQVUkFiD7jQWqTp9zEmXgOKF3AMR85je+WwW 23/g6DrrkJqFiErnd/W/KF4k5ZK/bNbVc3aiq7os9w== X-Google-Smtp-Source: ADFU+vszhRv5ayaRSxIAK9LsFFYzkpzCnkWSEHJUDdkTE99yJa1AGlFn/ETcRFmuPn19IzHAqxLW++TFE8J8+cyA28Q= X-Received: by 2002:a5b:4ce:: with SMTP id u14mr1565259ybp.518.1585381638995; Sat, 28 Mar 2020 00:47:18 -0700 (PDT) MIME-Version: 1.0 References: <20200327225102.25061-1-walken@google.com> <20200327225102.25061-6-walken@google.com> In-Reply-To: From: Michel Lespinasse Date: Sat, 28 Mar 2020 00:47:06 -0700 Message-ID: Subject: Re: [PATCH v3 05/10] mmap locking API: convert mmap_sem call sites missed by coccinelle To: Markus Elfring Cc: Coccinelle , linux-mm , LKML , Peter Zijlstra , Laurent Dufour , Vlastimil Babka , Matthew Wilcox , Liam Howlett , Jerome Glisse , Davidlohr Bueso , David Rientjes , Hugh Dickins , Ying Han , Jason Gunthorpe , Andrew Morton Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Markus, On Sat, Mar 28, 2020 at 12:37 AM Markus Elfring wrote: > > Convert the last few remaining mmap_sem rwsem calls to use the new > > mmap locking API. These were missed by coccinelle for some reason > > Will the clarification of this software situation become more interesting? > > > (I think coccinelle does not support some of the preprocessor > > constructs in these files ?) > > I suggest to omit this information from the final change description. > Would you like to help any more to find nicer solutions > for remaining open issues? So, from a practical perspective I think coccinelle has filled its purpose for me - it got 99% of the job done, and I had to do the last 1% by hand which is not ideal, but really not too bad either. Also, by using coccinelle I think reviewers can appreciate that the change is purely mechanical, and reproduce it on their end if needed, which facilitates the review process greatly. I would be interested to find out why coccinelle wasn't able to do the last 1%, but only as part of a long-term learning process on getting better with coccinelle - I don't consider it a blocker for short-term progress on this patchset. -- Michel "Walken" Lespinasse A program is never fully debugged until the last user dies.