From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C5A0C433E0 for ; Thu, 4 Jun 2020 05:58:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C5883206C3 for ; Thu, 4 Jun 2020 05:58:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="oUoVxbUb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C5883206C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 09A01280010; Thu, 4 Jun 2020 01:58:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 04BF88000E; Thu, 4 Jun 2020 01:58:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA248280010; Thu, 4 Jun 2020 01:58:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CF8AB8000E for ; Thu, 4 Jun 2020 01:58:08 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 8B78B246A for ; Thu, 4 Jun 2020 05:58:08 +0000 (UTC) X-FDA: 76890473856.07.soap66_29ef670679c27 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin07.hostedemail.com (Postfix) with ESMTP id 6C1BB1803F9AD for ; Thu, 4 Jun 2020 05:58:08 +0000 (UTC) X-HE-Tag: soap66_29ef670679c27 X-Filterd-Recvd-Size: 4480 Received: from mail-yb1-f196.google.com (mail-yb1-f196.google.com [209.85.219.196]) by imf35.hostedemail.com (Postfix) with ESMTP for ; Thu, 4 Jun 2020 05:58:08 +0000 (UTC) Received: by mail-yb1-f196.google.com with SMTP id r18so2339289ybl.5 for ; Wed, 03 Jun 2020 22:58:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=TcecXJ2daa6cGmqdWJMR2w52jweMjWun9RPg5Xx26Sk=; b=oUoVxbUbbUwX+jqVje0MeoTNtiMgmXyOEt0P55vjxGaDiUwdB5boSWMXC5qxiHIr6n oH5tN5NQ8tlFDYaELXdiDSxZYA94TuAPFZymobINhFfNM9Rt64x3UGOlY3ny2Y/n0Tt4 upTqerbGn+z4FLDl4CpH9+tTEVmRXJWX+ai7XYwEFJMVei6Uuwn5GM38SMuSJGmHLD+d bm9z1lZ4n0hjrjzSQ9D/2zeGuVBlZMzvzZ+/eQ3DI9VVjRbGY4Jn/UIUqwyLWkRyKMUV FGQk7qAf85qHNcGVkIovlPenvMYIKb6vyR4ieMxUAZnuNgqIZDnNx7CfX3WhoYYEiLJu MlIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=TcecXJ2daa6cGmqdWJMR2w52jweMjWun9RPg5Xx26Sk=; b=mFyMEoUHx+8N6SelfATB+bg58MRQwQoKLSWg1o59FAf5LAJq9wuEn2Ht9ZdkWAvGal Ndw82HEP44bTgcwcgoxjpkQLFplpCw2ZGxxUeMpLWz1WAyccLfLewjyhqdu6GxVrv2fW NqtTBm3Rn7Ww8nbvMpHQZulSXovcq83QfMphc87SEhhq1Rd2f+D99BrvsS6MZc4KDg1M viRCKLtVqo95cyCoykY3xkZAWViI+2yNbvyQuucobQqrOkNoP9OEdfhcfRL6ZXxQFeyt 1rz0ACqfO3js1OY/dTjGMVFls82YB/3YeF4D/CgFt7NW+qqFp67806M3Zmb49dI/tlJz oXsw== X-Gm-Message-State: AOAM531UJpWeTuRryLjM/gHbTxC0kVfwRMnrHK7m6SLYpJwX1wX4bsfP W6Ej/fFcM250ciFVZgXj7vJKwa9W9ckQLWp8RcV+rw== X-Google-Smtp-Source: ABdhPJz/qUrBneza/kk1XNsMraG+yR1nVfzjN8vISQMME/8LCOncoIqe5jfJOCcLFgu1zEUfo01cpPMgqx4ebSdFjvM= X-Received: by 2002:a25:bcc2:: with SMTP id l2mr5137096ybm.298.1591250287067; Wed, 03 Jun 2020 22:58:07 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Michel Lespinasse Date: Wed, 3 Jun 2020 22:57:53 -0700 Message-ID: Subject: Re: [PATCH v6 10/12] mmap locking API: rename mmap_sem to mmap_lock To: youling 257 Cc: "Liam R . Howlett" , Andrew Morton , Daniel Jordan , Davidlohr Bueso , Hugh Dickins , Jason Gunthorpe , Jerome Glisse , John Hubbard , Laurent Dufour , LKML , linux-mm , Peter Zijlstra , David Rientjes , Vlastimil Babka , Matthew Wilcox , Ying Han Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 6C1BB1803F9AD X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 3, 2020 at 9:35 PM youling 257 wrote: > I have build error about kernel/sys.c, > > kernel/sys.c: In function =E2=80=98prctl_set_vma=E2=80=99: > kernel/sys.c:2392:18: error: > =E2=80=98struct mm_struct=E2=80=99 has no member named =E2=80=98mmap_sem= =E2=80=99; did you mean > =E2=80=98mmap_base=E2=80=99? > 2392 | down_write(&mm->mmap_sem); > | ^~~~~~~~ > | mmap_base > kernel/sys.c:2402:16: error: > =E2=80=98struct mm_struct=E2=80=99 has no member named =E2=80=98mmap_sem= =E2=80=99; did you mean > =E2=80=98mmap_base=E2=80=99? > 2402 | up_write(&mm->mmap_sem); > | ^~~~~~~~ > | mmap_base > > why not rename kernel/sys.c mmap_sem to mmap_lock? The proper fix would be to use the mmap locking apis defined in include/linux/mmap_lock.h instead. However I would like more information about your report. Did you apply the series yourself ? If so, what base tree did you apply it onto ? If not, what tree did you use that already included the series ? Thanks, --=20 Michel "Walken" Lespinasse A program is never fully debugged until the last user dies.