From: Michel Lespinasse <walken@google.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, Andrea Arcangeli <aarcange@redhat.com>,
Rik van Riel <riel@redhat.com>, Dave Jones <davej@redhat.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] mm, thp: close race between mremap() and split_huge_page()
Date: Wed, 7 May 2014 17:13:32 -0700 [thread overview]
Message-ID: <CANN689GqmdRpOOHV7uYCLgu+xKcYQ5_ESw7+-djNpVGo=D-+WQ@mail.gmail.com> (raw)
In-Reply-To: <20140506130655.GE19914@cmpxchg.org>
My bad for introducing the bug, and thanks Kirill for fixing it.
Acked-by: Michel Lespinasse <walken@google.com>
On Tue, May 6, 2014 at 6:06 AM, Johannes Weiner <hannes@cmpxchg.org> wrote:
> On Tue, May 06, 2014 at 01:13:31AM +0300, Kirill A. Shutemov wrote:
>> But on move_vma() destination VMA can be merged into adjacent one and as
>> result shifted left in interval tree. Fortunately, we can detect the
>> situation and prevent race with rmap walk by moving page table entries
>> under rmap lock. See commit 38a76013ad80.
Yup, forgot to take care of the THP case there...
> Fixes: 108d6642ad81 ("mm anon rmap: remove anon_vma_moveto_tail")
I think 108d6642ad81 on its own was OK (as it always took the locks);
but the attempt to not take them in the common case in 38a76013ad80 is
where I forgot to consider the THP case.
--
Michel "Walken" Lespinasse
A program is never fully debugged until the last user dies.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-05-08 0:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-05 22:13 Kirill A. Shutemov
2014-05-06 8:43 ` Kirill A. Shutemov
2014-05-07 20:55 ` David Miller
2014-05-06 13:06 ` Johannes Weiner
2014-05-08 0:13 ` Michel Lespinasse [this message]
2014-05-08 18:14 ` Johannes Weiner
2014-05-09 8:44 ` Michel Lespinasse
2014-05-06 14:13 ` Andrea Arcangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANN689GqmdRpOOHV7uYCLgu+xKcYQ5_ESw7+-djNpVGo=D-+WQ@mail.gmail.com' \
--to=walken@google.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=davej@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-mm@kvack.org \
--cc=riel@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox