From: Michel Lespinasse <walken@google.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: riel@redhat.com, daniel.santos@pobox.com, aarcange@redhat.com,
dwmw2@infradead.org, akpm@linux-foundation.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
torvalds@linux-foundation.org
Subject: Re: [PATCH v2 3/9] rbtree: add __rb_change_child() helper function
Date: Mon, 6 Aug 2012 17:04:18 -0700 [thread overview]
Message-ID: <CANN689GZQ4pYuqzB9ZQ0QBatvsDgj60_ciG5MBHqsKdb5CYtyQ@mail.gmail.com> (raw)
In-Reply-To: <1344262930.27828.57.camel@twins>
On Mon, Aug 6, 2012 at 7:22 AM, Peter Zijlstra <peterz@infradead.org> wrote:
> On Thu, 2012-08-02 at 15:34 -0700, Michel Lespinasse wrote:
>> +static inline void
>
> I would make that __always_inline, just to make sure GCC doesn't go
> creative on us.
How strongly do you care ? I'm not sure it makes sense to change it
unless we also change every other inline function in that file. I'd
rather not do that until we hear of gcc actually breaking things.
(BTW, did you know that sometimes gcc generates different code when
you change from inline to always_inline, even though things were
already inlined before ? I really hate dealing with gcc crap like
that, makes me want to forget about inline functions and just do it
all with preprocessor abuse...)
--
Michel "Walken" Lespinasse
A program is never fully debugged until the last user dies.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-08-07 0:04 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-02 22:34 [PATCH v2 0/9] faster augmented rbtree interface Michel Lespinasse
2012-08-02 22:34 ` [PATCH v2 1/9] rbtree test: fix sparse warning about 64-bit constant Michel Lespinasse
2012-08-05 20:47 ` Rik van Riel
2012-08-02 22:34 ` [PATCH v2 2/9] rbtree: optimize fetching of sibling node Michel Lespinasse
2012-08-05 23:20 ` Rik van Riel
2012-08-06 14:23 ` Peter Zijlstra
2012-08-06 20:46 ` Michel Lespinasse
2012-08-02 22:34 ` [PATCH v2 3/9] rbtree: add __rb_change_child() helper function Michel Lespinasse
2012-08-06 1:00 ` Rik van Riel
2012-08-06 14:22 ` Peter Zijlstra
2012-08-07 0:04 ` Michel Lespinasse [this message]
2012-08-02 22:34 ` [PATCH v2 4/9] rbtree: place easiest case first in rb_erase() Michel Lespinasse
2012-08-06 1:13 ` Rik van Riel
2012-08-02 22:34 ` [PATCH v2 5/9] rbtree: handle 1-child recoloring in rb_erase() instead of rb_erase_color() Michel Lespinasse
2012-08-06 1:27 ` Rik van Riel
2012-08-02 22:34 ` [PATCH v2 6/9] rbtree: low level optimizations in rb_erase() Michel Lespinasse
2012-08-06 1:41 ` Rik van Riel
2012-08-06 14:21 ` Peter Zijlstra
2012-08-06 20:50 ` Michel Lespinasse
2012-08-06 20:58 ` Peter Zijlstra
2012-08-06 21:20 ` Michel Lespinasse
2012-08-06 21:21 ` Michel Lespinasse
2012-08-02 22:34 ` [PATCH v2 7/9] rbtree: augmented rbtree test Michel Lespinasse
2012-08-06 2:11 ` Rik van Riel
2012-08-02 22:34 ` [PATCH v2 8/9] rbtree: faster augmented rbtree manipulation Michel Lespinasse
2012-08-06 2:12 ` Rik van Riel
2012-08-06 14:17 ` Peter Zijlstra
2012-08-06 15:38 ` Peter Zijlstra
2012-08-06 21:55 ` Michel Lespinasse
2012-08-07 7:12 ` [PATCH] rbtree: add RB_DECLARE_CALLBACKS() macro Michel Lespinasse
2012-08-06 14:25 ` [PATCH v2 8/9] rbtree: faster augmented rbtree manipulation Peter Zijlstra
2012-08-06 21:34 ` Michel Lespinasse
2012-08-06 21:36 ` Peter Zijlstra
2012-08-06 14:29 ` Peter Zijlstra
2012-08-06 21:38 ` Michel Lespinasse
2012-08-02 22:34 ` [PATCH v2 9/9] rbtree: remove prior augmented rbtree implementation Michel Lespinasse
2012-08-02 22:41 ` Joe Perches
2012-08-06 2:13 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANN689GZQ4pYuqzB9ZQ0QBatvsDgj60_ciG5MBHqsKdb5CYtyQ@mail.gmail.com \
--to=walken@google.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=daniel.santos@pobox.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox