From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A623C433DF for ; Thu, 21 May 2020 07:51:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D4CC32065F for ; Thu, 21 May 2020 07:51:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="jfInfF5V" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D4CC32065F Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 789A88001E; Thu, 21 May 2020 03:51:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 73CFD80007; Thu, 21 May 2020 03:51:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 62AB28001E; Thu, 21 May 2020 03:51:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0192.hostedemail.com [216.40.44.192]) by kanga.kvack.org (Postfix) with ESMTP id 49DE180007 for ; Thu, 21 May 2020 03:51:11 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 0D4D78248047 for ; Thu, 21 May 2020 07:51:11 +0000 (UTC) X-FDA: 76839955542.26.metal05_448023cb42841 X-HE-Tag: metal05_448023cb42841 X-Filterd-Recvd-Size: 4330 Received: from mail-yb1-f196.google.com (mail-yb1-f196.google.com [209.85.219.196]) by imf29.hostedemail.com (Postfix) with ESMTP for ; Thu, 21 May 2020 07:51:10 +0000 (UTC) Received: by mail-yb1-f196.google.com with SMTP id i16so2375816ybq.9 for ; Thu, 21 May 2020 00:51:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3cTYxMrSpTH1mIGr8IELAXemAW00cOr39cI8SC00UUE=; b=jfInfF5Vaq1mZYqYs8FyBhwBLOKmCd4a/4uLJStVBxanYTxpkTlKh1W2dzjaslTv5/ DgSbzp9xZ2C3OzEP/86Lq1iTi60P4TIhoV8RFGX2m/TSGWTOqaGlJvYbmfiDng56l8HE kElvZWD9Dsv7UIAdDOlriuXjPw/p4nlC/MfiFqCDD7VS5AziCXLouPNMPhXdoi1+njSn 5Kq9USdaxKow8NDx5ctFyf73MicYJNmt5MGFzXZUJQTIRyvOJKklOLdY0WN7XK8zgKVL gMiLVjtXjCnYmfQDcEuGzcWZdCyi58MGTCFEtlLXQs4dTFln74NIvD9dkxZxebWXRHrN TlCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3cTYxMrSpTH1mIGr8IELAXemAW00cOr39cI8SC00UUE=; b=FVp1JsgnPFNm/9c+j+YCLWWqLCa0PI6Qv+xK3wPNQNBFAyvDKS9jmvlzxu3twkQp5e 38KCaDieEZC3fXMBcDWVxV/MGhuy2byNLEsBVK7rIyGGw43avWVzGttx0hekqTxrA++Y rpZCb2TmuKFLkpBLGMqLFPlBPfc+lc2RZMGxdj4V7TmCSE/5/dtMgsZO5WxmZEMP2IjP Xnzf7cRNiM54INVoBemDhHzaQw10fE6TdWTEZbsiA3b4hNWq24CzYsbUwm2D4v5LTVYt fp35sI/fy2VtPCtpEZ6E3/hdqzk2Fa2B6wxN9bib47CC+eEUvzzh7DF5Ptg4obZJKKL7 MExA== X-Gm-Message-State: AOAM532nRiwMzLVT1CxlUfvBU7OqI3SPNoi0JhN4+oWw4Y7sV3M0Mf9n 5yJo+uDE0gsLDHJtK6netik46g5/cKtM/G9KLZgrfQ== X-Google-Smtp-Source: ABdhPJyQgfCui8+ZbyhTJRLwncCPT4GDdW7VWSscqDMZqF1XY4ezNuE9uYBObDdaHkFHfxCjWtEIQIWzksQA0BCBWTs= X-Received: by 2002:a5b:383:: with SMTP id k3mr13411552ybp.332.1590047469660; Thu, 21 May 2020 00:51:09 -0700 (PDT) MIME-Version: 1.0 References: <20200520052908.204642-1-walken@google.com> <20200520052908.204642-13-walken@google.com> In-Reply-To: From: Michel Lespinasse Date: Thu, 21 May 2020 00:50:56 -0700 Message-ID: Subject: Re: [PATCH v6 12/12] mmap locking API: convert mmap_sem comments To: Vlastimil Babka Cc: Andrew Morton , linux-mm , LKML , Peter Zijlstra , Laurent Dufour , Matthew Wilcox , Liam Howlett , Jerome Glisse , Davidlohr Bueso , David Rientjes , Hugh Dickins , Ying Han , Jason Gunthorpe , Daniel Jordan , John Hubbard Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 21, 2020 at 12:42 AM Vlastimil Babka wrote: > On 5/20/20 7:29 AM, Michel Lespinasse wrote: > > Convert comments that reference mmap_sem to reference mmap_lock instead. > > > > Signed-off-by: Michel Lespinasse > > Reviewed-by: Vlastimil Babka > > But: > > > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > > index a1247d3553da..1bf46e2e0cec 100644 > > --- a/mm/mempolicy.c > > +++ b/mm/mempolicy.c > > @@ -224,7 +224,7 @@ static int mpol_new_bind(struct mempolicy *pol, const nodemask_t *nodes) > > * handle an empty nodemask with MPOL_PREFERRED here. > > * > > * Must be called holding task's alloc_lock to protect task's mems_allowed > > - * and mempolicy. May also be called holding the mmap_semaphore for write. > > + * and mempolicy. May also be called holding the mmap_lockaphore for write. > > */ > > static int mpol_set_nodemask(struct mempolicy *pol, > > const nodemask_t *nodes, struct nodemask_scratch *nsc) > > :) Haha, good catch ! -- Michel "Walken" Lespinasse A program is never fully debugged until the last user dies.