From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx108.postini.com [74.125.245.108]) by kanga.kvack.org (Postfix) with SMTP id 462926B004F for ; Sat, 17 Dec 2011 19:43:12 -0500 (EST) Received: by iacb35 with SMTP id b35so6071505iac.14 for ; Sat, 17 Dec 2011 16:43:11 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: Date: Sat, 17 Dec 2011 16:43:11 -0800 Message-ID: Subject: Re: [PATCH] Use 'do {} while (0)' for empty flush_tlb_fix_spurious_fault() macro From: Michel Lespinasse Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Sender: owner-linux-mm@kvack.org List-ID: To: Jesper Juhl Cc: x86@kernel.org, Eric Dumazet , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Hugh Dickins , Andrea Arcangeli , KAMEZAWA Hiroyuki , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Rik van Riel , Mel Gorman , Johannes Weiner On Sat, Dec 17, 2011 at 4:32 PM, Jesper Juhl wrote: > If one builds the kernel with -Wempty-body one gets this warning: > > =A0mm/memory.c:3432:46: warning: suggest braces around empty body in an = =91if=92 statement [-Wempty-body] > > due to the fact that 'flush_tlb_fix_spurious_fault' is a macro that > can sometimes be defined to nothing. > > Signed-off-by: Jesper Juhl Looks good to me. I'd be happy with either that or Al's alternative suggest= ion. Reviewed-by: Michel Lespinasse --=20 Michel "Walken" Lespinasse A program is never fully debugged until the last user dies. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org