From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx147.postini.com [74.125.245.147]) by kanga.kvack.org (Postfix) with SMTP id 3895D6B0005 for ; Sun, 7 Apr 2013 06:13:59 -0400 (EDT) Received: by mail-qa0-f51.google.com with SMTP id i20so413520qad.17 for ; Sun, 07 Apr 2013 03:13:58 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1365326292-2761-1-git-send-email-k80ck80c@gmail.com> References: <1365326292-2761-1-git-send-email-k80ck80c@gmail.com> Date: Sun, 7 Apr 2013 03:13:57 -0700 Message-ID: Subject: Re: [PATCH 1/1] mmap.c: find_vma: eliminate initial if(mm) check From: Michel Lespinasse Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org List-ID: To: k80c Cc: Andrew Morton , Rik van Riel , Al Viro , Ingo Molnar , linux-mm@kvack.org, linux-kernel@vger.kernel.org On Sun, Apr 7, 2013 at 2:18 AM, k80c wrote: > As per commit 841e31e5cc6219d62054788faa289b6ed682d068, > we dont really need this if(mm) check anymore. > > A WARN_ON_ONCE was added just for safety, but there have been no bug > reports about this so far. > > Removing this if(mm) check. > > Signed-off-by: k80c > --- > mm/mmap.c | 3 --- > 1 files changed, 0 insertions(+), 3 deletions(-) > > diff --git a/mm/mmap.c b/mm/mmap.c > index 0db0de1..b2c363f 100644 > --- a/mm/mmap.c > +++ b/mm/mmap.c > @@ -1935,9 +1935,6 @@ struct vm_area_struct *find_vma(struct mm_struct *mm, unsigned long addr) > { > struct vm_area_struct *vma = NULL; > > - if (WARN_ON_ONCE(!mm)) /* Remove this in linux-3.6 */ > - return NULL; > - > /* Check the cache first. */ > /* (Cache hit rate is typically around 35%.) */ > vma = ACCESS_ONCE(mm->mmap_cache); Looks good to me. Reviewed-by: Michel Lespinasse -- Michel "Walken" Lespinasse A program is never fully debugged until the last user dies. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org