From: Michel Lespinasse <walken@google.com>
To: Davidlohr Bueso <davidlohr@hp.com>
Cc: Sasha Levin <sasha.levin@oracle.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
Rik van Riel <riel@redhat.com>, Vlastimil Babka <vbabka@suse.cz>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: mm: mmap_sem lock assertion failure in __mlock_vma_pages_range
Date: Tue, 11 Mar 2014 14:59:47 -0700 [thread overview]
Message-ID: <CANN689G2Mv+1zr0MgF17uA2GwKaCcEp-ckE=j5YzXHBxjP0tLA@mail.gmail.com> (raw)
In-Reply-To: <1394568453.2786.28.camel@buesod1.americas.hpqcorp.net>
On Tue, Mar 11, 2014 at 1:07 PM, Davidlohr Bueso <davidlohr@hp.com> wrote:
> On Tue, 2014-03-11 at 15:39 -0400, Sasha Levin wrote:
>> I've ended up deleting the log file by mistake, but this bug does seem to be important
>> so I'd rather not wait before the same issue is triggered again.
>>
>> The call chain is:
>>
>> mlock (mm/mlock.c:745)
>> __mm_populate (mm/mlock.c:700)
>> __mlock_vma_pages_range (mm/mlock.c:229)
>> VM_BUG_ON(!rwsem_is_locked(&mm->mmap_sem));
>
> So __mm_populate() is only called by mlock(2) and this VM_BUG_ON seems
> wrong as we call it without the lock held:
Not related to the bug, but please note that __mm_populate() is public
and has other call sites outside of mlock.c - namely, it is called
during mmap with MAP_POPULATE.
--
Michel "Walken" Lespinasse
A program is never fully debugged until the last user dies.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2014-03-11 21:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 19:39 Sasha Levin
2014-03-11 20:07 ` Davidlohr Bueso
2014-03-11 20:12 ` Sasha Levin
2014-03-11 20:21 ` Davidlohr Bueso
2014-03-11 20:30 ` Andrew Morton
2014-03-11 20:35 ` Sasha Levin
2014-03-11 20:42 ` Davidlohr Bueso
2014-03-11 20:45 ` Sasha Levin
2014-03-11 20:47 ` Davidlohr Bueso
2014-03-11 20:57 ` Dave Jones
2014-03-11 21:02 ` Sasha Levin
2014-03-11 21:45 ` Davidlohr Bueso
2014-03-11 22:20 ` Sasha Levin
2014-03-13 19:00 ` Davidlohr Bueso
2014-03-13 20:57 ` Hugh Dickins
2014-03-14 16:14 ` Sasha Levin
2014-03-11 21:59 ` Michel Lespinasse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANN689G2Mv+1zr0MgF17uA2GwKaCcEp-ckE=j5YzXHBxjP0tLA@mail.gmail.com' \
--to=walken@google.com \
--cc=akpm@linux-foundation.org \
--cc=davidlohr@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@redhat.com \
--cc=sasha.levin@oracle.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox