From: Michel Lespinasse <walken@google.com>
To: David Rientjes <rientjes@google.com>
Cc: Christoph Lameter <cl@gentwo.org>,
akpm@linux-foundation.org, linux-mm@kvack.org,
Mel Gorman <mel@csn.ul.ie>
Subject: Re: mm: Do not drain pagevecs for mlockall(MCL_FUTURE)
Date: Fri, 7 Oct 2011 21:28:18 -0700 [thread overview]
Message-ID: <CANN689FHhkkWu+1b+rHqSDLiV9Pp=LX8-Xsab2o=uocwEOOOMA@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1110071943060.13992@chino.kir.corp.google.com>
On Fri, Oct 7, 2011 at 7:45 PM, David Rientjes <rientjes@google.com> wrote:
> On Fri, 7 Oct 2011, Christoph Lameter wrote:
>> - lru_add_drain_all(); /* flush pagevec */
>> + if (flags & MCL_CURRENT)
>> + lru_add_drain_all(); /* flush pagevec */
>
> I understand the intention of lru_add_drain_all() to try to avoid a
> later failure when moving to the unevictable list and why flushing it's
> necessary for MCL_FUTURE, but I think this should be written
>
> if (!(flags & MCL_FUTURE))
> ...
>
> since flags may be extended sometime in the future.
When flags == (MCL_CURRENT | MCL_FUTURE), we do want to flush the
pagevecs as in the straight MCL_CURRENT case, so I think Christoph's
version is the correct one.
--
Michel "Walken" Lespinasse
A program is never fully debugged until the last user dies.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-10-08 4:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-07 20:32 Christoph Lameter
2011-10-08 2:45 ` David Rientjes
2011-10-08 4:28 ` Michel Lespinasse [this message]
2011-10-08 9:43 ` Minchan Kim
2011-10-10 16:15 ` KOSAKI Motohiro
2011-10-12 14:57 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANN689FHhkkWu+1b+rHqSDLiV9Pp=LX8-Xsab2o=uocwEOOOMA@mail.gmail.com' \
--to=walken@google.com \
--cc=akpm@linux-foundation.org \
--cc=cl@gentwo.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox