From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D33DFC54FCC for ; Tue, 21 Apr 2020 22:20:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6FA62206D5 for ; Tue, 21 Apr 2020 22:20:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="skhg49Ka" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6FA62206D5 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E93EE8E0005; Tue, 21 Apr 2020 18:20:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E440C8E0003; Tue, 21 Apr 2020 18:20:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D33438E0005; Tue, 21 Apr 2020 18:20:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0094.hostedemail.com [216.40.44.94]) by kanga.kvack.org (Postfix) with ESMTP id B84398E0003 for ; Tue, 21 Apr 2020 18:20:02 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 7CD503CEA for ; Tue, 21 Apr 2020 22:20:02 +0000 (UTC) X-FDA: 76733281044.23.scale69_579f5a9fce001 X-HE-Tag: scale69_579f5a9fce001 X-Filterd-Recvd-Size: 7312 Received: from mail-yb1-f193.google.com (mail-yb1-f193.google.com [209.85.219.193]) by imf43.hostedemail.com (Postfix) with ESMTP for ; Tue, 21 Apr 2020 22:20:02 +0000 (UTC) Received: by mail-yb1-f193.google.com with SMTP id o198so128650ybg.10 for ; Tue, 21 Apr 2020 15:20:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MC0jPjUAF87njqcFfXpyBAMtvGlBWKw+opsjZyshW2I=; b=skhg49KaofoTpg/aElVY1IA1b6I+SlbfFSQAkyPYZus3M01ys9T36s4EGHkzpC/q6I 5lGZ9hcZGO905lQWFO4mXczkMMhvSolqnLwFEb7xXzyHhvSYCtTS9LQcvj48kyHYt2Y+ KJPxcGsKVzVvCqqZezgqCriIRAmVxeNaWV31jvWJOeTibs7fO4i6k5Ay+TOz3sPQiFgu jZVxVCp9dAGconaL5tfrQp8awoZLa/XFvZdyfW+Bo73s+aylPaUJb75abnh5ssju7gnj XdArXert6bzfC7lE5DgVwrKZ7XGDdejF9XCBpg6L9lo4X2RXOYya8lruwsqjA3wIeR8R 9VYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MC0jPjUAF87njqcFfXpyBAMtvGlBWKw+opsjZyshW2I=; b=oqai5VoiqC7CmqIE6UTH98TCNzQ1y2cD6LzJxJEGc6kSBw9FCV2+LyqLmBGhggtSJo qiViToRfWFlWGqUu+uCKKB+HDKVR0NfdIkxenc+2HLElLRApQ/Wgz0dvb+gtkQBY/ho3 qDms42bxUgLG73x5kWidslcbljJ/Zb44BLQbCeFVPwGpqGpPYdFQ8F19nAz7GFrcg7EZ BCQCYfBfjf36xnaJnSExFL3amLHeySH5+EGNXU9P+yqoYmRBB0hTsDnHEwaKQG7Q7OE1 K4reCVwjlO3TxNmQusReBXqOFnNeElGOxcjvCnKmC/qZbuW3aZD4GHpuZrddwHOxq04R MygQ== X-Gm-Message-State: AGi0PubnvYdh0nK/hOisQ+HpALJ4JV92sgCFRXlFa5Gw56AbsNJ1v2ji GdwIVeNoJM/grS5NIE3ZOCwL4nf1pbkcYXbaFDuQvg== X-Google-Smtp-Source: APiQypK37BYP/Eez/Zhebxt8WCtCGQeewVQKmA9gIxCYMCxous5sLNrFWuF47M2PAkh4q4K5DT6nrBgQ+I3osamIpgI= X-Received: by 2002:a25:12c1:: with SMTP id 184mr21241316ybs.162.1587507601048; Tue, 21 Apr 2020 15:20:01 -0700 (PDT) MIME-Version: 1.0 References: <20200415004353.130248-11-walken@google.com> <202004211357.utKPLP8t%lkp@intel.com> In-Reply-To: <202004211357.utKPLP8t%lkp@intel.com> From: Michel Lespinasse Date: Tue, 21 Apr 2020 15:19:48 -0700 Message-ID: Subject: Re: [PATCH v4 10/10] mmap locking API: rename mmap_sem to mmap_lock To: kbuild test robot Cc: Andrew Morton , kbuild-all@lists.01.org, Linux Memory Management List , LKML , Peter Zijlstra , Laurent Dufour , Vlastimil Babka , Matthew Wilcox , Liam Howlett , Jerome Glisse , Davidlohr Bueso , David Rientjes Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Thanks for the report. It's an easy fix, which I will fold into change 05/10 of the series. On Mon, Apr 20, 2020 at 10:34 PM kbuild test robot wrote: > > Hi Michel, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on rdma/for-next] > [also build test ERROR on kvms390/next linus/master v5.7-rc2] > [cannot apply to powerpc/next uml/linux-next next-20200420] > [if your patch is applied to the wrong git tree, please drop us a note to help > improve the system. BTW, we also suggest to use '--base' option to specify the > base tree in git format-patch, please see https://stackoverflow.com/a/37406982] > > url: https://github.com/0day-ci/linux/commits/Michel-Lespinasse/Add-a-new-mmap-locking-API-wrapping-mmap_sem-calls/20200415-084649 > base: https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git for-next > config: riscv-randconfig-a001-20200421 (attached as .config) > compiler: riscv64-linux-gcc (GCC) 9.3.0 > reproduce: > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=riscv > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kbuild test robot > > All errors (new ones prefixed by >>): > > arch/riscv/mm/pageattr.c: In function '__set_memory': > >> arch/riscv/mm/pageattr.c:120:21: error: 'struct mm_struct' has no member named 'mmap_sem'; did you mean 'mmap_base'? > 120 | down_read(&init_mm.mmap_sem); > | ^~~~~~~~ > | mmap_base > arch/riscv/mm/pageattr.c:123:19: error: 'struct mm_struct' has no member named 'mmap_sem'; did you mean 'mmap_base'? > 123 | up_read(&init_mm.mmap_sem); > | ^~~~~~~~ > | mmap_base > > vim +120 arch/riscv/mm/pageattr.c > > d3ab332a502123 Zong Li 2020-03-10 105 > d3ab332a502123 Zong Li 2020-03-10 106 static int __set_memory(unsigned long addr, int numpages, pgprot_t set_mask, > d3ab332a502123 Zong Li 2020-03-10 107 pgprot_t clear_mask) > d3ab332a502123 Zong Li 2020-03-10 108 { > d3ab332a502123 Zong Li 2020-03-10 109 int ret; > d3ab332a502123 Zong Li 2020-03-10 110 unsigned long start = addr; > d3ab332a502123 Zong Li 2020-03-10 111 unsigned long end = start + PAGE_SIZE * numpages; > d3ab332a502123 Zong Li 2020-03-10 112 struct pageattr_masks masks = { > d3ab332a502123 Zong Li 2020-03-10 113 .set_mask = set_mask, > d3ab332a502123 Zong Li 2020-03-10 114 .clear_mask = clear_mask > d3ab332a502123 Zong Li 2020-03-10 115 }; > d3ab332a502123 Zong Li 2020-03-10 116 > d3ab332a502123 Zong Li 2020-03-10 117 if (!numpages) > d3ab332a502123 Zong Li 2020-03-10 118 return 0; > d3ab332a502123 Zong Li 2020-03-10 119 > d3ab332a502123 Zong Li 2020-03-10 @120 down_read(&init_mm.mmap_sem); > d3ab332a502123 Zong Li 2020-03-10 121 ret = walk_page_range_novma(&init_mm, start, end, &pageattr_ops, NULL, > d3ab332a502123 Zong Li 2020-03-10 122 &masks); > d3ab332a502123 Zong Li 2020-03-10 123 up_read(&init_mm.mmap_sem); > d3ab332a502123 Zong Li 2020-03-10 124 > d3ab332a502123 Zong Li 2020-03-10 125 flush_tlb_kernel_range(start, end); > d3ab332a502123 Zong Li 2020-03-10 126 > d3ab332a502123 Zong Li 2020-03-10 127 return ret; > d3ab332a502123 Zong Li 2020-03-10 128 } > d3ab332a502123 Zong Li 2020-03-10 129 > > :::::: The code at line 120 was first introduced by commit > :::::: d3ab332a5021235a74fd832a49c6a99404920d88 riscv: add ARCH_HAS_SET_MEMORY support > > :::::: TO: Zong Li > :::::: CC: Palmer Dabbelt > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org -- Michel "Walken" Lespinasse A program is never fully debugged until the last user dies.