From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx158.postini.com [74.125.245.158]) by kanga.kvack.org (Postfix) with SMTP id 894426B0070 for ; Fri, 31 Aug 2012 04:39:49 -0400 (EDT) Received: by iagk10 with SMTP id k10so5877786iag.14 for ; Fri, 31 Aug 2012 01:39:49 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <5040775C.3070205@intel.com> References: <1342139517-3451-1-git-send-email-walken@google.com> <1342139517-3451-8-git-send-email-walken@google.com> <50406F60.5040707@intel.com> <20120831011541.ddf8ed78.akpm@linux-foundation.org> <5040775C.3070205@intel.com> Date: Fri, 31 Aug 2012 01:39:48 -0700 Message-ID: Subject: Re: [PATCH v2 07/12] rbtree: adjust root color in rb_insert_color() only when necessary From: Michel Lespinasse Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org List-ID: To: Adrian Hunter Cc: "Shishkin, Alexander" , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, acme@redhat.com On Fri, Aug 31, 2012 at 1:35 AM, Adrian Hunter wrote: > On 31/08/12 11:15, Andrew Morton wrote: >> On Fri, 31 Aug 2012 01:07:24 -0700 Michel Lespinasse wrote: >>> I thought Andrew had a patch >>> rbtree-adjust-root-color-in-rb_insert_color-only-when-necessary-fix-perf-compilation >>> that fixed this though a Makefile change ? >> >> Yup. But it's unclear why we should include the header via the cc >> command line? > > Dunno > > AFAICS tools/perf/util/include/linux is for fixing up the > differences between kernel headers and exported kernel headers. > Hence my change: > > diff --git a/tools/perf/util/include/linux/rbtree.h b/tools/perf/util/include/linux/rbtree.h > index 7a243a1..2a030c5 100644 > --- a/tools/perf/util/include/linux/rbtree.h > +++ b/tools/perf/util/include/linux/rbtree.h > @@ -1 +1,2 @@ > +#include > #include "../../../../include/linux/rbtree.h" > > Alex? Ah, makes sense to me. I wasn't previously aware of the tools/perf/util/include/linux directory. I think your fix is fine. (I don't understand how you hit the issue given the previous Makefile fix, but I think your fix looks nicer) -- Michel "Walken" Lespinasse A program is never fully debugged until the last user dies. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org