From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92770C2BA15 for ; Tue, 18 Jun 2024 07:52:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 215F86B00EF; Tue, 18 Jun 2024 03:52:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1C6D96B00F1; Tue, 18 Jun 2024 03:52:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 03F8F6B00F2; Tue, 18 Jun 2024 03:52:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D6AC86B00EF for ; Tue, 18 Jun 2024 03:52:26 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 8290FA2042 for ; Tue, 18 Jun 2024 07:52:26 +0000 (UTC) X-FDA: 82243241892.27.9D6D531 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) by imf24.hostedemail.com (Postfix) with ESMTP id ACC07180008 for ; Tue, 18 Jun 2024 07:52:24 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=l0xKsjJq; spf=pass (imf24.hostedemail.com: domain of martin.l.wege@gmail.com designates 209.85.208.41 as permitted sender) smtp.mailfrom=martin.l.wege@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718697141; a=rsa-sha256; cv=none; b=Kvwswq6I/Hqk72hzfPLrCjUvFP72rzzOZcHBLHn45zZx1a7jNP1CcIKvzKtdiaNnw+w2Q0 EO5B2DKeSrcEFQCaeuFpZqfyFTmEntI2uwagtqnjHVkebtG14nemy6xS8c7altXiGop4i4 ifVSJwpzOwWu5lFOTkMT0KYWu4iu4vk= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=l0xKsjJq; spf=pass (imf24.hostedemail.com: domain of martin.l.wege@gmail.com designates 209.85.208.41 as permitted sender) smtp.mailfrom=martin.l.wege@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718697141; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i47tTS0Smc0matXz2a2CmZqxpNwYuNp/v14r4hNAm5s=; b=OhnP4009BSM/b5C5cy+eHGBGMXiffAPgx5b/3ojOZuClB3Na9+GoWOTy+cn+k8UywWhdnt Q+BokallP8wTi/wZ3XU/uS7qZ+ZaRdCKtFsB5G3yMXsK3Fx4cd/TYXSinR35nchVUmX7Xb 9VCbEHMTmSMYBjzsOtOj5dLj5OEZcXs= Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-57c6011d75dso6258079a12.3 for ; Tue, 18 Jun 2024 00:52:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718697143; x=1719301943; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=i47tTS0Smc0matXz2a2CmZqxpNwYuNp/v14r4hNAm5s=; b=l0xKsjJqocfG5ADknxRo1yBFI9Nl3DB7Dfuc9KlemtkVP7cDO8iepv6jP/TpKbNube AGigLmihH2YZ0B1IGM5toUtTvY42NrbNh4d5mn+vZb1Jd0oihNsxXfg/sb0ol9TgsttN XltISY+0utKygFQlb6Lm38bMJa3CwNDlHXtMrDVc4oru9t4+ra8B8C118ZEyIreo6ql6 vnQGp1UFYlyROTBO7WKkur1Jq+bqBDh3gobWV69gijeIZgBU2+GL9tkt8IDKg175LWo6 8esoJ2s0DvaRvUplD5nDn1+tKWhQxAezX1riiRQ3661/wrPaqmGvQTxhsv7a7JbWE6Th JY/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718697143; x=1719301943; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=i47tTS0Smc0matXz2a2CmZqxpNwYuNp/v14r4hNAm5s=; b=kEBIcoHyUXsFQJFj3gnzA1iaUIY3M9kRMtNOZuXBRL7NqrEkbfZrdfw45ZdTWmxFop ncXLIn8o8pe1puN3sZLlEabKLqMMFulKFTnGRr0VrTIIdO+tvjYqy9f2w4/ewy1l/oDj 62+Rm6GSHoCjxlzBVvoW7AI0MZ1dKCLAzg4OxGHFH79trHbswXlbMorDmhdb9kEthHCo +mFIbTGQvtumDUejS9VQ4mmsRoV1JzwEen95Gxq5dkLYWOlXWo79VHempcWCdvxLtVXr i4sCGv9LmdKiZd8ox1yieE2MxxOWZTcTl0ZsH4MV21M7uTil6WXOuw5Lz1loFYQvuzc8 ozPQ== X-Forwarded-Encrypted: i=1; AJvYcCVS7SiP43yub9itplL5j1fn8IRDVjGb+rWTsxEqpeNsVCsWCc+W1KBL8meAgD7T0VODD36CO3X10ezaiSk9o2dawJY= X-Gm-Message-State: AOJu0YwB30XwBYOPJ9hXEbiz7KGXf6AIn620W4XPDT9PxMJy/EFzFRqI BMGuCQhCOFHtYDJ0o8MhXK4SYpnmfudF+F0d2EhNUXpPyz9SqUF2BGe1WMNXSYqMxDQ7IlIgBn1 UpAl7jJcxUJTY84a2Sr23l9LbaMo= X-Google-Smtp-Source: AGHT+IEnQKM8yOKGghS2xqtPgQZXhwenYTCKKgD7oiMwYOJCjP6SOJqzyDq0LjJKLrFUeeMh93cjmacWSclnRt6Kqx4= X-Received: by 2002:a50:d4d8:0:b0:57c:a478:2ff4 with SMTP id 4fb4d7f45d1cf-57cbd681ae0mr9805343a12.11.1718697142667; Tue, 18 Jun 2024 00:52:22 -0700 (PDT) MIME-Version: 1.0 References: <20240618065647.21791-1-21cnbao@gmail.com> In-Reply-To: <20240618065647.21791-1-21cnbao@gmail.com> From: Martin Wege Date: Tue, 18 Jun 2024 09:52:11 +0200 Message-ID: Subject: Re: [PATCH v2] nfs: drop the incorrect assertion in nfs_swap_rw() To: Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org, anna@kernel.org, chrisl@kernel.org, hanchuanhua@oppo.com, hch@lst.de, jlayton@kernel.org, linux-cifs@vger.kernel.org, neilb@suse.de, ryan.roberts@arm.com, sfrench@samba.org, stable@vger.kernel.org, trondmy@kernel.org, v-songbaohua@oppo.com, ying.huang@intel.com, Matthew Wilcox Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: e6ei9fuqa56cjejpnwhins8retkkr6kb X-Rspamd-Queue-Id: ACC07180008 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1718697144-121890 X-HE-Meta: U2FsdGVkX190e62DrBX+ibRc44EnBWQl1lHpwNf0U7C685xk9RxOV5ZBMwNQmf9SHzAd0gekduPGxGlmiL8jo+dFgy5lIfQDOOgjqiJAUWCj6xPYzavMQxDy5ZeJFlZEaKw5lm//X/mZTE9L4+DuGmotvCqYDtWdYzabIxxrXHh8tcnIvsEOB72StI1eg/gIQanP0KndhWOlbZrp+fPsnv6tnpQFDBTo30bnKSQRXtU0BUhsIeiylQf183/MoNpAYR9XvZMY3wZ3wvHs17gCf+DGpMYJnSWAEIw/cV1kioOJ10xJKaD1CRW3ppn3m6IxG3bxLE4T+1+itSin3w+peQdX9DPjd2m9gZVcHA8y/1xSi/KSphVJlwAVKjqW8dofSzEf75IKN+WP8v4OLIyIzM77JzOHjrcBCqW/aJdH/LyH7mErGLQCd7/INlVqAbIso5AIa+4PrLRgke27+79sokrVb35TilU/NuSFvVqBr2QFMoJTQ/zZ742OqhCp+pToId/psOoeNjbXz0rR+9ephtYTBQaA6L6octeCWPXDddETpYJURcCOo8N0ClhGNOolBnkNRh/LO1qb91bzJs/vT41s8SJ0+70cbEvnm9u1woxwGa6eFkRxYqRLfn2sf3wh7aHxWhwHWJR9GA687bHIeCz0pwUHBlpVXOrkjqKypQbmsoi3s2IYBja5XiBAzevNrJTRiVS9keo5XFT2xLMkz+Yfah0LB3FLTChxatPzUqjtUyRlafrSghr17naRCWXhx4UejHMsGWsVWu8JlcIB1I6n7gAMDVIVmLd2D4q131oyyGQWPRaEelbKliaMTH5dCnzFZxjN9QlzITqPAw5QDPalesJOD7j2Jym1IEjFTPgdVTKBSLGmSGbdk3SHYLQXQ3BJdVrs6HdGKngrazbjic+HJ9T+YnS5ufE0flrVvrkWU94fcVdmi1a4jWb8NjH6ZSP1L3yJ3vRfh7EQxM6 iYWNLMwO FGXo9d9A5ZMLg5H9eceXdUFZoKyz+drdOQ51jjdThbog+6PaCAsjZVeidBpnLAWaBqperIbdVlGa8i+waQhmJqXchnhaUyRYNQtpDeHFjFdbNXA+HMHZ6Qb82Cym4HBO67h2NobnODSvzbbG9vLp2z2JsBOU6ICz82BQF42DbD/wjH8YIDyZ+PVAgvw3mvERSKPQEcEBYjvUW3U9fvgnlXhO+8p2jYKaX2txdT2nLHe1yCnWENjwjk9/mmABakGW6hZsKbJ2Ws71rHj5+FjzLvfgc1TecGAi1UTJRAdiT0uxHVLFQm9pUrRt0JGXuKVdS4tFXawfH29XJeddPTxC25HjEr/7zmOBV62/H36mcdr/LkJncrDOh3rEnCkkbLFoTAKuwCNOFQGnwBaIXEar0NqrUYE0A/hB5x5A9PMln4bGGCgyXWvk27Nl5/fgnt1rDoTrPWZcboxtphGtKqbKcr3U2C3Bmhe/y9sTeD84dFpNebG7PXzKN8KfDD5IHDdA/52rliBqDYE1O9/O6xYNVXdCieaKG1ABct6AFHOeYJHOMeg8MYg26yMcOiNWHR+drldJjCoEOXONr8BHsQQSdm+ubMHiHUVjtygRtR45RnKbLGJrdAKj/NvJrExG43IIHe/T+SMHsQGYgw1f5nLjmiTguULnjjkE7DzpBNHKDgVAmkbUuEAq4RcooD1lDZODYNSRP4RAj0Sg47G+bq9wgsZ0fyQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 18, 2024 at 8:57=E2=80=AFAM Barry Song <21cnbao@gmail.com> wrot= e: > > From: Christoph Hellwig > > Since commit 2282679fb20b ("mm: submit multipage write for SWP_FS_OPS > swap-space"), we can plug multiple pages then unplug them all together. > That means iov_iter_count(iter) could be way bigger than PAGE_SIZE, it > actually equals the size of iov_iter_npages(iter, INT_MAX). > > Note this issue has nothing to do with large folios as we don't support > THP_SWPOUT to non-block devices. > > Fixes: 2282679fb20b ("mm: submit multipage write for SWP_FS_OPS swap-spac= e") > Reported-by: Christoph Hellwig > Closes: https://lore.kernel.org/linux-mm/20240617053201.GA16852@lst.de/ > Cc: NeilBrown > Cc: Anna Schumaker > Cc: Steve French > Cc: Trond Myklebust > Cc: Chuanhua Han > Cc: Ryan Roberts > Cc: Chris Li > Cc: "Huang, Ying" > Cc: Jeff Layton > Cc: > Cc: Matthew Wilcox > Cc: Martin Wege > Signed-off-by: Christoph Hellwig > [Barry: figure out the cause and correct the commit message] > Signed-off-by: Barry Song > --- > fs/nfs/direct.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/fs/nfs/direct.c b/fs/nfs/direct.c > index bb2f583eb28b..90079ca134dd 100644 > --- a/fs/nfs/direct.c > +++ b/fs/nfs/direct.c Please add a Reviewed-by: Martin Wege Thanks, Martin