From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4900CC27C4F for ; Tue, 18 Jun 2024 06:48:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C96A26B02F2; Tue, 18 Jun 2024 02:48:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C458F6B02F3; Tue, 18 Jun 2024 02:48:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AE7886B02F4; Tue, 18 Jun 2024 02:48:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8F76A6B02F2 for ; Tue, 18 Jun 2024 02:48:24 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 29BDA1A0503 for ; Tue, 18 Jun 2024 06:48:24 +0000 (UTC) X-FDA: 82243080528.22.91A6E75 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) by imf06.hostedemail.com (Postfix) with ESMTP id 46B1818000B for ; Tue, 18 Jun 2024 06:48:22 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=aV3Ra4TM; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of martin.l.wege@gmail.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=martin.l.wege@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718693297; a=rsa-sha256; cv=none; b=50aVzZDMds0tH7dtang3BCKuRzXtlzMnqNWOQurdU7rc1XF+zpU9HTPMePTN/cRwt5rQsx eodwwyas6B7V8MgqRBw7ZDQtYXCTQz5qQdfbOtM0ckQxpOxTQwNkC2hCPIp8tuK7bu+sUf it0sJ1zO5N/p6S98lkz2IAllybu5cBE= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=aV3Ra4TM; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of martin.l.wege@gmail.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=martin.l.wege@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718693297; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WcuffUyjO6jnAI0pZKnKzMQolyv0kYugYuGfIyb+RYw=; b=Ws/dJeT+zl3NTLrG8/K6gbSHhhZvJ9ngat9P/L52q26NlT/x8gKt7zmbPItNLw4JYVvGiJ kBec9iLrqX6rCBsoS2Pqe0rQE7XMaea+hqnbOM9A0NjKNFNjRdTc6vhjYp/cvQK8aK9fw2 QzZnrGfYd42UwkNnGUOVAHSJSBjRP58= Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-57c76497cefso5911197a12.1 for ; Mon, 17 Jun 2024 23:48:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718693300; x=1719298100; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=WcuffUyjO6jnAI0pZKnKzMQolyv0kYugYuGfIyb+RYw=; b=aV3Ra4TML/EL5Tqlm8Z6pQKOZaQlSgQp0I/Z1EZHI7wvKzWQFhE45dIyyoxs8/+fjb MY8jSJ+ojoLqq6Ez9TBGtiK/g34FCeRint5qJ4oFJJu/33SfNO8zvLHu6L14f5bVtOn1 +4F/5dsKyuFOpn7/TcZ4x6NKDpumiOCD+ihAQ2djacTSTN5XtPO5cO3YdwDJAtAIqQVz YW5FWNz3ybC6UlxFkyvAzWCKwTmJPAJTpQra/TOBgN9Mek9efeh4qMZzitc9G0Ctf1z/ iDt6DWyzcRLl+0FCx8t01Z6HExX5Ix2ehjFtXHRn9vMbh3CHJGZoTf/Jdz65UoEduzA3 LvnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718693300; x=1719298100; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WcuffUyjO6jnAI0pZKnKzMQolyv0kYugYuGfIyb+RYw=; b=LrFytbuOKx7nIWiBjvZCuAELuRzeoonFEAS+42TtV6TjEQDpvNr+Pd/RiBEitbK7QN hC0UEFZDxcFqL/n7RcM2D1NMt83+OZcxksjc4nQ9Z/CrBlK5llgyCY0vGL/MGkH4zBwA 5Kz0t5IaZqlcvLgLyMGyHHXkB0o7+Lz/Q8QIUnTbTtcY1XhEo5pUdPuiOihyrL4GLtwZ gPMNFZyknxkOVOOzbkTqahINmeUr0D3llq1XX51StwXyh3UK1m+AV+ubzsIRL+COK/F9 xLFrx5uO8QT4UV0Z2kR0uosBI5/ByMVwB/I5gTzhnwemaP9lpL1m4UuU7RdcGDf/RlDw Ye3A== X-Forwarded-Encrypted: i=1; AJvYcCVl4Gy6bBSuDh5a3PgjHakyVAmIVn2PSFRRUozKPgDVHDWVZR2vs/GI9DmJgIyCQwDQeugGw89/SlKvq7Lr4N2D4+Q= X-Gm-Message-State: AOJu0YwvY9P4YQUtpNwUkFw93Kq2WEuk1NY6VJx2/bAMPHyrVi2Hf+kp ckQHkGG0IEl9rCuOs8DJsdsGzDa37UyJupbui/mw1aIPB97TQ3xneNFkWaXblPZypeZmJSadob5 eOdspBkvoYaK5AUHUwAWRD9xFvrf4ow== X-Google-Smtp-Source: AGHT+IG3tCQ/UpmEL8sP1ekAmlSKs60xkIPHq+7vYPkLRCY4mNHwrFJcy3UFigaB4pdgY1eF1Lzo266QeaEkmHgQoiM= X-Received: by 2002:a50:d792:0:b0:57c:70a6:baf with SMTP id 4fb4d7f45d1cf-57cbd6a581cmr6795922a12.40.1718693300432; Mon, 17 Jun 2024 23:48:20 -0700 (PDT) MIME-Version: 1.0 References: <20240614100329.1203579-1-hch@lst.de> <20240614100329.1203579-2-hch@lst.de> In-Reply-To: <20240614100329.1203579-2-hch@lst.de> From: Martin Wege Date: Tue, 18 Jun 2024 08:48:08 +0200 Message-ID: Subject: Re: [PATCH] nfs: fix nfs_swap_rw for large-folio swap To: Christoph Hellwig Cc: Trond Myklebust , Anna Schumaker , Steve French , Andrew Morton , linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 46B1818000B X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 9u7j3k153ztxtn8jadq7mczmuzuwpdfj X-HE-Tag: 1718693302-973516 X-HE-Meta: U2FsdGVkX1//ziT6PO23uoGUsBj1gXMUaS8t7QB9ZT/T1j068eXlwSGj/MzTvXzM+iyJ1kPLMs33BBLI9dj0FuVST7LmJiOhC7wEfy5DPg9TN3BReiZMHEf0f+sDmmjs5HEIWJZ2c5OsuOH//ppv3hfp3kylQIsnf1ELca8HDyvhrot1/Fv6TP0LX3GpGzazrVur4YrjIn1M8T6xBxjNwyy2DXF7E8RQJEIl73csXbnJI1isjkhONJkx58Jyso/0+dxT/H5bO7H/5VTz68CoHjkg2aXIYVrr9OzCg+Wox1gLUPWW2/bgb51PNQXnAkGU6iLTNZhV6XEicLi8o0cepy+9iOTSVtblWen/HvmOPmo2kETnvrvbqS/3KqrP/Fe6CszkmO/EuezL/hLXm0Cp1S6iegImWf66J1gy3nJlWdLdq9rfgMwFcMUlYBQhUQbd/ipBmsUmf/aQsZgshyF6yvdZV4r8VL8n+MEN9Iw6bUU/QBeGq5M+nHnN/bwfcuNPVcDkfYiN2FoLa7TksLnjq+Az/NsFmdNbdM8gKwlmmnD3sfvlX2FOdbN18q1B27f7buO249SDJsYRGVbBI8AM6/95VVlYhtfZnAhNgtUm0OMfuvqL0gzM08WQlxdNXJhmahXofOaacyoGcRUR23rWBIstFXSxDS+Z1nyPsAcUvifcoseRSdpsE0fae+qckvTgByUjaaumJfrF8zBRidQKZuCHtRyAX95FjG1rnLiHsGRbHtmecCI2RGXQbzeq4Qz2b4NRp7eGTCcGGqh8xdpeIntY98L/QQpHS/U0jVM91WeZuTc+JvPBDDS2dtiTGGwUqiNzrwm3BK8XOW/J+58/W7NQ7iBZETOp7eYAtkqyJgPphSd/g7TXDsfqIK6Cq9DPfH6QpuqXZSqyzfWuHvkBRWGDgMDp08Wg9C9H4sx1WBbCBSEddxzkalk2BVkJHg/1vn/mlbxr/R8ykjYJ3a6 FSOIlvL/ 9JdTKWVKv1pnoZolhjNqhbPAow6AK8VFgOpHsPSAmYAKInadgHbWIBWrO1hd3m0sCAMbajCWhTnVqZ1e8Ub8cGenJGdDJto+BHKKNBwz3iojA+ff556sjygUPICZy6MYbzl98v2NWaf3RAj04OuUhwns37N34+EL7tNuXoge1rmwIKzzZ2RiAYSEMSmasOL4eXTjC+/PdhhQJL1CPagYHqWyEjlc9mLt71vW+pQZL0QLPCTujvoy2G4jtKHWCtYsEgK1x9a1M3D721fJXLelDdtjXUWB4+4TD8Xhuqk9vXbX0LfGDzdFw8Y9m34WvEIaIdP6Si5fKvj5KMZS6034jtkAOP5UQijd2Q26w2y2nme3niGA/LDbW2wai1w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 14, 2024 at 12:38=E2=80=AFPM Christoph Hellwig wro= te: > > As of Linux 6.10-rc the MM can swap out larger than page size chunks. > NFS has all code ready to handle this, but has a VM_BUG_ON that > triggers when this happens. Simply remove the VM_BUG_ON to fix this > use case. > > Signed-off-by: Christoph Hellwig > --- > fs/nfs/direct.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/fs/nfs/direct.c b/fs/nfs/direct.c > index bb2f583eb28bf1..90079ca134dd3c 100644 +1 for the patch, and thank you for fixing NFS swap Thanks, Martin