From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F03FC04A94 for ; Wed, 2 Aug 2023 05:39:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5516D280127; Wed, 2 Aug 2023 01:39:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 50306280112; Wed, 2 Aug 2023 01:39:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F0CB280127; Wed, 2 Aug 2023 01:39:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2EB07280112 for ; Wed, 2 Aug 2023 01:39:19 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E87A1120587 for ; Wed, 2 Aug 2023 05:39:18 +0000 (UTC) X-FDA: 81078061596.04.9A79AF0 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by imf20.hostedemail.com (Postfix) with ESMTP id 20C291C0022 for ; Wed, 2 Aug 2023 05:39:16 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=u2D4gxea; spf=pass (imf20.hostedemail.com: domain of jstultz@google.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=jstultz@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690954757; a=rsa-sha256; cv=none; b=fBCW4ch4AkJTY85KQAuks8kVfCiWbFSarwSbf6sYyMQZIP4LqcS3nwhwVJ2QRjQmj6KSk0 KBXbFnBLK2wtqV2ue2FXo0UnE6oh0Zqexgr2FnctAKf7Vb2H6L4R8gOcVAQcIoN4xKI88t NriFvk5b4lOlEYesHsVl7yHh4KXYbCk= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=u2D4gxea; spf=pass (imf20.hostedemail.com: domain of jstultz@google.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=jstultz@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690954757; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TWYJKDdolz+W7APxSZcge8Mpis/01h5Go/3E39ja9gE=; b=CmzpriJcomHOoItxvKMbOw2c09lvogA99/Q0qJDMVbMJb2pirLVUSD/R43zJjpMzZFo21g +El+5cBaJeCn6pTpMTTiKti1XXISKWvEB28ZvPhLMg68Nd/xSNDmRcbgxLULbXvvA2P5Am mUozPS7ZVwpGkPbrzfbnmQuXS79I5/g= Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-3fe32ec7201so14175e9.1 for ; Tue, 01 Aug 2023 22:39:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1690954755; x=1691559555; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=TWYJKDdolz+W7APxSZcge8Mpis/01h5Go/3E39ja9gE=; b=u2D4gxeakPR8NuViuxq7UOiZsXAZW1EeAxq+260enPXoslZIKgTJbxTZZoltObc9L6 d6pMxqUZsWU0dbrDwyykja+xGR30Gljw+lz1PRzPjM5gBPHycl4nmSLnVV7ShP+3RLv8 N7iahaTTeK5z+s2r4WzxLyBIXNZrj8OMhzvDjL3k3QrlbULDJh6qFaBn92vNfZxl1XJm F29l5WQb1DIyMP4Y30lGQ/WhqONeInAjmuRC2xCDT8eThE13MwYY4eIXVAuk9hVqRzCO DSJQYanSQWCDcHa3e//iXzl0PWct1NPh6MBHFYCZuhrmxOR5AtQ4ekJyHv6Ppg60BKDI nN5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690954755; x=1691559555; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TWYJKDdolz+W7APxSZcge8Mpis/01h5Go/3E39ja9gE=; b=dmLu7h9wBfyJHVa/UbkQeKKTpCXwLFnHSkpUIxwyBVekP+Voq0eddQk8E1XIuzo8M/ WPuUQzcWEQpnLlyLao9yB67UIk0QVhXNZoj4ULjZcDWctfgB3nMGWSamhBn1xwIGTH+U kMws5qLZqzrK2REsF+u/z4p/Q3/PFD++JkQ3Y9KjidLOE76xDjaeBv8QcWzXgQ1RPHZ6 Hi1Gl2D1H3DEdnYKfYMhjyD1nq3sAlGRHtoWqvW7brvGo4WOGdra8dWKVuMaseAwU1JX JGD8MRruOWX+AcNwXZ8lCwspyRh4iKUBhbnPaksCmYzDTTRWLrybhzWSbYImkiXGZTHr w10Q== X-Gm-Message-State: ABy/qLabQrqKkG5jke2OkIpdjuPFtI2LAANMDSW2TQCjd9IHsJao1MIy rsmkhDb0X4+pYjrkap989l889yMP5YBjgWxm5d7a X-Google-Smtp-Source: APBJJlGB2VlfuxW3dK4WzHju6fp7PuJyl70BB7fOeK4klgHs3vDqzuSrKB0hMKQEoXT8t+Zp/UAztaUSZM5ue3QKmJs= X-Received: by 2002:a05:600c:3415:b0:3f7:e463:a0d6 with SMTP id y21-20020a05600c341500b003f7e463a0d6mr341983wmp.0.1690954755562; Tue, 01 Aug 2023 22:39:15 -0700 (PDT) MIME-Version: 1.0 References: <1690598115-26287-1-git-send-email-quic_pintu@quicinc.com> <20230731112155.GA3662@lst.de> <20230801171838.GA14599@lst.de> In-Reply-To: <20230801171838.GA14599@lst.de> From: John Stultz Date: Tue, 1 Aug 2023 22:39:04 -0700 Message-ID: Subject: Re: [PATCH v2] dma-contiguous: define proper name for global cma region To: Christoph Hellwig Cc: Pintu Agarwal , Pintu Kumar , linux-kernel@vger.kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, m.szyprowski@samsung.com, robin.murphy@arm.com, iommu@lists.linux.dev, Sumit Semwal , Benjamin Gaignard , Liam Mark , Laura Abbott , Brian Starkey , =?UTF-8?Q?Christian_K=C3=B6nig?= , linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 20C291C0022 X-Stat-Signature: 1hw19ncbeh98mi9wwo4nge4r5wxwdxcf X-Rspam-User: X-HE-Tag: 1690954756-615343 X-HE-Meta: U2FsdGVkX18CpYDnv5rFrKLqaebQJwKcfhWB7lug2HNSQLLU6Mmd+oi3nkVc86E9jaB1BVkJQVmZemin2JMI81mlfphTiDDOg1+F/XdxoVkTdxNiL8Zb4/tRI9tGUb6Svp7UQsZt3+RSlE7N/5RWOBwtHu6GoWRvuIglsTzdkJtPjZzIF335iJTYZ2twT8XUWEw8IJmNgEl1+oF081b8IwWRyIcjTnj+OZWJTxhaCr8SVML9+HF333Bc/icj0l+HK4dfeBeVnZRgKg1tTrJAAWIy9kDAQKdCU/jhL/yLBSD/CwU9QMmFYojDqQ4TVc73ZKFxyFHE9CzF1EfbX3JYl8ekNqaX5FUhREhJOpXpOoCU0efIwZnuagEPhCIVy9G8CNoj4vuib/AAdCvGc6bCoi8dwWhGvodVPGAYY/D0GtPngO0Hpt+ZbJaxb7e8X4Rlw8ka/rrvgA/nWH1FkeLhnjNRPzhCd+FzP3l8JeBXwejWgI5Ig90dcLcEJjQLdIdMQfu+w+lWxsD5tjLM1iF0CneJmixUluE+aMgQuHMF/P0JRJ1k7XlxyqIseeEB/jdY8l6bhpOd9Tcj7aBLEQ9PJxp/pM0ROFkLAE9yY23AZTEUA2vlZNEoBTCvULOsf8R9/SJJuC0DgJ2gsptLkrcloYbc+zsQfIKml2QAidGxNJ3KuR70BouSfecUAOOjgElCEwdcNZ5Du38mlkgW8w6jYis/zEqAhklPzIKHBRchgZ9PKNYJ/QNdZWoEZiR/zf6jmr1EbWTnhNC2zCW62DPiDsH83O5y8EY68iej9fAqmoYvQqUouEGSo2MknXs5EUXx9phD02+TTZMtQm08hQOzZCeGEkNvNkozWLd/oWdlhGY16HMDfi4noGfOxEBGF3F0cQTn7SqjBGp9Gp+KRxujsFckbpq5BxPFVmyQV5Kh69TkUX1eO9u7R81d7PvNhIGKIFlEZRwBpyzLOJlaGaj BTcYCRLk Wsor3D/VZGNmNjMA7Io2+zhVL2sRkT4tQy+cLJD5QD5mMF5G6dCFppOs+35uvZWVHuLcYHRcTJoxV89l+mzRwXkcepTZqA73jkhwUdexi+u5KoMUgDsetu/EB5H6fPMZgWEznAyHrSDUDM8m7lv0jUrkgTjL90Fr5yY8gdZAeDEOgIblcQfNfQDpE1Y6p89FOKUrwcraRE/btpE+YK1SpJQZj3JFT+/mJXmkA5mjyl0/BrX1LDyBY2/+V10zybwU7XHtwl7p58SHN4zufOG/TKeYX/eCyP8vZ3N22wHc60CfUKH4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 1, 2023 at 10:18=E2=80=AFAM Christoph Hellwig wrot= e: > > On Tue, Aug 01, 2023 at 10:42:42PM +0530, Pintu Agarwal wrote: > > > I agree that reserved is not a very useful name. Unfortuately the > > > name of the region leaks to userspace through cma_heap. > > > > > > So I think we need prep patches to hardcode "reserved" in > > > add_default_cma_heap first, and then remove the cma_get_name > > > first. > > > > Sorry, but I could not fully understand your comments. > > Can you please elaborate a little more what changes are required in > > cma_heap if we change "reserved" to "global-cma-region" ? > > Step 1: > > Instead of setting exp_info.name to cma_get_name(cma); > in __add_cma_heap just set it to "reserved", probably by passing a name > argument. You can also remove the unused data argument to __add_cma_heap > and/or just fold that function into the only caller while you're at it. So, forgive me, I've not had a chance to look into this, but my recollection was "reserved" is the name we see on x86, but other names are possibly provided via the dts node? I believe on the hikey board its "linux,cma" is the name, so forcing it to reserved would break that. Maybe instead add a compat config option to force the cma name (so x86 can set it to "default" if needed)? thanks -john