From: John Stultz <jstultz@google.com>
To: Jeff Layton <jlayton@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Stephen Boyd <sboyd@kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Jonathan Corbet <corbet@lwn.net>,
Chandan Babu R <chandan.babu@oracle.com>,
"Darrick J. Wong" <djwong@kernel.org>,
"Theodore Ts'o" <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>, Hugh Dickins <hughd@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Chuck Lever <chuck.lever@oracle.com>,
Vadim Fedorenko <vadim.fedorenko@linux.dev>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-btrfs@vger.kernel.org, linux-nfs@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH v7 01/11] timekeeping: move multigrain timestamp floor handling into timekeeper
Date: Fri, 13 Sep 2024 12:17:26 -0700 [thread overview]
Message-ID: <CANDhNCpPr-MvQhV7P6at9fQ-UpM_Q9R+S9oVqjHyguOgzrrZZQ@mail.gmail.com> (raw)
In-Reply-To: <8756a43fe0b7c3f418b351adb05e7a146d33bdfe.camel@kernel.org>
On Fri, Sep 13, 2024 at 12:06 PM Jeff Layton <jlayton@kernel.org> wrote:
> On Fri, 2024-09-13 at 11:59 -0700, John Stultz wrote:
> > > +/**
> > > + * ktime_get_real_ts64_mg - attempt to update floor value and return result
> > > + * @ts: pointer to the timespec to be set
> > > + * @cookie: opaque cookie from earlier call to ktime_get_coarse_real_ts64_mg()
> > > + *
> > > + * Get a current monotonic fine-grained time value and attempt to swap
> > > + * it into the floor using @cookie as the "old" value. @ts will be
> > > + * filled with the resulting floor value, regardless of the outcome of
> > > + * the swap.
> >
> > I'd add more detail here to clarify that this can return a coarse
> > floor value if the cookie is stale.
> >
>
> Sure, or I can just drop the cookie, if that's better.
That seems like the simpler approach, but I don't have a sense of the
actual performance impact, so I'll leave that decision to you.
thanks
-john
next prev parent reply other threads:[~2024-09-13 19:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 13:54 [PATCH v7 00/11] fs: multigrain timestamp redux Jeff Layton
2024-09-13 13:54 ` [PATCH v7 01/11] timekeeping: move multigrain timestamp floor handling into timekeeper Jeff Layton
2024-09-13 18:59 ` John Stultz
2024-09-13 19:05 ` John Stultz
2024-09-13 19:06 ` Jeff Layton
2024-09-13 19:17 ` John Stultz [this message]
2024-09-13 13:54 ` [PATCH v7 02/11] fs: add infrastructure for multigrain timestamps Jeff Layton
2024-09-13 13:54 ` [PATCH v7 03/11] fs: have setattr_copy handle multigrain timestamps appropriately Jeff Layton
2024-09-13 13:54 ` [PATCH v7 04/11] fs: handle delegated timestamps in setattr_copy_mgtime Jeff Layton
2024-09-13 13:54 ` [PATCH v7 05/11] fs: tracepoints around multigrain timestamp events Jeff Layton
2024-09-13 14:02 ` Jeff Layton
2024-09-13 13:54 ` [PATCH v7 06/11] fs: add percpu counters for significant " Jeff Layton
2024-09-13 13:54 ` [PATCH v7 07/11] Documentation: add a new file documenting multigrain timestamps Jeff Layton
2024-09-13 13:54 ` [PATCH v7 08/11] xfs: switch to " Jeff Layton
2024-09-13 13:54 ` [PATCH v7 09/11] ext4: " Jeff Layton
2024-09-13 13:54 ` [PATCH v7 10/11] btrfs: convert " Jeff Layton
2024-09-13 13:54 ` [PATCH v7 11/11] tmpfs: add support for " Jeff Layton
2024-09-14 13:29 ` [PATCH v7 00/11] fs: multigrain timestamp redux Christian Brauner
2024-09-14 13:37 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANDhNCpPr-MvQhV7P6at9fQ-UpM_Q9R+S9oVqjHyguOgzrrZZQ@mail.gmail.com \
--to=jstultz@google.com \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=chandan.babu@oracle.com \
--cc=chuck.lever@oracle.com \
--cc=clm@fb.com \
--cc=corbet@lwn.net \
--cc=djwong@kernel.org \
--cc=dsterba@suse.com \
--cc=hughd@google.com \
--cc=jack@suse.cz \
--cc=jlayton@kernel.org \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
--cc=tytso@mit.edu \
--cc=vadim.fedorenko@linux.dev \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox