From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 386F5C004D4 for ; Wed, 18 Jan 2023 06:54:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BEE956B0071; Wed, 18 Jan 2023 01:54:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B9EA46B0072; Wed, 18 Jan 2023 01:54:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A3EF06B0074; Wed, 18 Jan 2023 01:54:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9194D6B0071 for ; Wed, 18 Jan 2023 01:54:36 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 5EE9440185 for ; Wed, 18 Jan 2023 06:54:36 +0000 (UTC) X-FDA: 80367006552.10.C750D77 Received: from mail-yb1-f171.google.com (mail-yb1-f171.google.com [209.85.219.171]) by imf28.hostedemail.com (Postfix) with ESMTP id D05D9C000E for ; Wed, 18 Jan 2023 06:54:34 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=VG7uElnz; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf28.hostedemail.com: domain of jstultz@google.com designates 209.85.219.171 as permitted sender) smtp.mailfrom=jstultz@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674024874; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=W7K3U7J7q8qsq+5DG9vwDrzu00VfL71S9pskbFVpOu8=; b=ZrmnMx5iFkF916m7wGvENV8IqQ8R/aOk7Ib+WOikKFahWcugOt5A23ACZf/w1mlaLRq1gc JZmxDMl2bWHUqdtsDxjzexKCUhDUZhVoRhgCV2D9BD5vVJKtFxNNUa1V/IAIrzRCwtmQ38 TQF6e0ErdAAc9JmBfAqnjl1m2umhbDA= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=VG7uElnz; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf28.hostedemail.com: domain of jstultz@google.com designates 209.85.219.171 as permitted sender) smtp.mailfrom=jstultz@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674024874; a=rsa-sha256; cv=none; b=pOOVo+/jcFazSRk5EjynZ8Hw4w5jx25XSUCizcrxnJ31R9QLI1LGo1vEEXYVgEbdQAWOnY 8WIXKxN2JAslLQGVi+Qm6n/eNH9VKJdiufsCfm3sTrBz4uFwHRC9E1riHbNQnd92yfi7dU Vs6A9q4j735aO/ZUzZclM5sOHjUVn70= Received: by mail-yb1-f171.google.com with SMTP id a9so20322363ybb.3 for ; Tue, 17 Jan 2023 22:54:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=W7K3U7J7q8qsq+5DG9vwDrzu00VfL71S9pskbFVpOu8=; b=VG7uElnzUvxurmTqRBuxo8pIwPUkjkLFH93ePb1S/RRa+9e3X/gk+Ays3E/Aj0ScsZ nEeKOt1yq8l1m3AGFkVNLFOqdiVl0sCWCopXdj7VO1VtPQgimxzGXt1+eXS2tbCN9u40 BAhw4kdTo8TD8U6/gcv6b0PI84ehLnvOo1sjT0K+aHk+7Oi12GbPSpzbYefzcr0nKVUW ztb9AdK/xZcin5xFlajIdgGeHPf3ml9uxwvnuVSwFTB5EAIVJgHxpj+qxr9Jo1TvIkej 5xn2dBDFfgN9a7yuwZWDpxIuBjr+aOMXxUiZcPo7wpuQFPqRInmSsHJwBaVphTJB77p8 CU7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=W7K3U7J7q8qsq+5DG9vwDrzu00VfL71S9pskbFVpOu8=; b=Qlc3Rwhf0oNKKkz5QyAVE5UZTiX91Mw9IbsJsavs2hfIalZ77ykeaRVPKWcFfhSZWy GWcdF5uGRjoRfEf5L5vwGUi+8G3Q5GjO02Kpom/DJhtiEe9ZllhrzI06zdohjZGi+Ch6 o7Z9wFIWLeLBh2gKeSkG1YIVNeN7oaRBqoKlslyVKM7IhCwSHQDlhoTN+KYgdIReCEpW J9sWng6r9jykCIOgN+WMP9ghdzSm29zhboUNABfuhpsyZyZ/cu2+2qTBfHGtXS5D1S1E I2rlx043nOV+RQ65cT9/qjl471xPJDLREbEkb+aWd0IpkEnqD2ihOlD3SHsikzljiMA5 p0hA== X-Gm-Message-State: AFqh2krrp9Wj3DlYUt8l7pkiKszRKLsZCZfcuKWT9tIAMTKrf+EZPHdw ZQPfuOfumdMq+Wk1Z2VllujNp4IpScN0jEfFd11j X-Google-Smtp-Source: AMrXdXu0f4baWvNWXO3k4JGT4NSiS5o+ls9nfcsi3GrRwWaGIwkKPTGqimdXbFSdiOkRg974+cYEIe9bl8tX7aaaPgo= X-Received: by 2002:a25:d451:0:b0:7ce:4650:5e5a with SMTP id m78-20020a25d451000000b007ce46505e5amr753159ybf.123.1674024873890; Tue, 17 Jan 2023 22:54:33 -0800 (PST) MIME-Version: 1.0 References: <20230117082508.8953-1-jaewon31.kim@samsung.com> <20230117083103epcms1p63382eee1cce1077248a4b634681b0aca@epcms1p6> In-Reply-To: <20230117083103epcms1p63382eee1cce1077248a4b634681b0aca@epcms1p6> From: John Stultz Date: Tue, 17 Jan 2023 22:54:22 -0800 Message-ID: Subject: Re: [PATCH] dma-buf: system_heap: avoid reclaim for order 4 To: jaewon31.kim@samsung.com Cc: "sumit.semwal@linaro.org" , "daniel.vetter@ffwll.ch" , "akpm@linux-foundation.org" , "hannes@cmpxchg.org" , "mhocko@kernel.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "jaewon31.kim@gmail.com" , "T.J. Mercier" Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: D05D9C000E X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: zssq4ryukpd7xrx6fyfdrpd49sth5s5s X-HE-Tag: 1674024874-310225 X-HE-Meta: U2FsdGVkX1/zOF7B5Cwb3n3sgT9aGV7imliE011QyWmMI6on1U764yjj+NUJ0hE0YE9bs5rMJ2sX+mDLkjpjzOQ31Ne0hqRIpCdA0UjeIjZWTW/jnAW2zIb3qqUu7HlkQKGr17EU4T776iSfwJ5wS4c8i+46Dv/X6q5bZbiHkOwZr6vvpMFd7pvB3QOT8gn3IS+eOVm1HgnXZ9fWD/HG7pnRE9UwbAcAGeS3qRoeOLa03E5rto7QCHJDrYCt3AICKPmySTRIiNgDeTsGdLc18gatiY3m24QYZSfglveV0h30J6YVSIqD0XGseBejBXp+AmQfYJqG4cQJLZONRV/qaFqWxdRZhkBWrNo1NepKdGHXBYNGqKqMusniopI9BjQFCd+QbJt5wginkg9vrkgywX/Fk6RvQuEOrYx4SzzjXpFnxZs5SntSopgbKpyHgEDEhnz8iiotFWfFtwjRjvTuN80cVb6ze7QSQm8ybLKlqntgakjYUtmPaVtbZyFv0tKgjooo90+AK4SbldCT1UY8WWoq12OD+74ugV67k/JuEqa2DnG92JshPo+6DimKSEkfNfMM1eBaeMsC/tes2NMiVtI1p3HxTgy5hdsYdGMB11lD8OUN762VKCjOKRQ/ID6TlwK5HOBQk5/16MxNqRvzttB2m15Z5O9xSxtPwC2vDjvkeqiW/0mJY6bFNA6tn0sqvVRyFkta8Gq6NK0oBpic8+WypVddkrVWfymatxOGptB7FH3kudNr5tDH0I/MIORyWFXAoTrbUycETZ6dKoKLkMtmHu0CaGKK6BItLjdjpD0CjCsiqEgZr6QqcBxbpo0uMB8q5iODhTlUicBaksO8xaumEYYJT8eYohzRu48XnVv4dLafh44jqiq+bofd1VQ+dNd8v3HYLLJoYeG5tE5K9joRct//SHzM8hPdBmfp68BniylmbGymsnH1OPknn+no/Xy6KRFHAlIB3s4KqZt uPgWaDZn seRdY0viYccW2vt0dz0bW0mjRtXYgoW+nraNmbbsovJlCm1ObUaomF9HERqXfKfYH0nvg/i1+QYFWxEftg1OetHrdF97jq56DSapCZPwWVghkbV0fwIxzxgBqNCApG+VTndgcRPmOQpxXgIBfaUFeu7FK7DnypCf04zzHUYN6SUAaY6M= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 17, 2023 at 12:31 AM Jaewon Kim wrote: > > Using order 4 pages would be helpful for many IOMMUs, but it could spend > > quite much time in page allocation perspective. > > > > The order 4 allocation with __GFP_RECLAIM may spend much time in > > reclaim and compation logic. __GFP_NORETRY also may affect. These cause > > unpredictable delay. > > > > To get reasonable allocation speed from dma-buf system heap, use > > HIGH_ORDER_GFP for order 4 to avoid reclaim. Thanks for sharing this! The case where the allocation gets stuck behind reclaim under pressure does sound undesirable, but I'd be a bit hesitant to tweak numbers that have been used for a long while (going back to ion) without a bit more data. It might be good to also better understand the tradeoff of potential on-going impact to performance from using low order pages when the buffer is used. Do you have any details like or tests that you could share to help ensure this won't impact other users? TJ: Do you have any additional thoughts on this? thanks -john