From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18D5DC38142 for ; Wed, 1 Feb 2023 08:11:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 721D66B0071; Wed, 1 Feb 2023 03:11:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6CFAB6B0072; Wed, 1 Feb 2023 03:11:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5973B6B0078; Wed, 1 Feb 2023 03:11:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 49E916B0071 for ; Wed, 1 Feb 2023 03:11:56 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 1B5A5120D20 for ; Wed, 1 Feb 2023 08:11:56 +0000 (UTC) X-FDA: 80418004632.07.ADE7A98 Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com [209.85.128.175]) by imf15.hostedemail.com (Postfix) with ESMTP id 51CE2A0011 for ; Wed, 1 Feb 2023 08:11:54 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=KQsIgzHY; spf=pass (imf15.hostedemail.com: domain of jstultz@google.com designates 209.85.128.175 as permitted sender) smtp.mailfrom=jstultz@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675239114; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=At9QD5kQjTIN7A9/f4GSWoe10ugai8T63OJMf7OTkzc=; b=IgkUJtm/SV9RP+mwuvoJskxr9ZDJSiZeLLzlnR8Sn90EiBDc6GPhEFAsPCQ3mQ+JQamwEa SgK46YphqDqb8sM4EoeoNM8wWnYMZh+1+akZA0grFCACfLgcjyoFMLZ/K4BqrZpux9crYe eHcOAsfiNZfw0iz2f1LxkulSX6XSpDI= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=KQsIgzHY; spf=pass (imf15.hostedemail.com: domain of jstultz@google.com designates 209.85.128.175 as permitted sender) smtp.mailfrom=jstultz@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675239114; a=rsa-sha256; cv=none; b=Fu74A27HB8LiiYucAbru1uJExxswwNwevO/ZIMUu/WOOonaSPA6RlWROpTBmH/dd2/n2wv VSDSP5JJMe1l5usPSjOMAwvxn2eqgz+XbSG/yeGrQLZ1zDsY06b7kwlLPw0C3QGBoVa2oq BeA/5FzxyPWW+N5sTF4MbuKdGRuwCqM= Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-50aa54cc7c0so208111527b3.8 for ; Wed, 01 Feb 2023 00:11:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=At9QD5kQjTIN7A9/f4GSWoe10ugai8T63OJMf7OTkzc=; b=KQsIgzHYJD6gFfJcAx1ztrsmZ4fgArEtf11xPKhBZKcaDERprO8I5tBF9CgSoGm7AI 9GKM97KU/Asl6pE9xu4I2DVRjU3HusXAL6nKTZc+NWQ3OX/VCFaKNFOluPLrR4YeIfmJ zdnIKmyVSi4cC2PTFiJT+96LUsA9DrAVdvjxMGOuIA0sR76xvtbatRijeITVpWKC5rno KF+r5jppu8Re7XigLmEJHnF/x9O9aGiMNgt1VHbU+n+RTcuAK4GUdTGDkDSv3zRUJj5Y Evc1zhj3yFzv/e03hSz2f7mLZf8nleLwSJhxT6JOVWWfgqv1azVAXJquWGoRehSE+ajo t2Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=At9QD5kQjTIN7A9/f4GSWoe10ugai8T63OJMf7OTkzc=; b=rmEAqGQXI6WWGvb/s/jx7NkFuSNNF2pWyQffRaxxaf4MhJ7KPRjuNb63d0RRPtI44d VJmk0N6HcW9CBnJmxhoV2k2pjvGhgxt9BnDdg0MgkhiBH/hEE+FdAiV9UtHp7TZOvynr NuHGhhOXH0cxulu7jJQzZJjf/ibGW9u7rmPeeS0lC9bc13wx7+ZIG5bQI6s8gcZKvq82 7MnlzS/e27nnLOUd4wF491UhZZxXgjpb3v3xY3JXU/sJSV9k4JMf1R6nY47F2avk4NgN Yerw44c/yWckkIj9xvw30i760Sz5IQJtdbD2YMp/d7XNjPIpPxhGfSsPOASnuqfj2K2s AByQ== X-Gm-Message-State: AO0yUKVKhISBEvwSd5Gce2+W/XRJYqgKOn3lLSN/QRSzSXdbMvsUtfAH 4n6MMXceeQjcb2uHY8l8/8MkRjNB6zY4KWqgdyjy X-Google-Smtp-Source: AK7set/UJ1BPXYvvYXtGMUfSxN51Xg9/xMArbwz1k1EfPttM2o2rxAApsWohbp+P1UaJU6RJPmiF9RFP/icUNo8AxJc= X-Received: by 2002:a05:690c:b8d:b0:4ff:6a1e:49cc with SMTP id ck13-20020a05690c0b8d00b004ff6a1e49ccmr161270ywb.464.1675239113306; Wed, 01 Feb 2023 00:11:53 -0800 (PST) MIME-Version: 1.0 References: <20221101222520.never.109-kees@kernel.org> <20221101223321.1326815-5-keescook@chromium.org> In-Reply-To: From: John Stultz Date: Wed, 1 Feb 2023 00:11:41 -0800 Message-ID: Subject: Re: [PATCH 5/6] driver core: Add __alloc_size hint to devm allocators To: Yongqin Liu Cc: Kees Cook , Vlastimil Babka , Greg Kroah-Hartman , Rasmus Villemoes , Thomas Gleixner , Jason Gunthorpe , Nishanth Menon , Michael Kelley , Dan Williams , Won Chung , David Gow , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Guenter Roeck , Andy Shevchenko , Paolo Abeni , Geert Uytterhoeven , Nathan Chancellor , Nick Desaulniers , Tom Rix , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-hardening@vger.kernel.org, llvm@lists.linux.dev, Sumit Semwal Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 51CE2A0011 X-Stat-Signature: mtxeyc3epqujgn5gu95npqjxa1yeb1sb X-HE-Tag: 1675239114-258354 X-HE-Meta: U2FsdGVkX1+UCl3m4p6FJ6JEs+y3/OJtOAMzxCBkSgLfp6DPB+/NQLrMohN2LSJ93w4rhCHQoa0fqQ90ogroa91A0abDdbW5zJPu7hvj9G4lVP3AxdJQUs+6yjuSUakxXTDXUbgPlfEqAWH4dZwBxTwOCg8pdjUV8H7IO7OD+HOUWuFQ15w5315AFg524gaHbhorQOqXQIoJwGfdzKQihLE5WkXLZtWeUQqJLUzwoGtcSLnPjZd7egjHeMUVl8mm4AiWzOIGBZYgzVOMgVoqMAbTp6c2mHr5t1LouzV11eWw+ONOExzAkdSAqnm5rJyBw3O1LJ5zVBpIlEvAx25Acafxn5/CDW/yswp7oJCgpWVzf7scrr0jRfLeCxVRj5eh/0Q1W2cprK+BnXHF+DKUAguWb6cL6q/8wXm09LJEJrNQnC5jgb1QuHTbXn+38EKAx5H+7kTckzHRlH2mFd4rqSrNHsBJ7O7Uc5u6UGLuoBCQS10Qn41JiBSAJTtpG5nWMXKQrsuY+wQBydafR0CLz1rCzmslalStdRlZfhsq9rz4RSOAO/KVUnGDd8ejBjeEcn4kOCFl9KPzP6CqOAu44SSE4JPlaGRiSKjoajQkxkQgjxqEnwWekogvuqJRVAVejpAJtLwISj3QXnZ2TRUqKbedQ16ucQ14dNSTsLne5G/xlJ0ZuBJtCKZxEI6ieVq6LoZ1DAzVxEIU/Cc/RuytonUfg7SUnt2Mi88s3TEYJRg8Zkaqc8a8f9Vi6wAe4nNK/TqpSCspoy/lgw6LxkTFzPEgFeRBLhu4ROkNb1dUXH7hA9djJsR2Z5J+3EKrJUqEKR9gPWFsFHLdXJU4WvrUkYLPjbMpm+lwh6XumDhZMyVqAr88f2fBVQF04Eyc99FNzdpLlJUszAtKFQxbfPXAWyYJBSvyOcrvFIA+0P4o0aV23VYPsy1yduQ022+z+f/Vp/jqAc2gX5Y6qGdVLus ox6064z1 SDD8S9FaFFzcX9D1/sAxyA2+7HOWg8Kd4ER/NuO+C2A+rgYNAdxhZGYkBl4ZSVioGIdCNg453dvQ9EjfnAunWPOZOUCm9D4omllv8oAi+yZu7EIVv4rjDwZduIphRseT8FLmPSvd5BLxir4RneItcDi5Xo6X8QVU3T2fL5vjvdQq+eRHeQHyHy4AN+KTIIMMFdjkRma4GzzvlMwO4Wh4WPHvLAuodIiFlv0bzsDhtnsQSJIoP+81HlMJCc0+imo2H+zZH+qxPUjPz6KTIDYz3G5lbLnGAuDqm0ZZqGX+QnvDKLk+KbifHDslRQLnAqgJkGJlkbeS3AvgdvMDaYWpHdmdvxRLtMT3kfWRRhFvx5LLiN4/qCrvnKCVcc/ZMnkliWTa5Nln8UlhgnNj5aEp7saK+lTi3vBUjs9yqvFQCRMAYWzH8oxsO/FxEm6ahj/7PrGnGT0NGpNPir1sMixpMca21DYjZi51Gc0u8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 31, 2023 at 11:36 PM Yongqin Liu wrote: > > Hi, Kees > > This change causes "Kernel panic - not syncing: BRK handler: Fatal exception" > for the android-mainline based hikey960 build, with this commit reverted, > there is no problem for the build to boot to the homescreen. > Not sure if you have any idea about it and give some suggestions. > > Here is part of the kernel panic log: > > [ 9.479878][ T122] ueventd: Loading module > /vendor/lib/modules/spi-pl022.ko with args '' > [ 9.480276][ T115] apexd-bootstrap: Pre-allocated loop device 29 > [ 9.480517][ T123] ueventd: LoadWithAliases was unable to load > of:Nhi3660_i2sT(null)Chisilicon,hi3660-i2s-1.0 > [ 9.480632][ T121] Unexpected kernel BRK exception at EL1 > [ 9.480637][ T121] Internal error: BRK handler: > 00000000f2000001 [#1] PREEMPT SMP > [ 9.480644][ T121] Modules linked in: cpufreq_dt(E+) > hisi_thermal(E+) phy_hi3660_usb3(E) btqca(E) hi6421_pmic_core(E) > btbcm(E) spi_pl022(E) hi3660_mailbox(E) i2c_designware_platform(E) > mali_kbase(OE) dw_mmc_k3(E) bluetooth(E) dw_mmc_pltfm(E) dw_mmc(E) > kirin_drm(E) rfkill(E) kirin_dsi(E) i2c_designware_core(E) k3dma(E) > drm_dma_helper(E) cma_heap(E) system_heap(E) > [ 9.480688][ T121] CPU: 4 PID: 121 Comm: ueventd Tainted: G > OE 6.2.0-rc6-mainline-14196-g1d9f94ec75b9 #1 > [ 9.480694][ T121] Hardware name: HiKey960 (DT) > [ 9.480697][ T121] pstate: 20400005 (nzCv daif +PAN -UAO -TCO > -DIT -SSBS BTYPE=--) > [ 9.480703][ T121] pc : hi3660_thermal_probe+0x6c/0x74 [hisi_thermal] > [ 9.480722][ T121] lr : hi3660_thermal_probe+0x38/0x74 [hisi_thermal] > [ 9.480733][ T121] sp : ffffffc00aa13700 > [ 9.480735][ T121] x29: ffffffc00aa13700 x28: 0000007ff8ae8531 > x27: 00000000000008c0 > [ 9.480743][ T121] x26: ffffffc00aa2a300 x25: ffffffc00aa2ab40 > x24: 000000000000001d > [ 9.480749][ T121] x23: ffffffc00a29d000 x22: 0000000000000000 > x21: ffffff8001fa4a80 > [ 9.480755][ T121] x20: 0000000000000001 x19: ffffff8001fa4a80 > x18: ffffffc00a8810b0 > [ 9.480761][ T121] x17: 000000007ab542f2 x16: 000000007ab542f2 > x15: ffffffc00aa01000 > [ 9.480767][ T121] x14: ffffffc00966f250 x13: ffffffc0b58f9000 > x12: ffffffc00a055f10 > [ 9.480771][ T123] ueventd: LoadWithAliases was unable to load > cpu:type:aarch64:feature:,0000,0001,0002,0003,0004,0005,0006,0007,000B > [ 9.480773][ T121] > [ 9.480774][ T121] x11: 0000000000000000 x10: 0000000000000001 > x9 : 0000000100000000 > [ 9.480780][ T123] ueventd: > [ 9.480780][ T121] x8 : ffffffc0044154cb x7 : 0000000000000000 > x6 : 000000000000003f > [ 9.480786][ T121] x5 : 0000000000000020 x4 : ffffffc0098db323 > x3 : ffffff801aeb62c0 > [ 9.480792][ T121] x2 : ffffff801aeb62c0 x1 : 0000000000000000 > x0 : ffffff8001fa4c80 > [ 9.480798][ T121] Call trace: > [ 9.480801][ T121] hi3660_thermal_probe+0x6c/0x74 [hisi_thermal] > [ 9.480813][ T121] hisi_thermal_probe+0xbc/0x284 [hisi_thermal] Taking a look here, it looks pretty obvious: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/thermal/hisi_thermal.c#n414 data->nr_sensors = 1; data->sensor = devm_kzalloc(dev, sizeof(*data->sensor) * data->nr_sensors, GFP_KERNEL); Here as nr_sensors=1, we allocate only one structure for the array. But then below that, we modify two entries, writing past the valid array, and corrupting data when writing the second sensor values. data->sensor[0].id = HI3660_BIG_SENSOR; data->sensor[0].irq_name = "tsensor_a73"; data->sensor[0].data = data; data->sensor[1].id = HI3660_LITTLE_SENSOR; data->sensor[1].irq_name = "tsensor_a53"; data->sensor[1].data = data; I suspect nr_sensors needs to be set to 2. Nice work, Kees! thanks -john