From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f170.google.com (mail-pd0-f170.google.com [209.85.192.170]) by kanga.kvack.org (Postfix) with ESMTP id 1D70B6B0032 for ; Fri, 27 Sep 2013 04:08:09 -0400 (EDT) Received: by mail-pd0-f170.google.com with SMTP id x10so2289623pdj.29 for ; Fri, 27 Sep 2013 01:08:08 -0700 (PDT) Received: by mail-pb0-f50.google.com with SMTP id uo5so2221890pbc.23 for ; Fri, 27 Sep 2013 01:08:06 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20130927062633.GB6726@gmail.com> References: <5241D897.1090905@gmail.com> <5241DB62.2090300@gmail.com> <20130926145326.GH3482@htj.dyndns.org> <52446413.50504@gmail.com> <20130927062633.GB6726@gmail.com> Date: Fri, 27 Sep 2013 16:08:06 +0800 Message-ID: Subject: Re: [PATCH v5 6/6] mem-hotplug: Introduce movablenode boot option From: Yanfei Zhang Content-Type: multipart/alternative; boundary=047d7bb0500083f98004e758fc73 Sender: owner-linux-mm@kvack.org List-ID: To: Ingo Molnar Cc: Tejun Heo , "Rafael J . Wysocki" , "lenb@kernel.org" , Thomas Gleixner , "mingo@elte.hu" , "H. Peter Anvin" , Andrew Morton , Toshi Kani , Wanpeng Li , Thomas Renninger , Yinghai Lu , Jiang Liu , Wen Congyang , Lai Jiangshan , "isimatu.yasuaki@jp.fujitsu.com" , "izumi.taku@jp.fujitsu.com" , Mel Gorman , Minchan Kim , "mina86@mina86.com" , "gong.chen@linux.intel.com" , "vasilis.liaskovitis@profitbricks.com" , "lwoodman@redhat.com" , Rik van Riel , "jweiner@redhat.com" , "prarit@redhat.com" , "x86@kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Linux MM , "linux-acpi@vger.kernel.org" , "imtangchen@gmail.com" , Zhang Yanfei --047d7bb0500083f98004e758fc73 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable hello Ingo, =E5=9C=A8 2013=E5=B9=B49=E6=9C=8827=E6=97=A5=E6=98=9F=E6=9C=9F=E4=BA=94=EF= =BC=8CIngo Molnar =E5=86=99=E9=81=93=EF=BC=9A > > * Zhang Yanfei > wrote: > > > OK. Trying below: > > > > movablenode [KNL,X86] This option enables the kernel to arrange > > hotpluggable memory into ZONE_MOVABLE zone. If memory > > in a node is all hotpluggable, the option may make > > the whole node has only one ZONE_MOVABLE zone, so that > > the whole node can be hot-removed after system is up. > > Note that this option may cause NUMA performance down. > > That paragraph doesn't really parse in several places ... Sorry=E2=80=A6could you point out the places a bit? > > Also, more importantly, please explain why this needs to be a boot option= . > In terms of user friendliness boot options are at the bottom of the list, > and boot options also don't really help feature tests. > > Presumably the feature is safe and has no costs, and hence could be added > as a regular .config option, with a boot option only as an additional > configurability option? Yeah, the kernel already has config MOVABLE_NODE, which is the config enabing this feature, and we introduce this boot option to expand the configurability. Thanks. Zhang > > Thanks, > > Ingo > --047d7bb0500083f98004e758fc73 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable hello Ingo,

=E5=9C=A8 2013=E5=B9=B49=E6=9C=8827=E6=97=A5=E6=98=9F=E6= =9C=9F=E4=BA=94=EF=BC=8CIngo Molnar =E5=86=99=E9=81=93=EF=BC=9A

* Zhang Yanfei <zhangyanfei.yes@gmail.com&g= t; wrote:

> OK. Trying below:
>
> movablenode =C2=A0 [KNL,X86] This option enables the kernel to arrange=
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 hotpluggable memory i= nto ZONE_MOVABLE zone. If memory
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 in a node is all hotp= luggable, the option may make
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 the whole node has on= ly one ZONE_MOVABLE zone, so that
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 the whole node can be= hot-removed after system is up.
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Note that this option= may cause NUMA performance down.

That paragraph doesn't really parse in several places ...<= div>
Sorry=E2=80=A6could you point out the places a bit?
=C2=A0

Also, more importantly, please explain why this needs to be a boot option.<= br> In terms of user friendliness boot options are at the bottom of the list, and boot options also don't really help feature tests.

Presumably the feature is safe and has no costs, and hence could be added as a regular .config option, with a boot option only as an additional
configurability option?

Yeah, the kernel al= ready has config MOVABLE_NODE, which is the config enabing this feature, an= d we introduce this boot option to expand the configurability.

Thanks.
Zhang
=C2=A0
<= blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px= #ccc solid;padding-left:1ex">
Thanks,

=C2=A0 =C2=A0 =C2=A0 =C2=A0 Ingo
--047d7bb0500083f98004e758fc73-- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org