From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx105.postini.com [74.125.245.105]) by kanga.kvack.org (Postfix) with SMTP id 62DC86B0031 for ; Fri, 2 Aug 2013 20:44:06 -0400 (EDT) Received: by mail-pd0-f176.google.com with SMTP id q10so1197030pdj.7 for ; Fri, 02 Aug 2013 17:44:05 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1375408621-16563-1-git-send-email-iamjoonsoo.kim@lge.com> Date: Sat, 3 Aug 2013 08:44:05 +0800 Message-ID: Subject: Re: [PATCH 1/2] mm, vmalloc: remove useless variable in vmap_block From: Yanfei Zhang Content-Type: multipart/alternative; boundary=047d7bf16282517b7d04e3005f29 Sender: owner-linux-mm@kvack.org List-ID: To: Joonsoo Kim Cc: Andrew Morton , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Zhang Yanfei , Joonsoo Kim , Johannes Weiner --047d7bf16282517b7d04e3005f29 Content-Type: text/plain; charset=UTF-8 On Saturday, August 3, 2013, Yanfei Zhang wrote: > On Friday, August 2, 2013, Joonsoo Kim wrote: > >> vbq in vmap_block isn't used. So remove it. >> >> Signed-off-by: Joonsoo Kim > > > Acked-by: Zhang Yanfei > Sorry, the mail was wrongly written, it should be : Acked-by: Zhang Yanfei > > >> diff --git a/mm/vmalloc.c b/mm/vmalloc.c >> index 13a5495..d23c432 100644 >> --- a/mm/vmalloc.c >> +++ b/mm/vmalloc.c >> @@ -752,7 +752,6 @@ struct vmap_block_queue { >> struct vmap_block { >> spinlock_t lock; >> struct vmap_area *va; >> - struct vmap_block_queue *vbq; >> unsigned long free, dirty; >> DECLARE_BITMAP(dirty_map, VMAP_BBMAP_BITS); >> struct list_head free_list; >> @@ -830,7 +829,6 @@ static struct vmap_block *new_vmap_block(gfp_t >> gfp_mask) >> radix_tree_preload_end(); >> >> vbq = &get_cpu_var(vmap_block_queue); >> - vb->vbq = vbq; >> spin_lock(&vbq->lock); >> list_add_rcu(&vb->free_list, &vbq->free); >> spin_unlock(&vbq->lock); >> -- >> 1.7.9.5 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> Please read the FAQ at http://www.tux.org/lkml/ >> > --047d7bf16282517b7d04e3005f29 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Saturday, August 3, 2013, Yanfei Zhang wrote:
On Friday, August 2, 2013, Joonsoo Kim wrote:
vbq in vmap_block isn't used. So remove it.

Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>

Acked-by: Zhang Yanfei <zhangyanfei@cn.fujitsu.con= >

Sorry, the mail was= wrongly written,=C2=A0it should be :=C2=A0

Acked-by: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>




diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index 13a5495..d23c432 100644
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -752,7 +752,6 @@ struct vmap_block_queue {
=C2=A0struct vmap_block {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 spinlock_t lock;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 struct vmap_area *va;
- =C2=A0 =C2=A0 =C2=A0 struct vmap_block_queue *vbq;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 unsigned long free, dirty;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 DECLARE_BITMAP(dirty_map, VMAP_BBMAP_BITS);
=C2=A0 =C2=A0 =C2=A0 =C2=A0 struct list_head free_list;
@@ -830,7 +829,6 @@ static struct vmap_block *new_vmap_block(gfp_t gfp_mask= )
=C2=A0 =C2=A0 =C2=A0 =C2=A0 radix_tree_preload_end();

=C2=A0 =C2=A0 =C2=A0 =C2=A0 vbq =3D &get_cpu_var(vmap_block_queue);
- =C2=A0 =C2=A0 =C2=A0 vb->vbq =3D vbq;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 spin_lock(&vbq->lock);
=C2=A0 =C2=A0 =C2=A0 =C2=A0 list_add_rcu(&vb->free_list, &vbq-&g= t;free);
=C2=A0 =C2=A0 =C2=A0 =C2=A0 spin_unlock(&vbq->lock);
--
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel= " in
the body of a message to majordomo@vger.kernel.org
More majordomo info at =C2=A0http://vger.kernel.org/majordomo-info.html Please read the FAQ at =C2=A0http://www.tux.org/lkml/
--047d7bf16282517b7d04e3005f29-- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org