From: Yanfei Zhang <zhangyanfei.yes@gmail.com>
To: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Zhang Yanfei <zhangyanfei@cn.fujitsu.com>,
Joonsoo Kim <js1304@gmail.com>,
Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [PATCH 1/2] mm, vmalloc: remove useless variable in vmap_block
Date: Sat, 3 Aug 2013 08:44:05 +0800 [thread overview]
Message-ID: <CANBD6kF0qBzPXKxA2AqT=xER6kjdQV6B01VsdbxuuO09av5Knw@mail.gmail.com> (raw)
In-Reply-To: <CANBD6kFf0nyr=AZU6fv-FWOHoAkRkLV4+HyyvXDvfF8=38x-eA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1411 bytes --]
On Saturday, August 3, 2013, Yanfei Zhang wrote:
> On Friday, August 2, 2013, Joonsoo Kim wrote:
>
>> vbq in vmap_block isn't used. So remove it.
>>
>> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
>
>
> Acked-by: Zhang Yanfei <zhangyanfei@cn.fujitsu.con>
>
Sorry, the mail was wrongly written, it should be :
Acked-by: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
>
>
>> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
>> index 13a5495..d23c432 100644
>> --- a/mm/vmalloc.c
>> +++ b/mm/vmalloc.c
>> @@ -752,7 +752,6 @@ struct vmap_block_queue {
>> struct vmap_block {
>> spinlock_t lock;
>> struct vmap_area *va;
>> - struct vmap_block_queue *vbq;
>> unsigned long free, dirty;
>> DECLARE_BITMAP(dirty_map, VMAP_BBMAP_BITS);
>> struct list_head free_list;
>> @@ -830,7 +829,6 @@ static struct vmap_block *new_vmap_block(gfp_t
>> gfp_mask)
>> radix_tree_preload_end();
>>
>> vbq = &get_cpu_var(vmap_block_queue);
>> - vb->vbq = vbq;
>> spin_lock(&vbq->lock);
>> list_add_rcu(&vb->free_list, &vbq->free);
>> spin_unlock(&vbq->lock);
>> --
>> 1.7.9.5
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at http://www.tux.org/lkml/
>>
>
[-- Attachment #2: Type: text/html, Size: 2549 bytes --]
prev parent reply other threads:[~2013-08-03 0:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-02 1:57 Joonsoo Kim
2013-08-02 1:57 ` [PATCH 2/2] mm, vmalloc: use well-defined find_last_bit() func Joonsoo Kim
2013-08-02 8:28 ` Wanpeng Li
2013-08-02 8:28 ` Wanpeng Li
2013-08-02 19:22 ` Johannes Weiner
2013-08-03 0:46 ` Yanfei Zhang
2013-08-02 8:14 ` [PATCH 1/2] mm, vmalloc: remove useless variable in vmap_block Wanpeng Li
2013-08-02 8:14 ` Wanpeng Li
2013-08-02 19:15 ` Johannes Weiner
2013-08-03 0:38 ` Yanfei Zhang
2013-08-03 0:44 ` Yanfei Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANBD6kF0qBzPXKxA2AqT=xER6kjdQV6B01VsdbxuuO09av5Knw@mail.gmail.com' \
--to=zhangyanfei.yes@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=js1304@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=zhangyanfei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox