From: Tri Vo <trong@android.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Nick Desaulniers <ndesaulniers@google.com>,
Peter Oberparleiter <oberpar@linux.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Greg Hackmann <ghackmann@android.com>,
linux-mm@kvack.org, kbuild-all@01.org,
kbuild test robot <lkp@intel.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] gcov: fix when CONFIG_MODULES is not set
Date: Sat, 30 Mar 2019 16:57:30 -0700 [thread overview]
Message-ID: <CANA+-vAcW0VfAZmZWi84s1pQQ+tFx8VyzYsWi5_gj7vHT3Ao6Q@mail.gmail.com> (raw)
In-Reply-To: <83226cfb-afa7-0174-896c-d9f7a6193cf4@infradead.org>
On Fri, Mar 29, 2019 at 1:53 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> On 3/29/19 11:18 AM, Nick Desaulniers wrote:
> > Fixes commit 8c3d220cb6b5 ("gcov: clang support")
>
> There is a certain format for Fixes: and that's not quite it. :(
>
> > Cc: Greg Hackmann <ghackmann@android.com>
> > Cc: Tri Vo <trong@android.com>
> > Cc: Peter Oberparleiter <oberpar@linux.ibm.com>
> > Cc: linux-mm@kvack.org
> > Cc: kbuild-all@01.org
> > Reported-by: Randy Dunlap <rdunlap@infradead.org>
> > Reported-by: kbuild test robot <lkp@intel.com>
> > Link: https://marc.info/?l=linux-mm&m=155384681109231&w=2
> > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
>
> Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
>
> Thanks.
>
> > ---
> > kernel/gcov/gcc_3_4.c | 4 ++++
> > kernel/gcov/gcc_4_7.c | 4 ++++
> > 2 files changed, 8 insertions(+)
Thanks for taking a look at this Nick! I believe same fix should be
applied to kernel/gcov/clang.c. I'll send out an updated version later
today.
next prev parent reply other threads:[~2019-03-30 23:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-29 8:06 [linux-next:master 4291/4370] kernel/gcov/gcc_4_7.c:162:9: error: implicit declaration of function 'within_module'; did you mean 'init_module'? kbuild test robot
2019-03-29 17:45 ` [PATCH] gcov: include linux/module.h for within_module Nick Desaulniers
2019-03-29 18:01 ` Randy Dunlap
2019-03-29 18:08 ` Randy Dunlap
2019-03-29 18:09 ` Nick Desaulniers
2019-03-29 18:10 ` Randy Dunlap
2019-03-29 18:18 ` [PATCH v2] gcov: fix when CONFIG_MODULES is not set Nick Desaulniers
2019-03-29 20:53 ` Randy Dunlap
2019-03-30 23:57 ` Tri Vo [this message]
2019-04-02 2:54 ` Nick Desaulniers
2019-04-03 15:24 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANA+-vAcW0VfAZmZWi84s1pQQ+tFx8VyzYsWi5_gj7vHT3Ao6Q@mail.gmail.com \
--to=trong@android.com \
--cc=akpm@linux-foundation.org \
--cc=ghackmann@android.com \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=ndesaulniers@google.com \
--cc=oberpar@linux.ibm.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox